Improved discoverability of tests; handle exceptions thrown during test execution

CMakeSettings.json

@@ -290,7 +290,7 @@
       "configurationType": "Debug",
       "buildRoot": "${projectDir}\\out\\build\\${name}",
       "installRoot": "${projectDir}\\out\\install\\${name}",
-      "cmakeCommandArgs": "-DINSTALL_GTEST=OFF -DBUILD_TESTING=ON -DBUILD_TRANSPORT_CURL=ON -DBUILD_SAMPLES=ON -DBUILD_PERFORMANCE_TESTS=ON",
+      "cmakeCommandArgs": "",
       "buildCommandArgs": "-v",
       "inheritEnvironments": [ "msvc_x64_x64" ],
       "variables": [
@@ -299,6 +299,88 @@
           "value": "x64-windows-static",
           "type": "STRING"
         },
+        {
+          "name": "INSTALL_GTEST",
+          "value": "False",
+          "type": "BOOL"
+        },
+        {
+          "name": "BUILD_TESTING",
+          "value": "True",
+          "type": "BOOL"
+        },
+        {
+          "name": "BUILD_SAMPLES",
+          "value": "True",
+          "type": "BOOL"
+        },
+        {
+          "name": "BUILD_PERFORMANCE_TESTS",
+          "value": "True",
+          "type": "BOOL"
+        },
+        {
+          "name": "BUILD_TRANSPORT_WINHTTP",
+          "value": "True",
+          "type": "BOOL"
+        },
+        {
+          "name": "BUILD_TRANSPORT_CURL",
+          "value": "True",
+          "type": "BOOL"
+        },
+        {
+          "name": "MSVC_USE_STATIC_CRT",
+          "value": "True",
+          "type": "BOOL"
+        }
+      ]
+    },
+    {
+      "name": "x64-ReleaseWithPerfTest",
+      "generator": "Ninja",
+      "configurationType": "RelWithDebInfo",
+      "buildRoot": "${projectDir}\\out\\build\\${name}",
+      "installRoot": "${projectDir}\\out\\install\\${name}",
+      "cmakeCommandArgs": "",
+      "buildCommandArgs": "-v",
+      "inheritEnvironments": [ "msvc_x64_x64" ],
+      "variables": [
+        {
+          "name": "VCPKG_TARGET_TRIPLET",
+          "value": "x64-windows-static",
+          "type": "STRING"
+        },
+        {
+          "name": "INSTALL_GTEST",
+          "value": "False",
+          "type": "BOOL"
+        },
+        {
+          "name": "BUILD_TESTING",
+          "value": "True",
+          "type": "BOOL"
+        },
+        {
+          "name": "BUILD_SAMPLES",
+          "value": "True",
+          "type": "BOOL"
+        },
+        {
+          "name": "BUILD_PERFORMANCE_TESTS",
+          "value": "True",
+          "type": "BOOL"
+        },
+        {
+          "name": "BUILD_TRANSPORT_WINHTTP",
+          "value": "True",
+          "type": "BOOL"
+        },
+        {
+          "name": "BUILD_TRANSPORT_CURL",
+          "value": "True",
+          "type": "BOOL"
+        },
         {
           "name": "MSVC_USE_STATIC_CRT",
           "value": "True",

sdk/core/perf/README.md

@@ -46,6 +46,7 @@ usage: azure-perf-test testName [options]
 >Note: You can use the option `-h` to print out the available options for a test name.
 
 The next options can be used for any test:
+
 | Option     | Activators | Description | Default | Example |
 | ---------- | ---        | ---| ---| --- |
 | Duration   | -d, --duration   | Duration of the test in seconds                  | 10    | -d 5

sdk/core/perf/inc/azure/perf/argagg.hpp

@@ -1436,7 +1436,7 @@ inline fmt_ostream::~fmt_ostream() { output << fmt_string(this->str()); }
 
 inline std::string lstrip(const std::string& text)
 {
-  auto result = text;
+  std::string result = text;
 
   result.erase(result.begin(), std::find_if(result.begin(), result.end(), [](int ch) {
                  return !std::isspace(ch);
@@ -1447,7 +1447,7 @@ inline std::string lstrip(const std::string& text)
 
 inline std::string rstrip(const std::string& text)
 {
-  auto result = text;
+  std::string result = text;
 
   result.erase(
       std::find_if(result.rbegin(), result.rend(), [](int ch) { return !std::isspace(ch); }).base(),

sdk/core/perf/src/arg_parser.cpp

@@ -18,12 +18,12 @@ argagg::parser_results Azure::Perf::Program::ArgParser::Parse(
   // Option Name, Activate options, display message and number of expected args.
   argagg::parser argParser;
   auto optionsMetadata = Azure::Perf::GlobalTestOptions::GetOptionMetadata();
-  for (auto option : testOptions)
+  for (auto const& option : testOptions)
   {
     argParser.definitions.push_back(
         {option.Name, option.Activators, option.DisplayMessage, option.ExpectedArgs});
   }
-  for (auto option : optionsMetadata)
+  for (auto const& option : optionsMetadata)
   {
     argParser.definitions.push_back(
         {option.Name, option.Activators, option.DisplayMessage, option.ExpectedArgs});

sdk/core/perf/src/base_test.cpp

@@ -32,7 +32,7 @@ class ProxyPolicy final : public HttpPolicy {
   ProxyPolicy(ProxyPolicy const& other) : ProxyPolicy{other.m_testContext} {}
 
   // move
-  ProxyPolicy(ProxyPolicy&& other) : m_testContext{other.m_testContext} {}
+  ProxyPolicy(ProxyPolicy&& other) noexcept : m_testContext{other.m_testContext} {}
 
   std::unique_ptr<RawResponse> Send(
       Request& request,
@@ -138,72 +138,81 @@ namespace Azure { namespace Perf {
   void BaseTest::PostSetUp()
   {
 
-    if (!m_proxy.empty())
+    try
     {
-      Azure::Core::_internal::ClientOptions clientOp;
-      clientOp.Retry.MaxRetries = 0;
-      ConfigureInsecureConnection(clientOp);
-      std::vector<std::unique_ptr<Azure::Core::Http::Policies::HttpPolicy>> policiesOp;
-      std::vector<std::unique_ptr<Azure::Core::Http::Policies::HttpPolicy>> policiesRe;
-      Azure::Core::Http::_internal::HttpPipeline pipeline(
-          clientOp, "PerfFw", "na", std::move(policiesRe), std::move(policiesOp));
-      Azure::Core::Context ctx;
-
-      //  Make one call to Run() before starting recording, to avoid capturing one-time setup
-      //  like authorization requests.
-      this->Run(ctx);
-
-      // Send start-record call
-      {
-        Azure::Core::Url startRecordReq(m_proxy);
-        startRecordReq.AppendPath("record");
-        startRecordReq.AppendPath("start");
-        Azure::Core::Http::Request request(Azure::Core::Http::HttpMethod::Post, startRecordReq);
-        auto response = pipeline.Send(request, ctx);
-
-        auto const& headers = response->GetHeaders();
-        auto findHeader = std::find_if(
-            headers.begin(),
-            headers.end(),
-            [](std::pair<std::string const&, std::string const&> h) {
-              return h.first == "x-recording-id";
-            });
-        m_recordId = findHeader->second;
-      }
-
-      // Record one call to re-use response on all test runs
-      this->Run(ctx);
 
-      // Stop recording
+      if (!m_proxy.empty())
       {
-        Azure::Core::Url stopRecordReq(m_proxy);
-        stopRecordReq.AppendPath("record");
-        stopRecordReq.AppendPath("stop");
-        Azure::Core::Http::Request request(Azure::Core::Http::HttpMethod::Post, stopRecordReq);
-        request.SetHeader("x-recording-id", m_recordId);
-        pipeline.Send(request, ctx);
-      }
-
-      // Start playback
-      {
-        Azure::Core::Url startPlayback(m_proxy);
-        startPlayback.AppendPath("playback");
-        startPlayback.AppendPath("start");
-        Azure::Core::Http::Request request(Azure::Core::Http::HttpMethod::Post, startPlayback);
-        request.SetHeader("x-recording-id", m_recordId);
-        auto response = pipeline.Send(request, ctx);
-
-        auto const& headers = response->GetHeaders();
-        auto findHeader = std::find_if(
-            headers.begin(),
-            headers.end(),
-            [](std::pair<std::string const&, std::string const&> h) {
-              return h.first == "x-recording-id";
-            });
-        m_recordId = findHeader->second;
-        m_isPlayBackMode = true;
+        Azure::Core::_internal::ClientOptions clientOp;
+        clientOp.Retry.MaxRetries = 0;
+        ConfigureInsecureConnection(clientOp);
+        std::vector<std::unique_ptr<Azure::Core::Http::Policies::HttpPolicy>> policiesOp;
+        std::vector<std::unique_ptr<Azure::Core::Http::Policies::HttpPolicy>> policiesRe;
+        Azure::Core::Http::_internal::HttpPipeline pipeline(
+            clientOp, "PerfFw", "na", std::move(policiesRe), std::move(policiesOp));
+        Azure::Core::Context ctx;
+
+        //  Make one call to Run() before starting recording, to avoid capturing one-time setup
+        //  like authorization requests.
+        this->Run(ctx);
+
+        // Send start-record call
+        {
+          Azure::Core::Url startRecordReq(m_proxy);
+          startRecordReq.AppendPath("record");
+          startRecordReq.AppendPath("start");
+          Azure::Core::Http::Request request(Azure::Core::Http::HttpMethod::Post, startRecordReq);
+          auto response = pipeline.Send(request, ctx);
+
+          auto const& headers = response->GetHeaders();
+          auto findHeader = std::find_if(
+              headers.begin(),
+              headers.end(),
+              [](std::pair<std::string const&, std::string const&> h) {
+                return h.first == "x-recording-id";
+              });
+          m_recordId = findHeader->second;
+        }
+
+        // Record one call to re-use response on all test runs
+        this->Run(ctx);
+
+        // Stop recording
+        {
+          Azure::Core::Url stopRecordReq(m_proxy);
+          stopRecordReq.AppendPath("record");
+          stopRecordReq.AppendPath("stop");
+          Azure::Core::Http::Request request(Azure::Core::Http::HttpMethod::Post, stopRecordReq);
+          request.SetHeader("x-recording-id", m_recordId);
+          pipeline.Send(request, ctx);
+        }
+
+        // Start playback
+        {
+          Azure::Core::Url startPlayback(m_proxy);
+          startPlayback.AppendPath("playback");
+          startPlayback.AppendPath("start");
+          Azure::Core::Http::Request request(Azure::Core::Http::HttpMethod::Post, startPlayback);
+          request.SetHeader("x-recording-id", m_recordId);
+          auto response = pipeline.Send(request, ctx);
+
+          auto const& headers = response->GetHeaders();
+          auto findHeader = std::find_if(
+              headers.begin(),
+              headers.end(),
+              [](std::pair<std::string const&, std::string const&> h) {
+                return h.first == "x-recording-id";
+              });
+          m_recordId = findHeader->second;
+          m_isPlayBackMode = true;
+        }
       }
     }
+    catch (std::exception const& e)
+    {
+      std::cout << "Exception thrown after setup: " << e.what() << std::endl;
+      throw;
+    }
   }
 
   void BaseTest::PreCleanUp()