fix some issues in protocol layer#3880
Merged
Jinming-Hu merged 1 commit intoAzure:feature/filesharestg82from Aug 11, 2022
Merged
fix some issues in protocol layer#3880Jinming-Hu merged 1 commit intoAzure:feature/filesharestg82from
Jinming-Hu merged 1 commit intoAzure:feature/filesharestg82from
Conversation
Jinming-Hu
added
Client
Jinming-Hu
requested review from
EmmaZhu,
LarryOsterman,
antkmsft,
gearama,
katmsft,
vhvb1989 and
vinjiang
as code owners
EmmaZhu
reviewed
Aug 11, 2022
sdk/storage/azure-storage-files-shares/inc/azure/storage/files/shares/rest_client.hpp
Show resolved
Hide resolved
EmmaZhu
approved these changes
Aug 11, 2022
Member
Author
|
/check-enforcer override |
ahsonkhan
reviewed
Aug 11, 2022
Comment on lines
+222
to
+223
| delete $.FileChangeTime.format; | ||
| $.FileLastWriteTimeMode["x-ms-enum"]["values"] = [{"value": "now", "name": "Now"},{"value": "preserve", "name": "Preserve"}]; |
Contributor
There was a problem hiding this comment.
Why do we have to modify the swagger in this case?
Is the swagger wrong, and do other languages behave the same way?
Member
Author
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
Other languages also do this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.