Skip to content

Fix incorrect failure notification in vcpkg publishing #3838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danieljurek merged 29 commits into from
Jul 21, 2022
Merged

Fix incorrect failure notification in vcpkg publishing #3838

Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
3fa5606
Set up for testing of template pipeline
danieljurek Jul 12, 2022
1c008cf
Override branches, set up for template GA release
danieljurek Jul 12, 2022
3d3a6ee
More TODOs to prevent merging an unintended change
danieljurek Jul 12, 2022
d674489
More removal of TestPipeline
danieljurek Jul 12, 2022
6b7d216
Increment template version number
danieljurek Jul 13, 2022
882876a
Use script to set package version
danieljurek Jul 13, 2022
be3bcb9
Check out the correct branch
danieljurek Jul 14, 2022
b5e7dfb
branch parameter in the command
danieljurek Jul 14, 2022
f5cd1b1
Use $(PublishToVcpkg) to determine if we should check for changes
danieljurek Jul 14, 2022
62a24cf
dictionary syntax
danieljurek Jul 14, 2022
76c5a9f
Set GA package version to validate GA publish scenario
danieljurek Jul 18, 2022
3a74a31
Update changelog
danieljurek Jul 18, 2022
243f42a
create-pull-request.yml optionally pushes changes
danieljurek Jul 18, 2022
c5b3adc
Output GH PR URI
danieljurek Jul 18, 2022
be3f7a1
Macro syntax with a variable set earlier
danieljurek Jul 18, 2022
d4b5b56
Move up to 1.2.0-beta.2
danieljurek Jul 18, 2022
8e64e85
beta.1
danieljurek Jul 18, 2022
79d7e30
Revert changelog
danieljurek Jul 18, 2022
0864477
Revert testing-related changes
danieljurek Jul 18, 2022
566ce40
Revert vcpkg-clone.yml
danieljurek Jul 18, 2022
5004211
Revert eng/common changes, ensure global $(HasChanges) is set properly
danieljurek Jul 20, 2022
ce5bc5c
Changes to enable testing
danieljurek Jul 20, 2022
7dc258d
1.1.0-beta.1
danieljurek Jul 20, 2022
285f290
vcpkg clone should clone at configured branch
danieljurek Jul 20, 2022
ec7725d
Clone "main" branch of vcpkg betas
danieljurek Jul 20, 2022
dae9eca
Undo test-specific changes
danieljurek Jul 20, 2022
1d98689
More PR cleanup
danieljurek Jul 20, 2022
6d30f34
PR cleanup
danieljurek Jul 20, 2022
540d806
displayName
danieljurek Jul 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions eng/pipelines/templates/stages/archetype-cpp-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ stages:
- pwsh: |
$branchName = "azure-sdk-for-cpp-${{ artifact.Name }}-$(Build.BuildId)"
if ('$(VcpkgForkBranchName)') {
Write-Host "Using queue time branch name"
Write-Host "Using queue time branch name"
$branchName = '$(VcpkgForkBranchName)'
}
Write-Host "##vso[task.setvariable variable=PrBranchName]$branchName"
Expand Down Expand Up @@ -164,14 +164,12 @@ stages:
CommitMsg: Update vcpkg-configuration.json
BaseRepoBranch: $(DefaultBranch)

# Set $(HasChanges) to $true so that
# create-pull-request.yml completes the push and PR
# submission steps. This is contegnent upon
# `$(PublishToVcpkg)` being `true`. `$(PublishToVcpkg)` is
# set in `vcpkg-publish.yml`
- pwsh: Write-Host "##vso[task.setvariable variable=HasChanges]$true"
condition: and(succeeded(), eq(variables['PublishToVcpkg'], 'true'))
displayName: Set $(HasChanges) to $true for create-pull-request.yml
# Set $(HasChanges) to $(PublishToVcpkg) so that
# create-pull-request.yml creates or does not create a PR
# based on the deicision of the step that determines
# whether to publish to vcpkg.
- pwsh: Write-Host "##vso[task.setvariable variable=HasChanges]$(PublishToVcpkg)"
displayName: Set $(HasChanges) to $(PublishToVcpkg) for create-pull-request.yml

- template: /eng/common/pipelines/templates/steps/set-default-branch.yml
parameters:
Expand Down