Initial WebSockets implementation.#3823
Merged
LarryOsterman merged 160 commits intoAzure:feature/websocketsfrom Jul 27, 2022
Merged
Initial WebSockets implementation.#3823LarryOsterman merged 160 commits intoAzure:feature/websocketsfrom
LarryOsterman merged 160 commits intoAzure:feature/websocketsfrom
Conversation
RickWinter
reviewed
Jul 26, 2022
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
RickWinter
reviewed
Jul 26, 2022
gearama
suggested changes
Jul 26, 2022
sdk/core/azure-core/inc/azure/core/http/websockets/curl_websockets_transport.hpp
Show resolved
Hide resolved
RickWinter
reviewed
Jul 26, 2022
RickWinter
reviewed
Jul 26, 2022
RickWinter
reviewed
Jul 26, 2022
RickWinter
reviewed
Jul 26, 2022
RickWinter
reviewed
Jul 26, 2022
RickWinter
reviewed
Jul 26, 2022
RickWinter
reviewed
Jul 26, 2022
RickWinter
reviewed
Jul 26, 2022
RickWinter
reviewed
Jul 26, 2022
RickWinter
reviewed
Jul 27, 2022
RickWinter
reviewed
Jul 27, 2022
RickWinter
reviewed
Jul 27, 2022
RickWinter
reviewed
Jul 27, 2022
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
…erman/azure-sdk-for-cpp into larryo/createwebsockets
gearama
approved these changes
Jul 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a WebSockets transport implementation for Azure Core.
The Cognitive Services team requires support for WebSockets to complete their move to Azure Core.
This pull request has two sets of changes
The WebSocket protocol is implemented in the
Azure::Core::Http::WebSockets::_internal::WebSocketclass. It depends on aWebSocketTransportclass and the existingHttpTransportclass and uses our existing Http Pipeline technology for the initial WebSocket protocol exchange.Note that this PR is going into
feature/websocketsand NOT intomain. As a consequence, it is extremely hard for parts of this PR to be extracted and submitted separately.