Skip to content

Initial WebSockets implementation.#3823

Merged
LarryOsterman merged 160 commits intoAzure:feature/websocketsfrom
LarryOsterman:larryo/createwebsockets
Jul 27, 2022
Merged

Initial WebSockets implementation.#3823
LarryOsterman merged 160 commits intoAzure:feature/websocketsfrom
LarryOsterman:larryo/createwebsockets

Conversation

@LarryOsterman
Copy link
Member

@LarryOsterman LarryOsterman commented Jul 13, 2022

Create a WebSockets transport implementation for Azure Core.

The Cognitive Services team requires support for WebSockets to complete their move to Azure Core.

This pull request has two sets of changes

  1. A complete implementation of the WebSockets protocol
  2. A set of changes required to pass the CI gates with the WebSockets protocol changes.

The WebSocket protocol is implemented in the Azure::Core::Http::WebSockets::_internal::WebSocket class. It depends on a WebSocketTransport class and the existing HttpTransport class and uses our existing Http Pipeline technology for the initial WebSocket protocol exchange.

Note that this PR is going into feature/websockets and NOT into main. As a consequence, it is extremely hard for parts of this PR to be extracted and submitted separately.

LarryOsterman and others added 2 commits July 26, 2022 16:18
Copy link
Contributor

@gearama gearama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few comments

Copy link
Member

@RickWinter RickWinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done :)

@LarryOsterman LarryOsterman merged commit 5cff286 into Azure:feature/websockets Jul 27, 2022
@LarryOsterman LarryOsterman deleted the larryo/createwebsockets branch July 27, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants