-
Notifications
You must be signed in to change notification settings - Fork 150
Initial implementation of OpenTelemetry APIs. #3561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
LarryOsterman
merged 80 commits into
Azure:main
from
LarryOsterman:larryo/tracingprototype
May 23, 2022
Merged
Changes from all commits
Commits
Show all changes
80 commits
Select commit
Hold shift + click to select a range
ef80f64
Start of tracing prototype
LarryOsterman 404b3e4
Created initial implementation of azure-core-opentelemetry package
LarryOsterman c286c64
CI pipeline fixes
LarryOsterman a00d8e2
Virtual dtor for AttributeSet class
LarryOsterman bba338e
clang-format
LarryOsterman b383ede
Renamed Options::SpanKind to avoid conflict with enumeration
LarryOsterman 46030eb
Suppress OTel warnings
LarryOsterman 415cc14
More OTel warning suppression
LarryOsterman 0485a71
More OTel warning suppression
LarryOsterman 62b1e02
More OTel warnings; fixed size_t comparison
LarryOsterman 5cf8f49
Enable static CRT for -static builds in pipeline; make uwp builds use…
LarryOsterman 8b8e5f9
Undid version baseline change because it broke CI pipeline
LarryOsterman c54e85e
Added default triplet for UWP x86 builds; fixed compiler warning; mes…
LarryOsterman a65c6b8
uwp-xxx-static doesn't exist as a valid triplet :(
LarryOsterman 92e6ca3
New version of enabling MSVCRT Lib for static configs
LarryOsterman 626f921
Attempt to add OpenTelemetry tests to build
LarryOsterman 9ee3912
Added -DMSVC to list of spelling errors :(
LarryOsterman 215aeec
Removed unnecessary sdk_config.h workaround; set opentelemetry versio…
LarryOsterman ae63b7c
Disable OpenTelemetry implementation on UWP builds because they requi…
LarryOsterman 9224edd
Take a dependency on OpenTelemetry version 1.3
LarryOsterman 301e1b9
Different version of disable OpenTelemetry implemetnation
LarryOsterman e24afcf
Spelling errors; removed version checks in vcpkg.json
LarryOsterman f78be44
Remove otel dependency on uwp builds
LarryOsterman bcf12e1
Require OpenTelemetry 1.3; Updated vcpkg baseline commit to include o…
LarryOsterman 798a06b
Added description of vcpkg clone step
LarryOsterman fafd32d
Pin version numbers for packages
LarryOsterman f2d9368
Updated libxml2 version
LarryOsterman 3086c19
clang compile fix
LarryOsterman dfacaec
Strongly type int64 vaues
LarryOsterman 13ff042
More type strictness changes; clang-format
LarryOsterman 9cba8df
Removed hard version artifacts in vcpkg.json file
LarryOsterman 8316472
Cleaned up diff a bit
LarryOsterman 90942ef
Cleaned up diff a bit
LarryOsterman 08ad073
Added implementation for AddEvent;
LarryOsterman 3f99f37
doccomment; clang-format
LarryOsterman 1637049
Added changelog, readme, license notice, etc to OpenTelemetry
LarryOsterman fa21b79
clang-format
LarryOsterman ed4b8f5
Explicitly set span hierarchy instead of implicitly setting it
LarryOsterman d476083
Improved documentation for CreateSpan.
LarryOsterman 2506d2e
curl_format
LarryOsterman 484ef98
First steps in integrating tracing with client
LarryOsterman 812777f
API Review feedback
LarryOsterman ef066c7
Merge branch 'main' into larryo/tracingprototype
LarryOsterman 78ca933
Checkpoint
LarryOsterman e5f3827
Merge branch 'main' into larryo/tracingprototype
LarryOsterman bd320e1
Added service API level tracing support
LarryOsterman f7af413
Initial service client test implementation
LarryOsterman 50aec0e
Initial service client test implementation
LarryOsterman 3c296d5
Added throwing client method
LarryOsterman 837774b
Merge branch 'main' into larryo/tracingprototype
LarryOsterman 715f999
CI fix
LarryOsterman 1fbee85
Added missing rethrow
LarryOsterman 43c3845
clang-format
LarryOsterman 1e74d8d
Added unit tests in core for new core classes
LarryOsterman 11df8cd
Removed some comments that upset clang
LarryOsterman 7f5abc4
Made destructor of virtual class virtual
LarryOsterman 3415487
Created service_tracing tests to close code coverage gaps
LarryOsterman a358f4a
Merge branch 'main' into larryo/tracingprototype
LarryOsterman e710e75
Moved most of the API implementation for distributed tracing into _in…
LarryOsterman 856c263
Merge branch 'main' into larryo/tracingprototype
LarryOsterman 718d106
Pull request feedback; renamed a bunch of stuff
LarryOsterman 0db651a
Fixed cgmanifest.json
LarryOsterman f42798c
Added opentelemetry-cpp license
LarryOsterman 4d7123d
clang-format
LarryOsterman b4ab09f
Added some test cases for code coverage
LarryOsterman 561c72b
Another try at defining Span
LarryOsterman 03a1e9d
clang-format
LarryOsterman 279a201
More CI code coverage
LarryOsterman 2f6c7f8
Added readme and updated changelog for core
LarryOsterman 84013ac
Merge branch 'main' into larryo/tracingprototype
LarryOsterman a1b12a2
Code review feedback and API surface cleanup
LarryOsterman 58c324f
Renamed core-tracing-opentelemetry to core/tracing-opentelemetry
LarryOsterman ad763ec
MacOS build fixes
LarryOsterman 65a9a52
clang-format
LarryOsterman cb054dc
Missing crlfs
LarryOsterman 8c8c329
Noise reduction; added a bunch of forward looking definitions
LarryOsterman d2c7532
Noise reduction
LarryOsterman 8a6895c
Moved core/tracing-opentelemetry to core/tracing/opentelemetry
LarryOsterman 11445f2
API Review feedback
LarryOsterman 6dfc0da
Merge branch 'main' into larryo/tracingprototype
LarryOsterman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,3 +31,4 @@ steps: | |
| -Ref $(VcpkgCommit) | ||
| -VcpkgPath $(VCPKG_INSTALLATION_ROOT) | ||
| pwsh: true | ||
| displayName: Clone Vcpkg. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| # Release History | ||
|
|
||
| ## 1.0.0-beta.1 (Unreleased) | ||
|
|
||
| - Initial release | ||
LarryOsterman marked this conversation as resolved.
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,95 @@ | ||
| # Copyright (c) Microsoft Corporation. All rights reserved. | ||
| # SPDX-License-Identifier: MIT | ||
|
|
||
| # setting CMAKE_TOOLCHAIN_FILE must happen before creating the project | ||
| list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/../../../cmake-modules") | ||
| include(AzureVcpkg) | ||
| az_vcpkg_integrate() | ||
|
|
||
| # Azure core is compatible with CMake 3.12 | ||
| cmake_minimum_required (VERSION 3.12) | ||
| project(azure-core-tracing-opentelemetry LANGUAGES CXX) | ||
|
|
||
| set(CMAKE_CXX_STANDARD 14) | ||
| set(CMAKE_CXX_STANDARD_REQUIRED True) | ||
| set(CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS ON) | ||
|
|
||
| include(AzureVersion) | ||
| include(AzureCodeCoverage) | ||
| include(AzureTransportAdapters) | ||
| include(AzureDoxygen) | ||
| include(AzureGlobalCompileOptions) | ||
| include(AzureConfigRTTI) | ||
| # Add create_map_file function | ||
| include(CreateMapFile) | ||
|
|
||
| find_package(Threads REQUIRED) | ||
|
|
||
| if(NOT AZ_ALL_LIBRARIES) | ||
| find_package(azure-core-cpp "1.5.0" CONFIG QUIET) | ||
| if(NOT azure-core-cpp_FOUND) | ||
| find_package(azure-core-cpp "1.5.0" REQUIRED) | ||
| endif() | ||
| endif() | ||
| find_package(opentelemetry-cpp "1.3.0" CONFIG REQUIRED) | ||
|
|
||
| set( | ||
| AZURE_CORE_OPENTELEMETRY_HEADER | ||
| inc/azure/core/tracing/opentelemetry/opentelemetry.hpp | ||
| ) | ||
|
|
||
| set( | ||
| AZURE_CORE_OPENTELEMETRY_SOURCE | ||
| src/opentelemetry.cpp | ||
| ) | ||
|
|
||
| add_library(azure-core-tracing-opentelemetry ${AZURE_CORE_OPENTELEMETRY_HEADER} ${AZURE_CORE_OPENTELEMETRY_SOURCE}) | ||
|
|
||
| target_include_directories( | ||
| azure-core-tracing-opentelemetry | ||
| PUBLIC | ||
| $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/inc> | ||
| $<INSTALL_INTERFACE:include> | ||
| ) | ||
|
|
||
| # make sure that users can consume the project as a library. | ||
| add_library(Azure::azure-core-tracing-opentelemetry ALIAS azure-core-tracing-opentelemetry) | ||
|
|
||
| # coverage. Has no effect if BUILD_CODE_COVERAGE is OFF | ||
| create_code_coverage(core-tracing-opentelemetry azure-core-tracing-opentelemetry azure-core-tracing-opentelemetry-test "tests?/*;samples?/*") | ||
|
|
||
| target_link_libraries(azure-core-tracing-opentelemetry INTERFACE Threads::Threads) | ||
|
|
||
| target_link_libraries(azure-core-tracing-opentelemetry PRIVATE azure-core | ||
| opentelemetry-cpp::api | ||
| opentelemetry-cpp::ext | ||
| opentelemetry-cpp::sdk | ||
| opentelemetry-cpp::trace) | ||
|
|
||
|
|
||
| get_az_version("${CMAKE_CURRENT_SOURCE_DIR}/src/private/package_version.hpp") | ||
| generate_documentation(azure-core-opentelemetry ${AZ_LIBRARY_VERSION}) | ||
|
|
||
| az_vcpkg_export( | ||
| azure-core-tracing-opentelemetry | ||
| CORE_TRACING_OPENTELEMETRY | ||
| "azure/core/tracing/opentelemetry/dll_import_export.hpp" | ||
| ) | ||
|
|
||
| az_rtti_setup( | ||
| azure-core-tracing-opentelemetry | ||
| CORE_TRACING_OPENTELEMETRY | ||
| "azure/core/tracing/opentelemetry/rtti.hpp" | ||
| ) | ||
|
|
||
| if(BUILD_TESTING) | ||
| # define a symbol that enables some test hooks in code | ||
| add_compile_definitions(TESTING_BUILD) | ||
|
|
||
| if (NOT AZ_ALL_LIBRARIES) | ||
| include(AddGoogleTest) | ||
| enable_testing () | ||
| endif() | ||
|
|
||
| add_subdirectory(test/ut) | ||
| endif() |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.