Skip to content

Rename winhttp transport option #3488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vhvb1989 merged 6 commits into from
Mar 31, 2022
Merged

Rename winhttp transport option #3488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5baf316
rename option
vhvb1989 Mar 30, 2022
045384d
changelog
vhvb1989 Mar 30, 2022
4f64733
Update sdk/core/azure-core/inc/azure/core/http/win_http_transport.hpp
vhvb1989 Mar 31, 2022
c23441c
rename
vhvb1989 Mar 31, 2022
d415da8
Merge branch 'rename-winhttp-transport-option' of github.com:vhvb1989…
vhvb1989 Mar 31, 2022
a4c65bf
Update sdk/core/azure-core/CHANGELOG.md
vhvb1989 Mar 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/core/azure-core/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
### Features Added

- When a `RequestFailedException` exception is thrown, the `what()` method now includes information about the HTTP request which failed.
- Adding option `WinHttpTransportOptions.IgnoreUnknownServerCert`. It can be used to disable verifying server certificate for the `WinHttpTransport`.
- Adding option `WinHttpTransportOptions.IgnoreUnknownCertificateAuthority`. It can be used to disable verifying server certificate for the `WinHttpTransport`.

### Breaking Changes

Expand Down
5 changes: 2 additions & 3 deletions sdk/core/azure-core/inc/azure/core/http/win_http_transport.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,10 +129,9 @@ namespace Azure { namespace Core { namespace Http {
struct WinHttpTransportOptions final
{
/**
* @brief When `true`, allows an invalid certificate authority. If this flag is set, the
* application does not receive a WINHTTP_CALLBACK_STATUS_FLAG_INVALID_CA callback.
* @brief When `true`, allows an invalid certificate authority.
*/
bool IgnoreUnknownServerCert = false;
bool IgnoreUnknownCertificateAuthority = false;
};

/**
Expand Down
2 changes: 1 addition & 1 deletion sdk/core/azure-core/src/http/winhttp/win_http_transport.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ void WinHttpTransport::CreateRequestHandle(std::unique_ptr<_detail::HandleManage
}
}

if (m_options.IgnoreUnknownServerCert)
if (m_options.IgnoreUnknownCertificateAuthority)
{
auto option = SECURITY_FLAG_IGNORE_UNKNOWN_CA;
if (!WinHttpSetOption(
Expand Down
2 changes: 1 addition & 1 deletion sdk/core/perf/src/base_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ namespace Azure { namespace Perf {
= std::make_shared<Azure::Core::Http::CurlTransport>(curlOptions);
#elif defined(BUILD_TRANSPORT_WINHTTP_ADAPTER)
Azure::Core::Http::WinHttpTransportOptions winHttpOptions;
winHttpOptions.IgnoreUnknownServerCert = true;
winHttpOptions.IgnoreUnknownCertificateAuthority = true;
clientOptions.Transport.Transport
= std::make_shared<Azure::Core::Http::WinHttpTransport>(winHttpOptions);
#else
Expand Down