[PERF FW] Insecure cert libcurl

sdk/core/azure-core/inc/azure/core/http/win_http_transport.hpp

@@ -128,7 +128,11 @@ namespace Azure { namespace Core { namespace Http {
    */
   struct WinHttpTransportOptions final
   {
-    // Empty struct reserved for future options.
+    /**
+     * @brief When `true`, allows an invalid certificate authority. If this flag is set, the
+     * application does not receive a WINHTTP_CALLBACK_STATUS_FLAG_INVALID_CA callback.
+     */
+    bool IgnoreUnknownServerCert = false;
   };
 
   /**

sdk/core/azure-core/src/http/winhttp/win_http_transport.cpp

@@ -347,6 +347,16 @@ void WinHttpTransport::CreateRequestHandle(std::unique_ptr<_detail::HandleManage
       GetErrorAndThrow("Error while setting client cert context to ignore..");
     }
   }
+
+  if (m_options.IgnoreUnknownServerCert)
+  {
+    auto option = SECURITY_FLAG_IGNORE_UNKNOWN_CA;
+    if (!WinHttpSetOption(
+            handleManager->m_requestHandle, WINHTTP_OPTION_SECURITY_FLAGS, &option, sizeof(option)))
+    {
+      GetErrorAndThrow("Error while setting ignore unknown server certificate..");
+    }
+  }
 }
 
 // For PUT/POST requests, send additional data using WinHttpWriteData.

sdk/core/perf/CMakeLists.txt

@@ -56,8 +56,3 @@ create_map_file(azure-perf azure-perf.map)
 set_target_properties(azure-perf PROPERTIES FOLDER "Core")
 
 add_subdirectory(test)
-
-# Give a warning about winHTTP and insecure
-if(BUILD_TRANSPORT_WINHTTP)
-  message(WARNING "Note. WInHTTP does not support running performance tests with `insecure` mode enabled. Use libcurl transport adapter if you want to use insecure mode. ")
-endif()

sdk/core/perf/src/base_test.cpp

@@ -6,6 +6,9 @@
 #if defined(BUILD_CURL_HTTP_TRANSPORT_ADAPTER)
 #include <azure/core/http/curl_transport.hpp>
 #endif
+#if defined(BUILD_TRANSPORT_WINHTTP_ADAPTER)
+#include <azure/core/http/win_http_transport.hpp>
+#endif
 #include <azure/core/http/policies/policy.hpp>
 #include <azure/core/internal/http/pipeline.hpp>
 
@@ -102,18 +105,21 @@ namespace Azure { namespace Perf {
 
   void BaseTest::ConfigureInsecureOptions(Azure::Core::_internal::ClientOptions* clientOptions)
   {
+    // NOTE: perf-fm is injecting the SSL config and transport here for the client options
+    //       If the test overrides the options/transport, this can be undone.
 #if defined(BUILD_CURL_HTTP_TRANSPORT_ADAPTER)
     if (m_isInsecureEnabled)
     {
-      // There's currently no way to ask winHTTP to do insecure SSL.
-      // Perf test must use libcurl transport until winHTTP can support this.
-      // NOTE: perf-fm is injecting the SSL config and transport here for the client options
-      //       If the test overrides the options/transport, this can be undone.
       Azure::Core::Http::CurlTransportOptions curlOptions;
       curlOptions.SslVerifyPeer = false;
       clientOptions->Transport.Transport
           = std::make_shared<Azure::Core::Http::CurlTransport>(curlOptions);
     }
+#elif defined(BUILD_TRANSPORT_WINHTTP_ADAPTER)
+    Azure::Core::Http::WinHttpTransportOptions winHttpOptions;
+    winHttpOptions.IgnoreUnknownServerCert = true;
+    clientOptions->Transport.Transport
+        = std::make_shared<Azure::Core::Http::WinHttpTransport>(winHttpOptions);
 #else
     // avoid the variable not used warning
     (void)clientOptions;

sdk/core/perf/src/program.cpp

@@ -322,9 +322,6 @@ void Azure::Perf::Program::Run(
     }
     if (options.Insecure)
     {
-#if defined(BUILD_TRANSPORT_WINHTTP_ADAPTER)
-      std::cout << std::endl << " ERROR !!! winHTTP does not support using insecure mode.";
-#endif
       parallelTest[i]->SetInsecureEnabled(true);
     }
   }