Skip to content

Conversation

@sima-zhu
Copy link
Contributor

@sima-zhu sima-zhu commented Mar 1, 2022

Pull Request Checklist

Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:

See the detailed list in the contributing guide.

  • C++ Guidelines
  • Doxygen docs
  • Unit tests
  • No unwanted commits/changes
  • Descriptive title/description
    • PR is single purpose
    • Related issue listed
  • Comments in source
  • No typos
  • Update changelog
  • Not work-in-progress
  • External references or docs updated
  • Self review of PR done
  • Any breaking changes?

This was referenced Apr 19, 2022
@sima-zhu
Copy link
Contributor Author

@danieljurek
Copy link
Member

/azp run cpp - core - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@danieljurek
Copy link
Member

danieljurek commented May 23, 2022

Credscan results -- https://dev.azure.com/azure-sdk/public/_build/results?buildId=1594399&view=logs&j=a129effc-2dd1-54d1-fb5a-ad7bdc0e851d&t=9036d097-2774-5136-505e-b4dc0a37f42d

##[error]1. Credential Scanner Error CSCAN-GENERAL0020 - File: sdk/attestation/azure-security-attestation/test/ut/crypto_test.cpp:sdk/attestation/azure-security-attestation/test/ut/crypto_test.cpp. Line: 16. Column 46. 

##[error]2. Credential Scanner Error CSCAN-GENERAL0020 - File: sdk/attestation/azure-security-attestation/test/ut/crypto_test.cpp:sdk/attestation/azure-security-attestation/test/ut/crypto_test.cpp. Line: 28. Column 45. 

##[error]3. Credential Scanner Error CSCAN-GENERAL0020 - File: sdk/keyvault/azure-security-keyvault-certificates/test/ut/recordings/KeyVaultCertificateClientTest.DownloadImportPem.json:sdk/keyvault/azure-security-keyvault-certificates/test/ut/recordings/KeyVaultCertificateClientTest.DownloadImportPem.json. Line: 149. Column 30. 

##[error]4. Credential Scanner Error CSCAN-GENERAL0020 - File: sdk/keyvault/azure-security-keyvault-certificates/test/ut/recordings/KeyVaultCertificateClientTest.DownloadImportPkcs.json:sdk/keyvault/azure-security-keyvault-certificates/test/ut/recordings/KeyVaultCertificateClientTest.DownloadImportPkcs.json. Line: 149. Column 30. 

@gearama gearama mentioned this pull request May 24, 2022
@sima-zhu
Copy link
Contributor Author

sima-zhu commented Jun 1, 2022

/azp run cpp - core - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sima-zhu
Copy link
Contributor Author

sima-zhu commented Jun 1, 2022

/azp run cpp - core - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sima-zhu
Copy link
Contributor Author

sima-zhu commented Jun 2, 2022

@RickWinter
Copy link
Member

RickWinter commented Jul 6, 2022

@sima-zhu Can you complete this PR and enable the process? If this is no longer applicable work, the PR should be closed.

ping: @sima-zhu

@sima-zhu
Copy link
Contributor Author

Pre-requisite:
#3837

@RickWinter I will enable the PR validation once the errors get cleanup. :)

@ghost ghost added the no-recent-activity There has been no recent activity on this issue. label Sep 23, 2022
@ghost
Copy link

ghost commented Sep 23, 2022

Hi @sima-zhu. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@ghost ghost closed this Sep 30, 2022
@ghost
Copy link

ghost commented Sep 30, 2022

Hi @sima-zhu. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-recent-activity There has been no recent activity on this issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants