Fixed Live Tests for Attestation SDK.

sdk/attestation/azure-security-attestation/README.md

@@ -397,3 +397,4 @@ Azure SDK for C++ is licensed under the [MIT](https://github.com/Azure/azure-sdk
 [cloud_shell_bash]: https://shell.azure.com/bash
 
 ![Impressions](https://azure-sdk-impressions.azurewebsites.net/api/impressions/azure-sdk-for-cpp%2Fsdk%2Fattestation%2Fazure-security-attestation%2FREADME.png)
+

sdk/attestation/azure-security-attestation/src/private/attestation_client_private.hpp

@@ -425,6 +425,9 @@ namespace Azure { namespace Security { namespace Attestation { namespace _detail
       ValidateTokenIssuer(validationOptions);
     }
 
-    operator Models::AttestationToken<T>&&() { return std::move(m_token); }
+    /**
+     * @brief Convert the internal attestation token to a public AttestationToken object.
+     */
+    operator Models::AttestationToken<T>&() { return m_token; }
   };
 }}}} // namespace Azure::Security::Attestation::_detail

sdk/attestation/azure-security-attestation/test/ut/administration_test.cpp

@@ -25,7 +25,7 @@ namespace Azure { namespace Security { namespace Attestation { namespace Test {
     // Create
     virtual void SetUp() override
     {
-      Azure::Core::Test::TestBase::SetUpTestBase(AZURE_TEST_RECORDING_DIR);
+      Azure::Core::Test::TestBase::SetUpTestBase("ATTESTATION", AZURE_TEST_RECORDING_DIR);
 
       std::string const mode(std::get<0>(GetParam()));
       if (mode == "Shared")

sdk/attestation/azure-security-attestation/test/ut/attestation_test.cpp

@@ -22,7 +22,7 @@ namespace Azure { namespace Security { namespace Attestation { namespace Test {
     // Create
     virtual void SetUp() override
     {
-      Azure::Core::Test::TestBase::SetUpTestBase(AZURE_TEST_RECORDING_DIR);
+      Azure::Core::Test::TestBase::SetUpTestBase("ATTESTATION", AZURE_TEST_RECORDING_DIR);
 
       std::string mode(GetParam());
       if (mode == "Shared")

sdk/core/azure-core-test/inc/azure/core/test/test_base.hpp

@@ -17,6 +17,7 @@
 #include "azure/core/test/network_models.hpp"
 #include "azure/core/test/test_context_manager.hpp"
 
+#include <algorithm>
 #include <chrono>
 #include <memory>
 #include <regex>
@@ -45,6 +46,7 @@ namespace Azure { namespace Core { namespace Test {
      *
      */
     bool m_wasSkipped = false;
+    std::string m_serviceName{};
 
     void PrepareOptions(Azure::Core::_internal::ClientOptions& options)
     {
@@ -244,10 +246,26 @@ namespace Azure { namespace Core { namespace Test {
     }
 
     // Util for tests getting env vars
-    std::string GetEnv(const std::string& name)
+    std::string GetEnv(std::string const& name)
     {
-      const auto ret = Azure::Core::_internal::Environment::GetVariable(name.c_str());
-
+#if !defined(NDEBUG)
+      // The azure CI pipeline uppercases all EnvVar values from ci.yml files.
+      // That means that any mixed case strings will not be found when run from the CI
+      // pipeline.
+      //
+      // Check to ensure that the filename is upper case
+      {
+        std::string ucName = name;
+        std::transform(ucName.begin(), ucName.end(), ucName.begin(), [](char const& ch) {
+          return static_cast<char>(std::toupper(ch));
+        });
+        if (ucName != name)
+        {
+          throw std::runtime_error("All Azure SDK environment variables must be all upper case.");
+        }
+      }
+#endif
+      auto ret = Azure::Core::_internal::Environment::GetVariable(name.c_str());
       if (ret.empty())
       {
         throw std::runtime_error("Missing required environment variable: " + name);
@@ -262,8 +280,11 @@ namespace Azure { namespace Core { namespace Test {
      * @brief Run before each test.
      *
      */
-    void SetUpTestBase(std::string const& baseRecordingPath)
+    void SetUpTestBase(std::string const& serviceName, std::string const& baseRecordingPath)
     {
+
+      m_serviceName = serviceName;
+
       // Init interceptor from PlayBackRecorder
       std::string recordingPath(baseRecordingPath);
       recordingPath.append("/recordings");
@@ -276,6 +297,24 @@ namespace Azure { namespace Core { namespace Test {
           Sanitize(testNameInfo->test_suite_name()), Sanitize(testNameInfo->name()));
       m_testContext.RecordingPath = recordingPath;
       m_interceptor = std::make_unique<Azure::Core::Test::InterceptorManager>(m_testContext);
+
+      if (!m_testContext.IsPlaybackMode())
+      {
+        auto SetBuiltinEnvironment
+            = [](std::string const& serviceName, std::string const& targetVariable) {
+                std::string targetValue = Azure::Core::_internal::Environment::GetVariable(
+                    (serviceName + targetVariable).c_str());
+                if (!targetValue.empty())
+                {
+                  Azure::Core::_internal::Environment::SetVariable(
+                      ("AZURE" + targetVariable).c_str(), targetValue.c_str());
+                }
+              };
+        ;
+        SetBuiltinEnvironment(serviceName, "_TENANT_ID");
+        SetBuiltinEnvironment(serviceName, "_CLIENT_ID");
+        SetBuiltinEnvironment(serviceName, "_CLIENT_SECRET");
+      }
     }
 
     /**

sdk/core/azure-core/src/http/winhttp/win_http_transport.cpp

@@ -303,6 +303,9 @@ void WinHttpTransport::CreateRequestHandle(std::unique_ptr<_detail::HandleManage
 {
   const std::string& path = handleManager->m_request.GetUrl().GetRelativeUrl();
   HttpMethod requestMethod = handleManager->m_request.GetMethod();
+  bool requestSecureHttp(
+      !Azure::Core::_internal::StringExtensions::LocaleInvariantCaseInsensitiveEqual(
+          handleManager->m_request.GetUrl().GetScheme(), HttpScheme));
 
   // Create an HTTP request handle.
   handleManager->m_requestHandle = WinHttpOpenRequest(
@@ -314,10 +317,7 @@ void WinHttpTransport::CreateRequestHandle(std::unique_ptr<_detail::HandleManage
       NULL, // Use HTTP/1.1
       WINHTTP_NO_REFERER,
       WINHTTP_DEFAULT_ACCEPT_TYPES, // No media types are accepted by the client
-      Azure::Core::_internal::StringExtensions::LocaleInvariantCaseInsensitiveEqual(
-          handleManager->m_request.GetUrl().GetScheme(), HttpScheme)
-          ? 0
-          : WINHTTP_FLAG_SECURE); // Uses secure transaction semantics (SSL/TLS)
+      requestSecureHttp ? WINHTTP_FLAG_SECURE : 0); // Uses secure transaction semantics (SSL/TLS)
 
   if (!handleManager->m_requestHandle)
   {
@@ -330,6 +330,23 @@ void WinHttpTransport::CreateRequestHandle(std::unique_ptr<_detail::HandleManage
     // ERROR_NOT_ENOUGH_MEMORY
     GetErrorAndThrow("Error while getting a request handle.");
   }
+
+  if (requestSecureHttp)
+  {
+    // If the service requests TLS client certificates, we want to let the WinHTTP APIs know that
+    // it's ok to initiate the request without a client certificate.
+    //
+    // Note: If/When TLS client certificate support is added to the pipeline, this line may need to
+    // be revisited.
+    if (!WinHttpSetOption(
+            handleManager->m_requestHandle,
+            WINHTTP_OPTION_CLIENT_CERT_CONTEXT,
+            WINHTTP_NO_CLIENT_CERT_CONTEXT,
+            0))
+    {
+      GetErrorAndThrow("Error while setting client cert context to ignore..");
+    }
+  }
 }
 
 // For PUT/POST requests, send additional data using WinHttpWriteData.

sdk/identity/azure-identity/test/ut/token_credential_test.cpp

@@ -45,7 +45,7 @@ namespace Azure { namespace Identity { namespace Test {
     // Runs before every test.
     virtual void SetUp() override
     {
-      Azure::Core::Test::TestBase::SetUpTestBase(AZURE_TEST_RECORDING_DIR);
+      Azure::Core::Test::TestBase::SetUpTestBase("IDENTITY", AZURE_TEST_RECORDING_DIR);
     }
   };
 }}} // namespace Azure::Identity::Test

sdk/keyvault/azure-security-keyvault-certificates/test/ut/certificate_client_base_test.hpp

@@ -65,7 +65,7 @@ namespace Azure {
     // Runs before every test.
     virtual void SetUp() override
     {
-      Azure::Core::Test::TestBase::SetUpTestBase(AZURE_TEST_RECORDING_DIR);
+      Azure::Core::Test::TestBase::SetUpTestBase("KEYVAULT", AZURE_TEST_RECORDING_DIR);
       m_keyVaultUrl = GetEnv("AZURE_KEYVAULT_URL");
 
       // Options and credential for the client

sdk/keyvault/azure-security-keyvault-keys/test/ut/key_client_base_test.hpp

@@ -54,7 +54,7 @@ namespace Azure { namespace Security { namespace KeyVault { namespace Keys { nam
     // Create
     virtual void SetUp() override
     {
-      Azure::Core::Test::TestBase::SetUpTestBase(AZURE_TEST_RECORDING_DIR);
+      Azure::Core::Test::TestBase::SetUpTestBase("KEYVAULT", AZURE_TEST_RECORDING_DIR);
       m_keyVaultUrl = GetEnv("AZURE_KEYVAULT_URL");
       m_keyVaultHsmUrl = GetEnv("AZURE_KEYVAULT_HSM_URL");
 

sdk/keyvault/azure-security-keyvault-secrets/test/ut/secret_client_base_test.hpp

@@ -41,7 +41,7 @@ namespace Azure { namespace Security { namespace KeyVault { namespace Secrets {
     // Create
     void InitializeClient()
     {
-      Azure::Core::Test::TestBase::SetUpTestBase(AZURE_TEST_RECORDING_DIR);
+      Azure::Core::Test::TestBase::SetUpTestBase("KEYVAULT", AZURE_TEST_RECORDING_DIR);
       m_keyVaultUrl = GetEnv("AZURE_KEYVAULT_URL");
 
       // Options and credential for the client

sdk/storage/azure-storage-blobs/test/ut/block_blob_client_test.cpp

@@ -701,7 +701,7 @@ namespace Azure { namespace Storage { namespace Test {
 
   TEST_P(DownloadBlockBlob, downloadToBuffer)
   {
-    auto const p = GetParam();
+    BlobConcurrentDownloadParameter const& p(GetParam());
     auto const testName(GetTestName(true));
     auto client = GetBlockBlobClient(testName);
     UploadBlockBlob(8_MB);
@@ -773,7 +773,7 @@ namespace Azure { namespace Storage { namespace Test {
 
   TEST_P(DownloadBlockBlob, downloadToFile)
   {
-    auto const p = GetParam();
+    BlobConcurrentDownloadParameter const& p(GetParam());
     auto const testName(GetTestName(true));
     auto client = GetBlockBlobClient(testName);
     UploadBlockBlob(8_MB);
@@ -1191,7 +1191,7 @@ namespace Azure { namespace Storage { namespace Test {
     auto const testName(GetTestName());
     auto blockBlobClient = GetBlockBlobClient(testName);
     SetOptions();
-    auto const p = GetParam();
+    UploadBlockBlob::ParamType const& p(GetParam());
     auto const blobSize = p.Size;
     std::vector<uint8_t> blobContent(static_cast<size_t>(8_MB), 'x');
 
@@ -1227,7 +1227,7 @@ namespace Azure { namespace Storage { namespace Test {
     auto const testName(GetTestName());
     auto blockBlobClient = GetBlockBlobClient(testName);
     SetOptions();
-    auto const p = GetParam();
+    UploadBlockBlob::ParamType const& p(GetParam());
     auto const blobSize = p.Size;
     std::vector<uint8_t> blobContent(static_cast<size_t>(8_MB), 'x');
 

sdk/storage/azure-storage-common/test/ut/test_base.hpp

@@ -132,7 +132,7 @@ namespace Azure { namespace Storage {
 
       virtual void SetUp() override
       {
-        Azure::Core::Test::TestBase::SetUpTestBase(AZURE_TEST_RECORDING_DIR);
+        Azure::Core::Test::TestBase::SetUpTestBase("STORAGE", AZURE_TEST_RECORDING_DIR);
       }
 
     public:

sdk/storage/azure-storage-files-datalake/test/ut/datalake_file_client_test.cpp

@@ -429,7 +429,7 @@ namespace Azure { namespace Storage { namespace Test {
 
   TEST_P(UploadFile, fromBuffer)
   {
-    auto const p = GetParam();
+    UploadFile::ParamType const& p(GetParam());
     std::vector<uint8_t> fileContent(static_cast<size_t>(8_MB), 'x');
     auto fileClient = m_fileSystemClient->GetFileClient(GetTestNameLowerCase());
 
@@ -461,7 +461,7 @@ namespace Azure { namespace Storage { namespace Test {
 
   TEST_P(UploadFile, fromFile)
   {
-    auto const p = GetParam();
+    UploadFile::ParamType const& p(GetParam());
     std::vector<uint8_t> fileContent(static_cast<size_t>(8_MB), 'x');
     auto fileClient = m_fileSystemClient->GetFileClient(GetTestNameLowerCase());
 

sdk/storage/azure-storage-files-shares/test/ut/share_file_client_test.cpp

@@ -395,7 +395,7 @@ namespace Azure { namespace Storage { namespace Test {
 
   TEST_P(UploadShare, fromBuffer)
   {
-    auto const p = GetParam();
+    UploadShare::ParamType const& p(GetParam());
     auto fileClient = m_fileShareDirectoryClient->GetFileClient(m_testName);
     std::vector<uint8_t> fileContent(static_cast<size_t>(p.FileSize), 'x');
 
@@ -418,7 +418,7 @@ namespace Azure { namespace Storage { namespace Test {
   TEST_P(UploadShare, fromFile)
   {
 
-    auto const p = GetParam();
+    UploadShare::ParamType const& p(GetParam());
     auto fileClient = m_fileShareDirectoryClient->GetFileClient(m_testName);
     std::vector<uint8_t> fileContent = std::vector<uint8_t>(static_cast<size_t>(p.FileSize), 'x');