Skip to content

Conversation

@vhvb1989
Copy link
Member

@vhvb1989 vhvb1989 commented Jul 2, 2021

Pull Request Checklist

Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:

See the detailed list in the contributing guide.

  • C++ Guidelines
  • Doxygen docs
  • Unit tests
  • No unwanted commits/changes
  • Descriptive title/description
    • PR is single purpose
    • Related issue listed
  • Comments in source
  • No typos
  • Update changelog
  • Not work-in-progress
  • External references or docs updated
  • Self review of PR done
  • Any breaking changes?


Thank you to our developer community members who helped to make Azure Core better with their contributions to this release:

- Jørgen Lind _([GitHub](https://github.com/jorgen))_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unintended change?

Copy link
Member

@danieljurek danieljurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's confirm the release behavior before merging.

Copy link
Member

@antkmsft antkmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you making the same update for identity?

@antkmsft
Copy link
Member

antkmsft commented Jul 2, 2021

@vhvb1989, please also update Identity the same way and release it, but don't push to vcpkg.

@vhvb1989 vhvb1989 requested a review from schaabs as a code owner July 2, 2021 17:58
@vhvb1989
Copy link
Member Author

vhvb1989 commented Jul 2, 2021

/check-enforcer override

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants