Remove value policy from core #1917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vhvb1989
requested review from
RickWinter,
ahsonkhan and
antkmsft
as code owners
vhvb1989
added
Azure.Core
Client
ahsonkhan
reviewed
Mar 16, 2021
Comment on lines
-430
to
-446
| namespace _internal { | ||
| /** | ||
| * @brief #Azure::Core::Http::Policies::_internal::ValuePolicy options. | ||
| */ | ||
| struct ValueOptions | ||
| { | ||
| CaseInsensitiveMap HeaderValues; | ||
| std::map<std::string, std::string> QueryValues; | ||
| }; | ||
|
|
||
| /** | ||
| * @brief Value policy. | ||
| * | ||
| * @details Applies key-value pair values to each HTTP request (either HTTP headers or query | ||
| * parameters). | ||
| */ | ||
| class ValuePolicy : public HttpPolicy { |
Contributor
There was a problem hiding this comment.
FYI, this is the type of change we wouldn't (easily) be able to make post-GA. Even if we no longer have any users within the repo, if we GA'd a package that used it at some point, we'd have to keep such internal types around.
ahsonkhan
approved these changes
Mar 16, 2021
Contributor
ahsonkhan
left a comment
ahsonkhan
left a comment
There was a problem hiding this comment.
looks good. consider holding off on merging until tomorrow.
Contributor
|
Looks similar to #1889 |
Member
|
Don't merge breaking changes until storage release is done. |
RickWinter
added
feature-request
antkmsft
approved these changes
Mar 18, 2021
…ve-value-policy-from-core
azure-sdk
pushed a commit
that referenced
this pull request
Aug 18, 2021
azure-sdk
pushed a commit
that referenced
this pull request
Aug 18, 2021
azure-sdk
added a commit
that referenced
this pull request
Aug 18, 2021
* Attempt to purge all vaults, managed HSMs Reverts #1910. Vaults and managed HSMs are automatically purged on their purge date. The point was to purge them daily to preserve capacity. The default purge date is +90 days. * Add timeout and more logging * Pass required -Resource * Fix log message * Ensure the $Resource is correctly captured Added comment to new code explaining why, since ScriptBlock.GetNewClosure() is not working as expected. * Add -ErrorAction to Receive-Job Worked without terminating when run locally, but failed on the first error in the AzDO agent. * Use $using:r instead of creating ScriptBlock More idiomatic for passing ScriptBlocks to jobs. * Resolve PR feedback * Change default DeleteAfterHours to 120 Resolves #1917 * Use the Az cmdlets built-in -AsJob Co-authored-by: Heath Stewart <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #1767
No changelog because the policy was Internal only