Skip to content

add empty section for compile options #1741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danewalton-msft merged 7 commits into from
May 27, 2021
Merged

add empty section for compile options #1741

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1691087
add empty section for compile options
danewalton-msft May 6, 2021
98ee45e
Merge branch 'master' into dawalton/compilerwarning
danewalton-msft May 6, 2021
97a8e28
update compiler id
danewalton-msft May 6, 2021
734724a
Merge branch 'master' into dawalton/compilerwarning
danewalton-msft May 10, 2021
4705dd7
Merge branch 'master' into dawalton/compilerwarning
danewalton-msft May 24, 2021
94dcf81
Merge branch 'master' into dawalton/compilerwarning
danewalton-msft May 27, 2021
fd725ea
Update eng/cmake/global_compile_options.txt
danewalton-msft May 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion eng/cmake/global_compile_options.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,12 @@ elseif(CMAKE_C_COMPILER_ID MATCHES "Clang")
endif()

add_compile_options(-Xclang -Wall -Wextra -pedantic ${WARNINGS_AS_ERRORS_FLAG} -Wdocumentation -Wdocumentation-unknown-command -fcomment-block-commands=retval -Wcast-qual -Wunused -Wuninitialized -Wmissing-declarations -Wconversion -Wpointer-arith -Wshadow -Wfloat-equal)
else()
elseif(CMAKE_C_COMPILER_ID MATCHES "GCC")
if(WARNINGS_AS_ERRORS)
set(WARNINGS_AS_ERRORS_FLAG "-Werror")
endif()

add_compile_options(-Wall -Wextra -pedantic ${WARNINGS_AS_ERRORS_FLAG} -Wcast-qual -Wunused -Wuninitialized -Wmissing-declarations -Wconversion -Wpointer-arith -Wshadow -Wlogical-op -Wfloat-equal)
else()
message(WARNING "Using an unsupported compiler. Stricter compiler flags are not turned on.")
endif()