Skip to content

Conversation

@ahsonkhan
Copy link
Contributor

No description provided.

@ahsonkhan ahsonkhan added this to the [2020] December milestone Nov 11, 2020
@ahsonkhan ahsonkhan requested a review from weshaggard November 11, 2020 22:59
@ahsonkhan ahsonkhan self-assigned this Nov 11, 2020
@ahsonkhan ahsonkhan added the EngSys This issue is impacting the engineering system. label Nov 11, 2020
@ghost
Copy link

ghost commented Nov 14, 2020

Hello @ahsonkhan!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 412a523 into master Nov 14, 2020
@ghost ghost deleted the ahsonkhan-patch-3 branch November 14, 2020 01:45
danewalton-msft added a commit that referenced this pull request Nov 16, 2020
* Make sure we always log in as app or provisioner (#1480)

This also adds previously-required parameters back into
@PSBoundParameters to pass down to pre- and post-scripts.

Co-authored-by: Heath Stewart <[email protected]>

* update changelog for beta 2 (#1484)

* Sync eng/common directory with azure-sdk-tools for PR 1163 (#1483)

* Update subscription configuration schema to include new parameters

* Support platform specific arm template parameters and legacy hashtable format

* Update arm template parameter comment to include top level key

* Restore AdditionalParameters. Merge ArmTemplateParameters from stringified hash literal

* Handle duplicate keys more explicitly for arm and env vars

* Regenerate New-TestResources.ps1 markdown

* revert variable name to environmentVariables to fix post-scripts

* Handle empty arm template parameters better

* Remove arm template parameter merge logic from deploy template

* Add merge hashes function to New-TestResources.ps1

* Add merge hashes function to New-TestResources.ps1

* Add env variable overwrite warning. Use ContainsKey checks

* Temporarily manually fix invalid generated markdown links

Co-authored-by: Ben Broderick Phillips <[email protected]>

* Sync eng/common directory with azure-sdk-tools for PR 1178 (#1487)

* Refactor eng/common/README.md

* Add doc directory

Co-authored-by: Chidozie Ononiwu <[email protected]>

* Fix broken eng/common doc link (#1489)

Co-authored-by: Chidozie Ononiwu <[email protected]>

* Explicitly ignore return of _az_span_token on c2d parsing (#1482) (#1490)

* add latest static analyzer fix to changelog (#1491)

* Sync eng/common directory with azure-sdk-tools for PR 1188 (#1502)

* Add debug flag to arm deployment command

* Only set debug preference when $CI is true

Co-authored-by: Ben Broderick Phillips <[email protected]>

* Remove invalid characters in basename sourced from username (#1503)

Co-authored-by: Ben Broderick Phillips <[email protected]>

* Sync eng/common directory with azure-sdk-tools for PR 1170 (#1481)

* Added the preprocess scripts.

* string array to string

Co-authored-by: Sima Zhu <[email protected]>

* Reorganization of samples readme (#1505)

* Completion of Sample Readme update (#1508)

* Add Invoke-DevOpsAPI.ps1, Add functions for Canceling and Listing Builds (#1474)

Co-authored-by: Chidozie Ononiwu <[email protected]>

* Change live test resource DeleteAfterHours tag to 8 hours (#1509)

Co-authored-by: Ben Broderick Phillips <[email protected]>

* adding notes about security on readme file (#1498)

* adding notes about security on readme file

* Update sdk/samples/iot/docs/how_to_iot_hub_esp8266_nodemcu.md

Co-authored-by: Mollie Munoz <[email protected]>

* Update sdk/samples/iot/docs/how_to_iot_hub_esp8266_nodemcu.md

Co-authored-by: Ahson Khan <[email protected]>

* Update sdk/samples/iot/docs/how_to_iot_hub_esp8266_nodemcu.md

Co-authored-by: Ahson Khan <[email protected]>

* Update sdk/samples/iot/docs/how_to_iot_hub_esp8266_nodemcu.md

Co-authored-by: Mollie Munoz <[email protected]>

* Update sdk/samples/iot/docs/how_to_iot_hub_esp8266_nodemcu.md

Co-authored-by: Ahson Khan <[email protected]>

* Update sdk/samples/iot/docs/how_to_iot_hub_esp8266_nodemcu.md

Co-authored-by: Mollie Munoz <[email protected]>

* Update how_to_iot_hub_esp8266_nodemcu.md

* Update sdk/samples/iot/docs/how_to_iot_hub_esp8266_nodemcu.md

Co-authored-by: Eric Wolz <[email protected]>

* Update sdk/samples/iot/docs/how_to_iot_hub_esp8266_nodemcu.md

Co-authored-by: Eric Wolz <[email protected]>

* Update sdk/samples/iot/docs/how_to_iot_hub_esp8266_nodemcu.md

Co-authored-by: Eric Wolz <[email protected]>

Co-authored-by: Mollie Munoz <[email protected]>
Co-authored-by: Ahson Khan <[email protected]>
Co-authored-by: Eric Wolz <[email protected]>

* Sync eng/common directory with azure-sdk-tools for PR 1202 (#1510)

* Add debugging link on resource deployment failures to log output

* Update aka link for live test help docs. Use here string and empty throw.

Co-authored-by: Ben Broderick Phillips <[email protected]>

* Sync eng/common directory with azure-sdk-tools for PR 1153 (#1513)

* Improve Update-ChangeLog Logic

* Updates to ChangeLog-Operations.ps1, copy-docs-to-blobstorage.ps1, Invoke-GitHubAPI.ps1 and Package-Properties.ps1

* More changeLog Logic Improvements

* Update date parsing

Co-authored-by: Chidozie Ononiwu <[email protected]>

* Revert "Places where we have const* arguments in source, optionally mark the value as const as well. (#1261)" (#1517)

This reverts commit 5723678.

* Update AddAzureSDKforC.cmake to reference the latest tagged release of the SDK (#1495)

* Update AddAzureSDKforC.cmake to reference the latest release of the SDK

* Remove pnp from the tag being referenced.

* Incrementing master CL and version to be above the next release from the feature branch (#1506)

* Update LanguageSetting.ps1 (#1518)

Co-authored-by: Azure SDK Bot <[email protected]>
Co-authored-by: Heath Stewart <[email protected]>
Co-authored-by: Ben Broderick Phillips <[email protected]>
Co-authored-by: Chidozie Ononiwu <[email protected]>
Co-authored-by: ewertons <[email protected]>
Co-authored-by: Sima Zhu <[email protected]>
Co-authored-by: Mollie Munoz <[email protected]>
Co-authored-by: Wellington Duraes <[email protected]>
Co-authored-by: Ahson Khan <[email protected]>
Co-authored-by: Eric Wolz <[email protected]>
Co-authored-by: Chidozie Ononiwu <[email protected]>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants