Changed 'nokogiri' back to runtime dependency with version >= 1.6.#43
Changed 'nokogiri' back to runtime dependency with version >= 1.6.#43vishrutshah merged 1 commit intoAzure:masterfrom katmsft:master
Conversation
|
@katmsft, |
vishrutshah
left a comment
vishrutshah
left a comment
There was a problem hiding this comment.
Although change LGTM!
I tested with this branch in the CI and it only failed for Ruby version 2.2.0 only but the reason seems something different. Could you please have a look.
Thanks!
| s.homepage = 'https://github.com/Azure/azure-ruby-asm-core' | ||
| s.license = 'Apache License, Version 2.0' | ||
| s.files = `git ls-files`.split("\n").reject { |f| f.start_with?("test/unit") } | ||
| s.extensions = 'ext/mkrf_conf.rb' |
There was a problem hiding this comment.
Should we delete the ext/mkrf_conf.rb file as well?
There was a problem hiding this comment.
You are absolutely right. Now that we rely on our guidance in Readme.md for user to install correct version of Nokogiri via Rubygems, and resolved Bundler version issue, we can remove that. I have updated the PR for the purpose.
| s.add_development_dependency('rake', '~> 10.0') | ||
| s.add_development_dependency('timecop', '~> 0.7') | ||
| s.add_development_dependency('bundler', '~> 1.11') | ||
| if RUBY_VERSION < "2.1.0" |
There was a problem hiding this comment.
If I understand correctly this was working before in correctly installing the nokogiri version. Wasn't it? or Is it still being picked up from ext/mkrf_conf.rb file?
There was a problem hiding this comment.
No it is no longer picked up from the file. We now updated the Readme.md so that user can resolve the issue manually. This is a limitation caused by Nokogiri and we are not able to provide any solution or workaround for the issue as long as Nokogiri is one of our dependency. It is a common case for projects that depends on it.
…ed documentation to resolve dependency issue to Readme for users with Ruby version lower than 2.2.0.
|
Fail with Ruby version 2.2.0 is a known issue reported in #5341 in bundler’s repo. The issue was fixed in bundler 1.14.1, and won’t happen for 1.14.0 if ruby version is newer than 2.2.4. |
vishrutshah
left a comment
vishrutshah
left a comment
There was a problem hiding this comment.
Thanks a lot @katmsft for the PR and making the fix.
3 participants
This can resolve the issue where bundler failed to recognize Nokogiri as a installed dependency. However, this will cause customers who is currently using ruby version 1.9.3~2.2.0 to not be able to install this gem, unless a compatible version of Nokogiri is installed before azure-asm-core.