set readonly for id, name, type.#9948
Merged
akning-ms merged 2 commits intoAzure:masterfrom Jul 14, 2020
Merged
Conversation
|
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation - Release
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
azure-sdk-for-go - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-java - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net - Release
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Contributor
|
Can one of the admins verify this patch? |
keerthiadu
pushed a commit
to keerthiadu/azure-rest-api-specs
that referenced
this pull request
Jun 24, 2020
sync changes from Azure#9948
|
Azure Pipelines successfully started running 1 pipeline(s). |
keerthiadu
pushed a commit
to keerthiadu/azure-rest-api-specs
that referenced
this pull request
Jun 25, 2020
ArcturusZhang
approved these changes
Jun 28, 2020
Member
|
Hi @RichardLi1437 I wonder if it is possible to make some common types of the resources in the ml RP, or just using predefined resource models here? |
ArcturusZhang
pushed a commit
that referenced
this pull request
Jul 1, 2020
* add new preview version * add GET services and example * update description * update description * update tag * add put on services * remove produces and consumes * update examples/description * update examples, use detailed service response * add path for get by service id * add example for getservicebyid * add example for createService * add example for delete service * use full resource uri * add 2020-05-01 to readme * fix modelvalidation checks * add words to cspell ignore list * fix prettier issues * fix model validation * fix lint errors * include newly added templates and exmaples from 2020-04-01-preview * remove UNREFERENCED_JSON_FILE * fix lint and avaocado errors * update description in examples * sync changes from previous preview version #9649 * fix Potential new SDK errors * mark properties on paginated list response as readonly * sync changes from preview/2020-04-01 #9703 * rename operationId * remove createdby * remove createdtime and modifiedtime. Will populate system metadata instead once RP starts populating it. * use 201 instead of 202 on put /services * Revert "remove createdtime and modifiedtime. Will populate system metadata" This reverts commit 8daee90fcdf6d0c96f7802180c8a7d7860c46296. * use servicename parameter instead of id * add apiversionparameter * move PUT from /services to /services/{serivceName} * wrap machine learning service object inside arm resource envelope * fix prettierchecks * set modelAsString to true * dont have to populate operationId * update description of the location * add required fields * use directref instead of allof for containerresourcerequirements * add long running operation on PUT /services/{name} * delete on service is not a long running operation, remove 202 * remove createdtime and modifiedtime. Will populate system metadata instead once RP starts populating it. mark some properties as readonly * update description for ssl cert and ssl key * add description for conda dependencies * add example for service update * set x-ms-secret on authtoken, username and password * fix prettier errors * remove unused file * set readonly for id, name, type. #9948 sync changes from #9948 * on response dont populate username, password and authtoken * set x-ms-azure-resource, sync changes from #9948 * fix lint errors Co-authored-by: Keerthi Adusumilli <keadusum@microsoft.com>
ArcturusZhang
added
the
Approved-BreakingChange
Member
|
Hi @akning-ms could you please help us merge this PR with breaking changes? This is a preview swagger, therefore breaking changes should be allowed |
Contributor
Yes, agree, can you address this comment? @RichardLi1437 |
fullmetalcloud
pushed a commit
to fullmetalcloud/azure-rest-api-specs
that referenced
this pull request
Jul 15, 2020
* set readonly for id, name, type. * set x-ms-azure-resource Co-authored-by: Richard Li <richli@microsoft.com>
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
…#9592) * add new preview version * add GET services and example * update description * update description * update tag * add put on services * remove produces and consumes * update examples/description * update examples, use detailed service response * add path for get by service id * add example for getservicebyid * add example for createService * add example for delete service * use full resource uri * add 2020-05-01 to readme * fix modelvalidation checks * add words to cspell ignore list * fix prettier issues * fix model validation * fix lint errors * include newly added templates and exmaples from 2020-04-01-preview * remove UNREFERENCED_JSON_FILE * fix lint and avaocado errors * update description in examples * sync changes from previous preview version Azure#9649 * fix Potential new SDK errors * mark properties on paginated list response as readonly * sync changes from preview/2020-04-01 Azure#9703 * rename operationId * remove createdby * remove createdtime and modifiedtime. Will populate system metadata instead once RP starts populating it. * use 201 instead of 202 on put /services * Revert "remove createdtime and modifiedtime. Will populate system metadata" This reverts commit 8daee90fcdf6d0c96f7802180c8a7d7860c46296. * use servicename parameter instead of id * add apiversionparameter * move PUT from /services to /services/{serivceName} * wrap machine learning service object inside arm resource envelope * fix prettierchecks * set modelAsString to true * dont have to populate operationId * update description of the location * add required fields * use directref instead of allof for containerresourcerequirements * add long running operation on PUT /services/{name} * delete on service is not a long running operation, remove 202 * remove createdtime and modifiedtime. Will populate system metadata instead once RP starts populating it. mark some properties as readonly * update description for ssl cert and ssl key * add description for conda dependencies * add example for service update * set x-ms-secret on authtoken, username and password * fix prettier errors * remove unused file * set readonly for id, name, type. Azure#9948 sync changes from Azure#9948 * on response dont populate username, password and authtoken * set x-ms-azure-resource, sync changes from Azure#9948 * fix lint errors Co-authored-by: Keerthi Adusumilli <keadusum@microsoft.com>
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
* set readonly for id, name, type. * set x-ms-azure-resource Co-authored-by: Richard Li <richli@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.