Kusto 2020-06-14 API version#9929
Merged
akning-ms merged 11 commits intoAzure:masterfrom Jul 10, 2020
astauben:master
Merged
Conversation
[Staging] Swagger Validation Report
️✔️ |
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python - Release
|
azure-sdk-for-js - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net - Release
|
Azure CLI Extension Generation - Release
|
azure-sdk-for-java - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
This was referenced Jun 23, 2020
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Contributor
Author
|
@leni-msft identical PR to the one I opened to the private repo |
Contributor
|
Can one of the admins verify this patch? |
openapi-assignment-bot
bot
added
the
WaitForARMFeedback
|
@anthony-c-martin could you please either review the PR or assign some else? |
pilor
suggested changes
Jun 30, 2020
| } | ||
| } | ||
| }, | ||
| "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Kusto/clusters/{clusterName}/databases/{databaseName}/dataConnectionValidationAsync": { |
Contributor
There was a problem hiding this comment.
you shouldn't introduce a new API here. Just start supporting an async response in this api-version and future api-versions for the existing API.
Contributor
Author
There was a problem hiding this comment.
@pilor Thanks for the quick review! I've updated the relevant files.
pilor
added
ARMChangesRequested
and removed
ARMReviewInProgress
WaitForARMFeedback
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pilor
added
ARMSignedOff
pilor
approved these changes
Jul 1, 2020
akning-ms
added
the
Approved-OkToMerge
Contributor
|
Hi @astauben Ping me if you need to merge this PR as you put Do not Merge label |
Contributor
Author
Hi @akning-ms , please merge the PR. Thanks! |
Contributor
Author
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
* adding 2020-06-14 * Update readme.md * Update readme.go.md * Update custom-words.txt * remove dataconnectionvalidationasync * update example * Delete KustoDataConnectionValidationAsync.json * Update kusto.json * prettier-fix for kusto.json * Update custom-words.txt * Update custom-words.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.