BUG FIX: Fixed HopLink properties: context should be a dictionary, uint32 from… #9868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at instead of int32
irrogozh
requested review from
MikhailTryakhov,
anton-evseev and
v-shhatt
as code owners
[Staging] Swagger Validation Report
🔄 |
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
azure-sdk-for-go - Release
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net - Release
|
azure-sdk-for-js - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Contributor
|
Can one of the admins verify this patch? |
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python-track2 - Release
|
This was referenced Jun 17, 2020
openapi-assignment-bot
bot
added
the
WaitForARMFeedback
lirenhe
reviewed
Jun 18, 2020
| "readOnly": true, | ||
| "type": "array", | ||
| "description": "Provides additional context on the issue.", | ||
| "items": { |
Member
There was a problem hiding this comment.
This seems to be a breaking change, could you explain why not use a new API version?
Member
Author
There was a problem hiding this comment.
yes, @lirenhe , it's a bug fix. SDK and CLI experience is broken because of it (type is deserialized incorrectly)
Contributor
There was a problem hiding this comment.
do we still need IssueContext? Can we remove this?
Member
Author
There was a problem hiding this comment.
no, we can't. It is used in another place. It was there before this change
lirenhe
added
the
Reviewed-ChangesRequested
anton-evseev
approved these changes
Jun 18, 2020
lirenhe
approved these changes
Jun 18, 2020
lirenhe
added
Approved-BreakingChange
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
…nt32 from… (Azure#9868) * Fixed HopLink properties: context should be a dictionary, uint32 fromat instead of int32 * removed format for RoundTripTime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…at instead of int32
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.