Skip to content

Comments

Add Microsoft.PolicyInsights/attestations to 2019-10-01#9844

Closed
pilor wants to merge 3 commits intoAzure:masterfrom
pilor:policyAttestations
Closed

Add Microsoft.PolicyInsights/attestations to 2019-10-01#9844
pilor wants to merge 3 commits intoAzure:masterfrom
pilor:policyAttestations

Conversation

@pilor
Copy link
Contributor

@pilor pilor commented Jun 15, 2020

This is a new resource type in Microsoft.PolicyInsights to facilitate manual policies. Manual policies are policies where a user manually sets the compliance state of applicable resources. This attestations resource is how they set the state of a subscription, resource group, or individual resource.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
    • adding/removing APIs.
    • adding/removing properties.
    • adding/removing API-version.
    • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@pilor pilor added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 15, 2020
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 15, 2020

Swagger pipeline restarted successfully, please wait for status update in this comment.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pilor pilor added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jun 15, 2020
@pilor
Copy link
Contributor Author

pilor commented Jun 15, 2020

Temporarily adding DoNotMerge while I follow up on some billing related questions

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 15, 2020

Azure CLI Extension Generation

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 15, 2020

azure-sdk-for-go

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 15, 2020

azure-sdk-for-js

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 55a64ef with merge commit 7dff92c22c99afc8244003c645126e27c67a7015. SDK Automation 13.0.17.20200605.3
  • ️✔️@azure/arm-policyinsights [View full logs]  [Preview SDK Changes]
    Only show 100 items here, please refer to log for details.
    [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
    [npmPack] npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
    [npmPack] npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
    [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/policyInsightsClient.js → ./dist/arm-policyinsights.js...
    [npmPack] created ./dist/arm-policyinsights.js in 589ms
    [npmPack] npm notice 
    [npmPack] npm notice package: @azure/arm-policyinsights@3.2.0
    [npmPack] npm notice === Tarball Contents === 
    [npmPack] npm notice 215.4kB dist/arm-policyinsights.js                         
    [npmPack] npm notice 78.6kB  dist/arm-policyinsights.min.js                     
    [npmPack] npm notice 18.8kB  esm/operations/attestations.js                     
    [npmPack] npm notice 652B    esm/models/attestationsMappers.js                  
    [npmPack] npm notice 345B    esm/models/index.js                                
    [npmPack] npm notice 595B    esm/operations/index.js                            
    [npmPack] npm notice 61.1kB  esm/models/mappers.js                              
    [npmPack] npm notice 1.6kB   esm/operations/operations.js                       
    [npmPack] npm notice 478B    esm/models/operationsMappers.js                    
    [npmPack] npm notice 8.8kB   esm/models/parameters.js                           
    [npmPack] npm notice 18.3kB  esm/operations/policyEvents.js                     
    [npmPack] npm notice 490B    esm/models/policyEventsMappers.js                  
    [npmPack] npm notice 1.9kB   esm/policyInsightsClient.js                        
    [npmPack] npm notice 2.5kB   esm/policyInsightsClientContext.js                 
    [npmPack] npm notice 3.2kB   esm/operations/policyMetadataOperations.js         
    [npmPack] npm notice 517B    esm/models/policyMetadataOperationsMappers.js      
    [npmPack] npm notice 32.2kB  esm/operations/policyStates.js                     
    [npmPack] npm notice 705B    esm/models/policyStatesMappers.js                  
    [npmPack] npm notice 8.7kB   esm/operations/policyTrackedResources.js           
    [npmPack] npm notice 548B    esm/models/policyTrackedResourcesMappers.js        
    [npmPack] npm notice 32.5kB  esm/operations/remediations.js                     
    [npmPack] npm notice 709B    esm/models/remediationsMappers.js                  
    [npmPack] npm notice 994B    rollup.config.js                                   
    [npmPack] npm notice 1.7kB   package.json                                       
    [npmPack] npm notice 457B    tsconfig.json                                      
    [npmPack] npm notice 540.2kB dist/arm-policyinsights.js.map                     
    [npmPack] npm notice 70.0kB  dist/arm-policyinsights.min.js.map                 
    [npmPack] npm notice 6.5kB   esm/operations/attestations.d.ts.map               
    [npmPack] npm notice 10.2kB  esm/operations/attestations.js.map                 
    [npmPack] npm notice 338B    esm/models/attestationsMappers.d.ts.map            
    [npmPack] npm notice 351B    esm/models/attestationsMappers.js.map              
    [npmPack] npm notice 36.6kB  esm/models/index.d.ts.map                          
    [npmPack] npm notice 275B    esm/operations/index.d.ts.map                      
    [npmPack] npm notice 126B    esm/models/index.js.map                            
    [npmPack] npm notice 290B    esm/operations/index.js.map                        
    [npmPack] npm notice 2.4kB   esm/models/mappers.d.ts.map                        
    [npmPack] npm notice 33.1kB  esm/models/mappers.js.map                          
    [npmPack] npm notice 663B    esm/operations/operations.d.ts.map                 
    [npmPack] npm notice 908B    esm/operations/operations.js.map                   
    [npmPack] npm notice 228B    esm/models/operationsMappers.d.ts.map              
    [npmPack] npm notice 241B    esm/models/operationsMappers.js.map                
    [npmPack] npm notice 1.8kB   esm/models/parameters.d.ts.map                     
    [npmPack] npm notice 6.5kB   esm/models/parameters.js.map                       
    [npmPack] npm notice 6.8kB   esm/operations/policyEvents.d.ts.map               
    [npmPack] npm notice 10.6kB  esm/operations/policyEvents.js.map                 
    [npmPack] npm notice 232B    esm/models/policyEventsMappers.d.ts.map            
    [npmPack] npm notice 245B    esm/models/policyEventsMappers.js.map              
    [npmPack] npm notice 836B    esm/policyInsightsClient.d.ts.map                  
    [npmPack] npm notice 1.1kB   esm/policyInsightsClient.js.map                    
    [npmPack] npm notice 475B    esm/policyInsightsClientContext.d.ts.map           
    [npmPack] npm notice 1.3kB   esm/policyInsightsClientContext.js.map             
    [npmPack] npm notice 1.4kB   esm/operations/policyMetadataOperations.d.ts.map   
    [npmPack] npm notice 2.0kB   esm/operations/policyMetadataOperations.js.map     
    [npmPack] npm notice 263B    esm/models/policyMetadataOperationsMappers.d.ts.map
    [npmPack] npm notice 276B    esm/models/policyMetadataOperationsMappers.js.map  
    [npmPack] npm notice 11.7kB  esm/operations/policyStates.d.ts.map               
    [npmPack] npm notice 17.8kB  esm/operations/policyStates.js.map                 
    [npmPack] npm notice 356B    esm/models/policyStatesMappers.d.ts.map            
    [npmPack] npm notice 369B    esm/models/policyStatesMappers.js.map              
    [npmPack] npm notice 3.5kB   esm/operations/policyTrackedResources.d.ts.map     
    [npmPack] npm notice 4.9kB   esm/operations/policyTrackedResources.js.map       
    [npmPack] npm notice 265B    esm/models/policyTrackedResourcesMappers.d.ts.map  
    [npmPack] npm notice 278B    esm/models/policyTrackedResourcesMappers.js.map    
    [npmPack] npm notice 14.5kB  esm/operations/remediations.d.ts.map               
    [npmPack] npm notice 19.4kB  esm/operations/remediations.js.map                 
    [npmPack] npm notice 364B    esm/models/remediationsMappers.d.ts.map            
    [npmPack] npm notice 377B    esm/models/remediationsMappers.js.map              
    [npmPack] npm notice 3.5kB   README.md                                          
    [npmPack] npm notice 17.9kB  esm/operations/attestations.d.ts                   
    [npmPack] npm notice 33.5kB  src/operations/attestations.ts                     
    [npmPack] npm notice 342B    esm/models/attestationsMappers.d.ts                
    [npmPack] npm notice 636B    src/models/attestationsMappers.ts                  
    [npmPack] npm notice 99.6kB  esm/models/index.d.ts                              
    [npmPack] npm notice 279B    esm/operations/index.d.ts                          
    [npmPack] npm notice 94.6kB  src/models/index.ts                                
    [npmPack] npm notice 563B    src/operations/index.ts                            
    [npmPack] npm notice 3.2kB   esm/models/mappers.d.ts                            
    [npmPack] npm notice 47.4kB  src/models/mappers.ts                              
    [npmPack] npm notice 1.1kB   esm/operations/operations.d.ts                     
    [npmPack] npm notice 2.3kB   src/operations/operations.ts                       
    [npmPack] npm notice 168B    esm/models/operationsMappers.d.ts                  
    [npmPack] npm notice 444B    src/models/operationsMappers.ts                    
    [npmPack] npm notice 2.4kB   esm/models/parameters.d.ts                         
    [npmPack] npm notice 8.7kB   src/models/parameters.ts                           
    [npmPack] npm notice 20.6kB  esm/operations/policyEvents.d.ts                   
    [npmPack] npm notice 41.0kB  src/operations/policyEvents.ts                     
    [npmPack] npm notice 180B    esm/models/policyEventsMappers.d.ts                

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 15, 2020

azure-sdk-for-python

failed [Logs] [Expand Details]
  • Generate from 55a64ef with merge commit 7dff92c22c99afc8244003c645126e27c67a7015. SDK Automation 13.0.17.20200605.3
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicyTrackedResourcesQueryResults' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'QueryFailure' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'QueryFailure-error' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'RemediationListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'RemediationDeploymentsListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'RemediationDeployment' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Remediation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'RemediationProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'RemediationFilters' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'RemediationDeploymentSummary' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorDefinition' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'TypedErrorInfo' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicyEventsQueryResults' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'QueryFailure' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'QueryFailure-error' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicyStatesQueryResults' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'SummarizeResults' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Summary' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'SummaryResults' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ComplianceDetail' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicyAssignmentSummary' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicyDefinitionSummary' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicyGroupSummary' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'QueryFailure' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'QueryFailure-error' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationsListResults' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicyMetadata' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicyMetadataSlimProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicyMetadataProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'SlimPolicyMetadata' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicyMetadataCollection' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorDefinition' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'TypedErrorInfo' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AttestationListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Attestation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AttestationProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AttestationEvidence' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorDefinition' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'TypedErrorInfo' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] 
    [AutoRest] ERROR (PreCheck/DuplicateSchema): Duplicate Schema named ErrorResponse -- properties.error.$ref: undefined => "#/components/schemas/schemas:280" 
    [AutoRest] 
    [AutoRest] ERROR (PreCheck/DuplicateSchema): Duplicate Schema named ErrorDefinition -- properties.details.$ref: undefined => "#/components/schemas/schemas:284" 
    [AutoRest] FATAL: Error: 2 errors occured -- cannot continue.
    [AutoRest]   Error: Plugin prechecker reported failure.
    Failed to run autorest.
    Error: /z/node_modules/.bin/autorest --version=3.0.6272 --use=@autorest/python@5.1.0-preview.1 --python --python-mode=update --multiapi --track2 --python-sdks-folder=/z/work/azure-sdk-for-python/sdk /z/work/azure-rest-api-specs/specification/policyinsights/resource-manager/readme.md 
    ERROR (PreCheck/DuplicateSchema): Duplicate Schema named ErrorResponse -- properties.error.$ref: undefined => "#/components/schemas/schemas:280" 
    

    ERROR (PreCheck/DuplicateSchema): Duplicate Schema named ErrorDefinition -- properties.details.$ref: undefined => "#/components/schemas/schemas:284"
    FATAL: Error: 2 errors occured -- cannot continue.
    Error: Plugin prechecker reported failure.
    , {}
    Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 15, 2020

Trenton Generation

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 15, 2020

azure-sdk-for-java

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 55a64ef with merge commit 7dff92c22c99afc8244003c645126e27c67a7015. SDK Automation 13.0.17.20200605.3
  • ⚠️sdk/policyinsights/mgmt-v2018_04_04 [View full logs
    No file is changed.
  • ⚠️sdk/policyinsights/mgmt-v2018_07_01_preview [View full logs
      [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.8:jar (default-cli) on project azure-mgmt-policyinsights: MavenReportException: Error while creating archive: 
      [mvn] [ERROR] Exit code: 1 - /z/work/azure-sdk-for-java/sdk/policyinsights/mgmt-v2018_07_01_preview/src/main/java/com/microsoft/azure/management/policyinsights/v2018_07_01_preview/Remediation.java:94: error: '{' expected
      [mvn] [ERROR]         interface WithMicrosoft.PolicyInsight {
      [mvn] [ERROR]                                ^
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/policyinsights/mgmt-v2018_07_01_preview/src/main/java/com/microsoft/azure/management/policyinsights/v2018_07_01_preview/Remediation.java:100: error: = expected
      [mvn] [ERROR]             WithCreate withExistingMicrosoft.PolicyInsight(String managementGroupId);
      [mvn] [ERROR]                                             ^
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/policyinsights/mgmt-v2018_07_01_preview/src/main/java/com/microsoft/azure/management/policyinsights/v2018_07_01_preview/Remediation.java:100: error:  expected
      [mvn] [ERROR]             WithCreate withExistingMicrosoft.PolicyInsight(String managementGroupId);
      [mvn] [ERROR]                                                           ^
      [mvn] [ERROR] 
      [mvn] [ERROR] Command line was: /usr/lib/jvm/java-8-openjdk-amd64/jre/../bin/javadoc @options @packages
      [mvn] [ERROR] 
      [mvn] [ERROR] Refer to the generated Javadoc files in '/z/work/azure-sdk-for-java/sdk/policyinsights/mgmt-v2018_07_01_preview/target/apidocs' dir.
      [mvn] [ERROR] -> [Help 1]
      [mvn] [ERROR] 
      [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
      [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
      [mvn] [ERROR] 
      [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
      [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
      No file is changed.
    • ⚠️sdk/policyinsights/mgmt-v2019_10_01 [View full logs]  [Preview SDK Changes]
        [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.8:jar (default-cli) on project azure-mgmt-policyinsights: MavenReportException: Error while creating archive: 
        [mvn] [ERROR] Exit code: 1 - /z/work/azure-sdk-for-java/sdk/policyinsights/mgmt-v2019_10_01/src/main/java/com/microsoft/azure/management/policyinsights/v2019_10_01/Remediation.java:99: error: '{' expected
        [mvn] [ERROR]         interface WithMicrosoft.PolicyInsight {
        [mvn] [ERROR]                                ^
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/policyinsights/mgmt-v2019_10_01/src/main/java/com/microsoft/azure/management/policyinsights/v2019_10_01/Remediation.java:105: error: = expected
        [mvn] [ERROR]             WithCreate withExistingMicrosoft.PolicyInsight(String managementGroupId);
        [mvn] [ERROR]                                             ^
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/policyinsights/mgmt-v2019_10_01/src/main/java/com/microsoft/azure/management/policyinsights/v2019_10_01/Remediation.java:105: error:  expected
        [mvn] [ERROR]             WithCreate withExistingMicrosoft.PolicyInsight(String managementGroupId);
        [mvn] [ERROR]                                                           ^
        [mvn] [ERROR] 
        [mvn] [ERROR] Command line was: /usr/lib/jvm/java-8-openjdk-amd64/jre/../bin/javadoc @options @packages
        [mvn] [ERROR] 
        [mvn] [ERROR] Refer to the generated Javadoc files in '/z/work/azure-sdk-for-java/sdk/policyinsights/mgmt-v2019_10_01/target/apidocs' dir.
        [mvn] [ERROR] -> [Help 1]
        [mvn] [ERROR] 
        [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
        [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
        [mvn] [ERROR] 
        [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
        [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Jun 15, 2020

      azure-sdk-for-python-track2

      No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Jun 15, 2020

      azure-sdk-for-net

      failed [Logs] [Expand Details]
      • Generate from 55a64ef with merge commit 7dff92c22c99afc8244003c645126e27c67a7015. SDK Automation 13.0.17.20200605.3
        [AutoRest] realpath(): Permission denied
        [AutoRest] realpath(): Permission denied
        [AutoRest] realpath(): Permission denied
        [AutoRest] realpath(): Permission denied
        [AutoRest] realpath(): Permission denied
        [AutoRest] realpath(): Permission denied
      • Microsoft.Azure.Management.PolicyInsights [View full logs]  [Preview SDK Changes]
          Failed to create the package Microsoft.Azure.Management.PolicyInsights.
          Error: dotnet msbuild build.proj /t:CreateNugetPackage /p:Scope=policyinsights /v:n /p:SkipTests=true , {} 

        @azuresdkci
        Copy link
        Contributor

        Can one of the admins verify this patch?

        @azure-pipelines
        Copy link

        Azure Pipelines successfully started running 1 pipeline(s).

        @pilor
        Copy link
        Contributor Author

        pilor commented Jun 16, 2020

        The SDK failure is due to the changes in this PR that haven't made it to the SDK repo yet: #7909

        Copy link
        Contributor

        @chiragg4u chiragg4u left a comment

        Choose a reason for hiding this comment

        The reason will be displayed to describe this comment to others. Learn more.

        Looks good overall. Few minor comments added.

        @azure-pipelines
        Copy link

        Azure Pipelines successfully started running 1 pipeline(s).

        Copy link
        Contributor

        @chiragg4u chiragg4u left a comment

        Choose a reason for hiding this comment

        The reason will be displayed to describe this comment to others. Learn more.

        Swagger file changes looks good to me, please resolve the SDK generation failures before commiting.

        @azure-pipelines
        Copy link

        Azure Pipelines successfully started running 1 pipeline(s).

        @pilor pilor added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 18, 2020
        @pilor pilor force-pushed the policyAttestations branch from 2f9f7bf to 55a64ef Compare June 18, 2020 21:30
        @azure-pipelines
        Copy link

        Azure Pipelines successfully started running 1 pipeline(s).

        @pilor
        Copy link
        Contributor Author

        pilor commented Jun 18, 2020

        The python autorest validation is failing against what is in master without these changes. It seems to not be picking up the identical definitions correctly for ErrorResponse and ErrorDefinition in the existing specs even though those were passing python validation as recently as ~2 days ago without changes to the specs/readme.

        @pilor
        Copy link
        Contributor Author

        pilor commented Jun 22, 2020

        Closing for now while billing is finalized. Will re-open in the future (hopefully without any changes).

        Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

        Labels

        ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review DoNotMerge <valid label in PR review process> use to hold merge after approval

        Projects

        None yet

        Development

        Successfully merging this pull request may close these issues.

        4 participants