Add Microsoft.PolicyInsights/attestations to 2019-10-01#9844
Add Microsoft.PolicyInsights/attestations to 2019-10-01#9844pilor wants to merge 3 commits intoAzure:masterfrom
Conversation
|
Swagger pipeline restarted successfully, please wait for status update in this comment. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Temporarily adding DoNotMerge while I follow up on some billing related questions |
Azure CLI Extension Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go
|
azure-sdk-for-js
|
azure-sdk-for-python
|
Trenton Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-java
|
azure-sdk-for-python-track2
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net
|
|
Can one of the admins verify this patch? |
9db67b8 to
d9a2741
Compare
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The SDK failure is due to the changes in this PR that haven't made it to the SDK repo yet: #7909 |
chiragg4u
left a comment
There was a problem hiding this comment.
Looks good overall. Few minor comments added.
...crosoft.PolicyInsights/stable/2019-10-01/examples/Attestations_CreateResourceGroupScope.json
Outdated
Show resolved
Hide resolved
...policyinsights/resource-manager/Microsoft.PolicyInsights/stable/2019-10-01/attestations.json
Outdated
Show resolved
Hide resolved
...policyinsights/resource-manager/Microsoft.PolicyInsights/stable/2019-10-01/attestations.json
Outdated
Show resolved
Hide resolved
...yInsights/stable/2019-10-01/examples/Attestations_CreateSubscriptionScope_AllProperties.json
Outdated
Show resolved
Hide resolved
|
Azure Pipelines successfully started running 1 pipeline(s). |
chiragg4u
left a comment
There was a problem hiding this comment.
Swagger file changes looks good to me, please resolve the SDK generation failures before commiting.
|
Azure Pipelines successfully started running 1 pipeline(s). |
2f9f7bf to
55a64ef
Compare
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The python autorest validation is failing against what is in master without these changes. It seems to not be picking up the identical definitions correctly for ErrorResponse and ErrorDefinition in the existing specs even though those were passing python validation as recently as ~2 days ago without changes to the specs/readme. |
|
Closing for now while billing is finalized. Will re-open in the future (hopefully without any changes). |
This is a new resource type in Microsoft.PolicyInsights to facilitate manual policies. Manual policies are policies where a user manually sets the compliance state of applicable resources. This attestations resource is how they set the state of a subscription, resource group, or individual resource.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.