Skip to content
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
{
"parameters": {
"resourceName": "testResource",
"resourceGroupName": "testRP",
"subscriptionId": "91e9f7ac-9c2c-4cd2-af61-1c5b57ec6c51",
"resourceReuest": {
"location": "southcentralus",
"properties": {
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to pass the properties in PUT

Copy link
Member Author

@somu84 somu84 Jun 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have linked a prior PR that has been approved.
This file was added as part of that. Can we please merge that PR to master?

"hostname": "Azure Notebooks"
}
},
"responses": {
"200": {
"body": {
"resourceId": "551f86620f6d4349b928a9024d9b9f51",
"name": "fsda",
"primaryAccessKey": "152aa045c2df4ae7b320739bbff092850423f69444654deca123c526155feae3",
"secondaryAccessKey": "d16fd33d0ff04827b8b65e6491cb8f0bfd074ba26f064479b2e805176435841d",
"hostname": "Azure Notebooks",
"createdAt": "2020-01-31T18:21:27.9889522Z",
"updatedAt": "2020-01-31T18:21:27.9890151Z"
}
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"parameters": {
"resourceName": "testResource",
"resourceGroupName": "testRP",
"subscriptionId": "91e9f7ac-9c2c-4cd2-af61-1c5b57ec6c51"
},
"responses": {
"200": {}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"parameters": {
"resourceName": "testResource",
"resourceGroupName": "testRP",
"subscriptionId": "91e9f7ac-9c2c-4cd2-af61-1c5b57ec6c51"
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the update?

"responses": {
"200": {}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,227 @@
{
"swagger": "2.0",
"info": {
"version": "2019-10-11-preview",
"title": "NotebookResourceManagementClient",
"description": "Azure Notebooks Resource Management Client"
},
"paths": {
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Notebooks/NotebookProxy/{resourceName}": {
"get": {
"tags": [ "NotebookResource" ],
"operationId": "GetNotebookResouce",
"consumes": [],
"produces": [ "application/json" ],
"parameters": [
{
"name": "subscriptionId",
"in": "path",
"required": true,
"type": "string"
},
{
"name": "resourceGroupName",
"in": "path",
"required": true,
"type": "string"
},
{
"name": "resourceName",
"in": "path",
"required": true,
"type": "string"
}
],
"responses": { "200" : { "description": "Success" } }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"description": "Success" [](start = 35, length = 24)

This should return the resource.

},
"put": {
"tags": [ "NotebookResource" ],
"operationId": "CreateOrUpdateNotebookResource",
"consumes": [ "application/json-patch+json", "application/json", "text/json", "application/*+json" ],
"produces": [],
"parameters": [
{
"name": "subscriptionId",
"in": "path",
"required": true,
"type": "string"
},
{
"name": "resourceGroupName",
"in": "path",
"required": true,
"type": "string"
},
{
"name": "resourceName",
"in": "path",
"required": true,
"type": "string"
},
{
"name": "resourceRequest",
"in": "body",
"required": false,
"schema": { "$ref": "#/definitions/NotebookResource" }
}
],
"responses": {
"200": {
"description": "Success"
},
"201": {
"description": "Success"
}
}
},
"delete": {
"tags": [ "NotebookResource" ],
"operationId": "DeleteNotebookResource",
"consumes": [],
"produces": [],
"parameters": [
{
"name": "subscriptionId",
"in": "path",
"required": true,
"type": "string"
},
{
"name": "resourceGroupName",
"in": "path",
"required": true,
"type": "string"
},
{
"name": "resourceName",
"in": "path",
"required": true,
"type": "string"
}
],
"responses": {
"200": {
"description": "Success"
},
"204": {
"description": "Success"
}
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Notebooks/NotebookProxies/{resourceName}/updatePrivateLinkId/{privateLinkId}": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this API supposed to do?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This API is updating the resource by adding a private link Id.

"post": {
"tags": [ "NotebookResource" ],
"operationId": "PostPrivateLinkIdNotebookResource",
"consumes": [ "application/json-patch+json", "application/json", "text/json", "application/*+json" ],
"produces": [ "application/json-patch+json", "application/json", "text/json", "application/*+json" ],
"parameters": [
{
"name": "subscriptionId",
"in": "path",
"required": true,
"type": "string"
},
{
"name": "resourceGroupName",
"in": "path",
"required": true,
"type": "string"
},
{
"name": "resourceName",
"in": "path",
"required": true,
"type": "string"
},
{
"name": "privateLinkId",
"in": "path",
"required": true,
"type": "string"
}
],
"responses": { "200": { "description": "Success" } }
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Notebooks/NotebookProxies/{resourceName}/removePrivateLinkId/{privateLinkId}": {
"post": {
"tags": [ "NotebookResource" ],
"operationId": "RemovePrivateLinkIdNotebookResource",
"consumes": [ "application/json-patch+json", "application/json", "text/json", "application/*+json" ],
"produces": [ "application/json-patch+json", "application/json", "text/json", "application/*+json" ],
"parameters": [
{
"name": "subscriptionId",
"in": "path",
"required": true,
"type": "string"
},
{
"name": "resourceGroupName",
"in": "path",
"required": true,
"type": "string"
},
{
"name": "resourceName",
"in": "path",
"required": true,
"type": "string"
}
],
"responses": { "200": { "description": "Success" }
}
}
},
"definitions": {
"NotebookResource": {
"type": "object",
"properties": {
"location": { "type": "string" },
"properties": { "$ref": "#/definitions/NotebookResourceProperties" },
"hostname": { "type": "string" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this cant be a top level property, it must be moved under "properties" property

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

}
},
"NotebookResourceProperties": {
"type": "object",
"properties": {}
},
"AzureSubscription": {
"type": "object",
"properties": {
"state": {
"format": "int32",
"enum": [ 0, 1, 2, 3, 4 ],
"type": "integer"
},
"registrationDate": {
"format": "date-time",
"type": "string"
},
"properties": { "$ref": "#/definitions/AzureSubscriptionProperties" }
}
},
"AzureSubscriptionProperties": {
"type": "object",
"properties": {
"tenantId": { "type": "string" },
"locationPlacementId": { "type": "string" },
"quotaId": { "type": "string" },
"registeredFeatures": {
"uniqueItems": false,
"type": "array",
"items": { "$ref": "#/definitions/RegisteredFeature" }
}
}
},
"RegisteredFeature": {
"type": "object",
"properties": {
"name": { "type": "string" },
"state": { "type": "string" }
}
}
}
}
}