Skip to content

Conversation

@viv-liu
Copy link
Contributor

@viv-liu viv-liu commented Jun 12, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
    • adding/removing APIs.
    • adding/removing properties.
    • adding/removing API-version.
    • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 12, 2020

[Staging] Swagger Validation Report

BreakingChange: 16 Errors, 0 Warnings [Detail] [Expand] Only 10 items are listed, please refer to log for more details.
Rule Message
1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'Subdomain' removed or renamed?
New: Microsoft.IoTCentral/preview/2019-10-28-preview/iotcentralapps.json#L118:3
Old: Microsoft.IoTCentral/preview/2019-10-28-preview/iotcentralapps.json#L114:3
1021 - AddedAdditionalProperties The new version adds an 'additionalProperties' element.
New: Microsoft.IoTCentral/preview/2019-10-28-preview/iotcentral.json#L2054:13
Old: Microsoft.IoTCentral/preview/2019-10-28-preview/iotcentral.json#L2092:13
1021 - AddedAdditionalProperties The new version adds an 'additionalProperties' element.
New: Microsoft.IoTCentral/preview/2019-10-28-preview/iotcentral.json#L2235:13
Old: Microsoft.IoTCentral/preview/2019-10-28-preview/iotcentral.json#L1942:13
1021 - AddedAdditionalProperties The new version adds an 'additionalProperties' element.
New: Microsoft.IoTCentral/preview/2019-10-28-preview/iotcentral.json#L2244:13
Old: Microsoft.IoTCentral/preview/2019-10-28-preview/iotcentral.json#L1950:13
1021 - AddedAdditionalProperties The new version adds an 'additionalProperties' element.
New: Microsoft.IoTCentral/preview/2019-10-28-preview/iotcentral.json#L1808:13
Old: Microsoft.IoTCentral/preview/2019-10-28-preview/iotcentral.json#L1977:13
1021 - AddedAdditionalProperties The new version adds an 'additionalProperties' element.
New: Microsoft.IoTCentral/preview/2019-10-28-preview/iotcentral.json#L1833:13
Old: Microsoft.IoTCentral/preview/2019-10-28-preview/iotcentral.json#L1997:13
1021 - AddedAdditionalProperties The new version adds an 'additionalProperties' element.
New: Microsoft.IoTCentral/preview/2019-10-28-preview/iotcentral.json#L1842:13
Old: Microsoft.IoTCentral/preview/2019-10-28-preview/iotcentral.json#L2005:13
1021 - AddedAdditionalProperties The new version adds an 'additionalProperties' element.
New: Microsoft.IoTCentral/preview/2019-10-28-preview/iotcentral.json#L2152:13
Old: Microsoft.IoTCentral/preview/2019-10-28-preview/iotcentral.json#L2033:13
1021 - AddedAdditionalProperties The new version adds an 'additionalProperties' element.
New: Microsoft.IoTCentral/preview/2019-10-28-preview/iotcentral.json#L2178:13
Old: Microsoft.IoTCentral/preview/2019-10-28-preview/iotcentral.json#L2049:13
1021 - AddedAdditionalProperties The new version adds an 'additionalProperties' element.
New: Microsoft.IoTCentral/preview/2019-10-28-preview/iotcentral.json#L2187:13
Old: Microsoft.IoTCentral/preview/2019-10-28-preview/iotcentral.json#L2062:13
LintDiff: 2 Errors, 0 Warnings [Detail] [Expand]
Rule Message
An error occurred while executing JSON.parse() on the linter output for specification/iotcentral/data-plane/readme.md: "role":"Lint Diff",
"new":"https://github.com/Azure/azure-rest-api-specs/blob/55a76cbb290890ccb59f0bec38d57ac375aa818e/specification/iotcentral/data-plane/readme.md",
"old":"https://github.com/Azure/azure-rest-api-specs/blob/master/specification/iotcentral/data-plane/readme.md"
An error occurred while executing JSON.parse() on the linter output for specification/iotcentral/data-plane/readme.md: "role":"Lint Diff",
"new":"https://github.com/Azure/azure-rest-api-specs/blob/55a76cbb290890ccb59f0bec38d57ac375aa818e/specification/iotcentral/data-plane/readme.md",
"old":"https://github.com/Azure/azure-rest-api-specs/blob/master/specification/iotcentral/data-plane/readme.md"
️✔️Avocado [Detail]
 Validation passes for Avocado. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 12, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 12, 2020

azure-sdk-for-go - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 12, 2020

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 12, 2020

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 12, 2020

azure-sdk-for-js - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 12, 2020

azure-sdk-for-python - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 12, 2020

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 12, 2020

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@lmazuel lmazuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest of the CI trouble are understood and not blocking for the PR to be merged

@viv-liu
Copy link
Contributor Author

viv-liu commented Jun 25, 2020

Approved!

@lmazuel lmazuel merged commit 6cee4b5 into Azure:master Jun 25, 2020
00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
* Swagger refactor, small addition

* Ran prettier

* Adding custom word and fixing spelling mistake

* Updates to the swagger

* Removing empty objects

* Removing x-ms-discriminators x4

* Also updated the iotcentralapps json

* Ran prettier

* Updating the README

* Modifying readme again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants