Approved 2020-06 API version to support Live Metrics token generation. #9808

tokaplan · 2020-06-11T04:41:21Z

Note to reviewers: this change has already been approved in private repo: https://github.com/Azure/azure-rest-api-specs-pr/pull/1401

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
- adding/removing APIs.
- adding/removing properties.
- adding/removing API-version.
- adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-pipeline-app · 2020-06-11T04:41:25Z

[Staging] Swagger Validation Report

️️✔️~[Staging] BreakingChange [Detail]

_{Posted by Swagger Pipeline}

azure-pipelines · 2020-06-11T04:41:38Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-06-11T04:43:05Z

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-06-11T04:43:07Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from bcabe30 with merge commit b864383. SDK Automation 13.0.17.20200605.3
️✔️appinsights/mgmt/2015-05-01 [View full logs] [Release SDK Changes]
- appinsights.mgmt.2015-05-01.zip

openapi-sdkautomation · 2020-06-11T04:43:11Z

azure-sdk-for-js - Release

❌ failed [Logs] [Expand Details]

❌ Generate from bcabe30 with merge commit b864383. SDK Automation 13.0.17.20200605.3

[AutoRest] FATAL: swagger-document/compose - FAILED
[AutoRest] FATAL: Error: '$.definitions.ErrorResponse.description' has incompatible values (---
[AutoRest]   -
[AutoRest]   Error response indicates Insights service is not able to process the incoming
[AutoRest]   request. The reason is provided in the error message.
[AutoRest] , ---
[AutoRest] Describes the format of an error response.
[AutoRest] ).
[AutoRest]   Error: '$.definitions.ErrorResponse.description' has incompatible values (---
[AutoRest]   -
[AutoRest]   Error response indicates Insights service is not able to process the incoming
[AutoRest]   request. The reason is provided in the error message.
[AutoRest] , ---
[AutoRest] Describes the format of an error response.
[AutoRest] ).
Failed to run autorest.
Error: /z/node_modules/.bin/autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/z/work/azure-sdk-for-js /z/work/azure-rest-api-specs/specification/applicationinsights/resource-manager/readme.md FATAL: swagger-document/compose - FAILED
FATAL: Error: '$.definitions.ErrorResponse.description' has incompatible values (---
  -
  Error response indicates Insights service is not able to process the incoming
  request. The reason is provided in the error message.
, ---
Describes the format of an error response.
).
  Error: '$.definitions.ErrorResponse.description' has incompatible values (---
  -
  Error response indicates Insights service is not able to process the incoming
  request. The reason is provided in the error message.
, ---
Describes the format of an error response.
).
, {} 
Failed to find any diff after autorest so no changed packages was found.

openapi-sdkautomation · 2020-06-11T04:43:12Z

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from bcabe30 with merge commit b864383. SDK Automation 13.0.17.20200605.3
️✔️sdk/applicationinsights/mgmt-v2015_05_01 [View full logs] [Release SDK Changes]

openapi-sdkautomation · 2020-06-11T04:43:15Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from bcabe30 with merge commit b864383. SDK Automation 13.0.17.20200605.3

️✔️azure-mgmt-applicationinsights [View full logs] [Release SDK Changes]

[build_conf] INFO:packaging_tools:Building template azure-mgmt-applicationinsights
[build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
[build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
[build_conf] INFO:packaging_tools:Template done azure-mgmt-applicationinsights
[after_scripts|python] INFO:__main__:Default API version will be: v2020_03_01_preview
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[ChangeLog] Size of delta 0.482% size of original (original: 71783 chars, delta: 346 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog]   - Model ApplicationInsightsComponent has a new parameter ingestion_mode

openapi-sdkautomation · 2020-06-11T04:43:16Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-06-11T04:43:22Z

azure-sdk-for-net - Release

❌ failed [Logs] [Expand Details]

❌ Generate from bcabe30 with merge commit b864383. SDK Automation 13.0.17.20200605.3

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] FATAL: swagger-document/compose - FAILED
[AutoRest] FATAL: Error: '$.definitions.ErrorResponse.description' has incompatible values (---
[AutoRest]   -
[AutoRest]   Error response indicates Insights service is not able to process the incoming
[AutoRest]   request. The reason is provided in the error message.
[AutoRest] , ---
[AutoRest] Describes the format of an error response.
[AutoRest] ).
[AutoRest]   Error: '$.definitions.ErrorResponse.description' has incompatible values (---
[AutoRest]   -
[AutoRest]   Error response indicates Insights service is not able to process the incoming
[AutoRest]   request. The reason is provided in the error message.
[AutoRest] , ---
[AutoRest] Describes the format of an error response.
[AutoRest] ).
Failed to run autorest.
Error: /z/node_modules/.bin/autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/z/work/azure-sdk-for-net/sdk /z/work/azure-rest-api-specs/specification/applicationinsights/resource-manager/readme.md realpath(): Permission denied
realpath(): Permission denied
realpath(): Permission denied
realpath(): Permission denied
realpath(): Permission denied
realpath(): Permission denied
FATAL: swagger-document/compose - FAILED
FATAL: Error: '$.definitions.ErrorResponse.description' has incompatible values (---
  -
  Error response indicates Insights service is not able to process the incoming
  request. The reason is provided in the error message.
, ---
Describes the format of an error response.
).
  Error: '$.definitions.ErrorResponse.description' has incompatible values (---
  -
  Error response indicates Insights service is not able to process the incoming
  request. The reason is provided in the error message.
, ---
Describes the format of an error response.
).
, {} 
Failed to find any diff after autorest so no changed packages was found.

openapi-sdkautomation · 2020-06-11T04:43:30Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azuresdkci · 2020-06-11T04:46:38Z

Can one of the admins verify this patch?

azure-pipelines · 2020-06-11T04:56:34Z

Azure Pipelines successfully started running 1 pipeline(s).

tokaplan · 2020-06-11T05:31:31Z

Note to reviewers: this change has already been approved in private repo: Azure/azure-rest-api-specs-pr#1401

mmyyrroonn

Approved since it's already reviewed in private repo

mmyyrroonn · 2020-06-11T05:44:28Z

@tokaplan Hi. Could you please change readme.python.md as well? You should add the 2020-06-only tag into batch

tokaplan · 2020-06-11T05:53:18Z

@myronfanqiu do I have to do all changes that I did in readme.md in readme.python.md, or just add the package-preview-2020-06-only tag defined in readme.md into batch section in readme.python.md and that's it?
I don't really understand what those files are all about :)

mmyyrroonn · 2020-06-11T05:59:31Z

Based on my knowledge, you just need to add the package-preview-2020-06-only tag defined in readme.md into batch section in readme.python.md and that's it. But let me invite owner to confirm. @qiaozha Could you take a look at this PR? These files are used for all SDKs.

azure-pipelines · 2020-06-11T06:09:13Z

Azure Pipelines successfully started running 1 pipeline(s).

tokaplan · 2020-06-11T07:52:50Z

@myronfanqiu ok so I made the change you pointed out, I'll make it differently if we hear from someone. One last thing - I'm seeing prettier errors, and it doesn't tell me what's wrong - just tells me to run prettier on my own. I was able to npm install prettier, but it doesn't have a swagger plugin out of the box, so I don't know where to get it and how to run it. Is fixing this issue a prerequisite for merging? If yes, then can you please let me know how to do it? I've seen the instruction, but it doesn't work for me - it tells me to run npm from under node.js console in Windows, and node.js explicitly doesn't allow me to run npm.

qiaozha · 2020-06-11T10:37:24Z

Based on my knowledge, you just need to add the package-preview-2020-06-only tag defined in readme.md into batch section in readme.python.md and that's it. But let me invite owner to confirm. @qiaozha Could you take a look at this PR? These files are used for all SDKs.

That's correct. no need to define the tag again in readme.python.md

qiaozha · 2020-06-11T10:38:53Z

@myronfanqiu ok so I made the change you pointed out, I'll make it differently if we hear from someone. One last thing - I'm seeing prettier errors, and it doesn't tell me what's wrong - just tells me to run prettier on my own. I was able to npm install prettier, but it doesn't have a swagger plugin out of the box, so I don't know where to get it and how to run it. Is fixing this issue a prerequisite for merging? If yes, then can you please let me know how to do it? I've seen the instruction, but it doesn't work for me - it tells me to run npm from under node.js console in Windows, and node.js explicitly doesn't allow me to run npm.

@NullMDR may be able to help here.

azure-pipelines · 2020-06-11T23:06:06Z

Azure Pipelines successfully started running 1 pipeline(s).

tokaplan · 2020-06-12T00:26:54Z

@myronfanqiu ok I managed to run prettier locally and fixed issues. There are SDK checks failing, but I can't find anything relevant to my change, looks like internal tooling errors. Please let me know if we can merge at this point and how to proceed with the manifest change.

mmyyrroonn · 2020-06-12T02:04:21Z

@pilor Hi. Could you please approve this PR on behalf of ARM team since you approved the private PR.

Azure#9808) * Approved 2020-06 version. * Spellcheck fixes. * PR feedback * Prettier fixes.

Approved 2020-06 version.

2d0b800

tokaplan requested a review from mmyyrroonn June 11, 2020 04:41

openapi-assignment-bot bot assigned mmyyrroonn Jun 11, 2020

Spellcheck fixes.

a0d79ce

mmyyrroonn approved these changes Jun 11, 2020

View reviewed changes

openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 11, 2020

PR feedback

3a2a9ac

Prettier fixes.

bcabe30

pilor added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 12, 2020

pilor approved these changes Jun 12, 2020

View reviewed changes

mmyyrroonn merged commit b864383 into Azure:master Jun 15, 2020

00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020

Approved 2020-06 API version to support Live Metrics token generation. (

4e8eb1c

Azure#9808) * Approved 2020-06 version. * Spellcheck fixes. * PR feedback * Prettier fixes.

Approved 2020-06 API version to support Live Metrics token generation. #9808

Approved 2020-06 API version to support Live Metrics token generation. #9808

Uh oh!

Conversation

tokaplan commented Jun 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution checklist:

ARM API Review Checklist

Uh oh!

openapi-pipeline-app bot commented Jun 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

[Staging] Swagger Validation Report

Uh oh!

azure-pipelines bot commented Jun 11, 2020

Uh oh!

openapi-sdkautomation bot commented Jun 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Azure CLI Extension Generation - Release

Uh oh!

openapi-sdkautomation bot commented Jun 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go - Release

Uh oh!

openapi-sdkautomation bot commented Jun 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js - Release

Uh oh!

openapi-sdkautomation bot commented Jun 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java - Release

Uh oh!

openapi-sdkautomation bot commented Jun 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python - Release

Uh oh!

openapi-sdkautomation bot commented Jun 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python-track2 - Release

Uh oh!

openapi-sdkautomation bot commented Jun 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net - Release

Uh oh!

openapi-sdkautomation bot commented Jun 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Trenton Generation - Release

Uh oh!

azuresdkci commented Jun 11, 2020

Uh oh!

azure-pipelines bot commented Jun 11, 2020

Uh oh!

tokaplan commented Jun 11, 2020

Uh oh!

mmyyrroonn left a comment

Choose a reason for hiding this comment

Uh oh!

mmyyrroonn commented Jun 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tokaplan commented Jun 11, 2020

Uh oh!

mmyyrroonn commented Jun 11, 2020

Uh oh!

azure-pipelines bot commented Jun 11, 2020

Uh oh!

tokaplan commented Jun 11, 2020

Uh oh!

qiaozha commented Jun 11, 2020

Uh oh!

qiaozha commented Jun 11, 2020

Uh oh!

azure-pipelines bot commented Jun 11, 2020

Uh oh!

tokaplan commented Jun 12, 2020

Uh oh!

mmyyrroonn commented Jun 12, 2020

Uh oh!

Reviewers

Assignees

Labels

tokaplan commented Jun 11, 2020 •

edited

Loading

openapi-pipeline-app bot commented Jun 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 11, 2020 •

edited

Loading

mmyyrroonn commented Jun 11, 2020 •

edited

Loading