Add 202 to operation checkPrivateLinkServiceVisibility #9800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
00Kai0
requested review from
MikhailTryakhov,
anton-evseev and
v-shhatt
as code owners
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-net - Release
|
Contributor
|
Can one of the admins verify this patch? |
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
azure-sdk-for-java - Release
|
azure-sdk-for-js - Release
|
This was referenced Jun 10, 2020
anton-evseev
approved these changes
Jun 10, 2020
allenjzhang
reviewed
Jun 10, 2020
Contributor
allenjzhang
left a comment
allenjzhang
left a comment
There was a problem hiding this comment.
Does this change go all the way back to 2019-04-01 stable version?
Contributor
|
@00Kai0 Please fix ModelValidation as well. Meanwhile, could you please share the context about this change? This api has been there for one year. Is it a bug fix or a new design? |
Contributor
Author
|
yeah, I tested with version 2019-04-01. It also retuened 202. |
Contributor
|
Please also do this change in |
mmyyrroonn
added
the
WaitForARMFeedback
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python-track2 - Release
|
Contributor
|
@00Kai0 Please follow @number213 's instruction. I think the better way is to open a PR targeting at |
Contributor
Author
|
it's ready. #9821 |
Contributor
|
Closed this PR since it's useless. #9821 |
Contributor
|
@myronfanqiu I assumed since it's a bugfix it should update all versions. I think we sohuld also take this PR in |
Contributor
|
@number213, I saw same changes in #9821. Do you mean we should open this PR and merge this one? |
Contributor
|
@myronfanqiu i yep, this PR fixes all API versions in master, while the other one introduces a fix only in upcoming API version |
Contributor
But in #9821, it also fixes 2020-04-01 version. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mmyyrroonn
approved these changes
Jun 22, 2020
Contributor
|
Adding a new response code to existing apis/versions is a breaking change. |
Member
|
Hi @ravbhatnagar , this PR is to correct the response code in swagger so that it can match what service side actually return. Shall it be a bug fix?
|
Contributor
|
@changlong-liu it is suppossed to be a bugfix AFAIK |
Member
|
@ravbhatnagar Can you put this as high priority. Since it's a bugfix. The breakingchange failure should be ok. right? |
Contributor
|
Signing off from ARM side. |
ravbhatnagar
added
ARMSignedOff
Contributor
|
@akning-ms Hello. Could you help us merge this PR since it's a bug fix. |
00Kai0
added a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
* add 202 to operation checkPrivateLinkServiceVisibility * update examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add code 202 to fix this operation.
Azure/azure-sdk-for-python#11601