add ApiVersion to sample spec #9798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

akning-ms merged 1 commit into Azure:master from weidongxu-microsoft:doc_improve_samples

Jun 14, 2020

Member

weidongxu-microsoft commented Jun 10, 2020 •

edited

Loading

Fix #9796 (comment)

Update sample https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/samplefiles/Microsoft.YourServiceName/stable/YYYY-MM-DD/YourServiceName.json

Generated code

        @Get("/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.YourServiceName/operations")
        @ExpectedResponses({200})
        @UnexpectedResponseExceptionType(ErrorResponseException.class)
        Mono<Response<Result>> get(
                @HostParam("$host") String host,
                @PathParam("subscriptionId") String subscriptionId,
                @PathParam("resourceGroupName") String resourceGroupName,
                @QueryParam("api-version") String apiVersion,
                Context context);

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
- adding/removing APIs.
- adding/removing properties.
- adding/removing API-version.
- adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.


          add ApiVersion to sample spec

745da38

openapi-assignment-bot bot assigned josefree

openapi-pipeline-app bot commented Jun 10, 2020 •

edited

Loading

[Staging] Swagger Validation Report

️️✔️~[Staging] BreakingChange [Detail]

_{Posted by Swagger Pipeline}

azure-pipelines bot commented Jun 10, 2020

Azure Pipelines successfully started running 1 pipeline(s).

weidongxu-microsoft requested a review from mozehgir

June 10, 2020 02:13

openapi-sdkautomation bot commented Jun 10, 2020 •

edited

Loading

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation bot commented Jun 10, 2020 •

edited

Loading

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation bot commented Jun 10, 2020 •

edited

Loading

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation bot commented Jun 10, 2020 •

edited

Loading

azure-sdk-for-python - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation bot commented Jun 10, 2020 •

edited

Loading

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation bot commented Jun 10, 2020 •

edited

Loading

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation bot commented Jun 10, 2020 •

edited

Loading

azure-sdk-for-js - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation bot commented Jun 10, 2020 •

edited

Loading

azure-sdk-for-go - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

Contributor

azuresdkci commented Jun 10, 2020

Can one of the admins verify this patch?

akning-ms approved these changes

View reviewed changes

akning-ms assigned akning-ms and unassigned josefree

akning-ms merged commit 02ed4af into Azure:master

00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request


          add ApiVersion to sample spec (Azure#9798)

d410977

weidongxu-microsoft deleted the doc_improve_samples branch

October 27, 2020 02:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet