ApiManagement - fix quota patch contracts#9642
Merged
akning-ms merged 2 commits intoAzure:masterfrom Jun 12, 2020
Merged
Conversation
|
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net - Release
|
azure-sdk-for-python - Release
|
azure-sdk-for-js - Release
|
Contributor
|
Can one of the admins verify this patch? |
azure-sdk-for-java - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Member
|
@vfedonkin please link the issue reported, so that the impact is clear |
Contributor
Author
|
The issue solved by this PR: Azure/azure-sdk-for-net#11734 |
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Member
|
@markcowl this is a breaking change, as we initially had the spec incorrect. Customer hit this issue and we are trying to fix spec, followed by clients. |
markcowl
approved these changes
Jun 11, 2020
Member
markcowl
left a comment
There was a problem hiding this comment.
This breaking change is approved, since it corrects an issue with the spec (improper serialization of the request body)
markcowl
requested changes
Jun 11, 2020
Member
markcowl
left a comment
There was a problem hiding this comment.
The breaking change is ok, but need to follow the guidance for the failed 'Prettier' check
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-go - Release
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
markcowl
approved these changes
Jun 11, 2020
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
* ApiManagement - fix quota patch contracts * ApiManagement - fix quota patch contracts prettier fix Co-authored-by: vfedonkin <vifedo@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.