Skip to content

Multiple Public IPs support for Azure Firewall in Virtual Hub #9560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2020
Merged

Multiple Public IPs support for Azure Firewall in Virtual Hub #9560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4384d7e
multi pip for firewall in hub swagger change
anchalkpr May 22, 2020
c9083a6
resolving issues
anchalkpr May 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions ...ification/network/resource-manager/Microsoft.Network/stable/2020-05-01/azureFirewall.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,15 +462,30 @@
},
"description": "IpGroups associated with azure firewall."
},
"HubIPAddresses": {
"HubPublicIPAddresses": {
"properties": {
"publicIPAddresses": {
"addresses": {
"type": "array",
"description": "List of Public IP addresses associated with azure firewall.",
"description": "The number of Public IP addresses associated with azure firewall.",
"items": {
"$ref": "#/definitions/AzureFirewallPublicIPAddress"
}
},
"count": {
"type": "integer",
"format": "int32",
"description": "Private IP Address associated with azure firewall."
}
},
"description": "Public IP addresses associated with azure firewall."
},
"HubIPAddresses": {
"properties": {
"publicIPs": {
"type": "array",
"description": "Public IP addresses associated with azure firewall.",
"$ref": "#/definitions/HubPublicIPAddresses"
},
"privateIPAddress": {
"type": "string",
"description": "Private IP Address associated with azure firewall."
Expand Down Expand Up @@ -537,7 +552,6 @@
"description": "The firewallPolicy associated with this azure firewall."
},
"hubIpAddresses": {
"readOnly": true,
"description": "IP addresses associated with AzureFirewall.",
"$ref": "#/definitions/HubIPAddresses"
},
Expand Down
32 changes: 22 additions & 10 deletions .../resource-manager/Microsoft.Network/stable/2020-05-01/examples/AzureFirewallPutInHub.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,12 @@
},
"firewallPolicy": {
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/firewallPolicies/policy1"
},
"hubIpAddresses": {
"publicIPs": {
"addresses": [],
"count": 1
}
}
}
}
Expand Down Expand Up @@ -51,11 +57,14 @@
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/firewallPolicies/policy1"
},
"hubIpAddresses": {
"publicIPAddresses": [
{
"address": "13.73.240.12"
}
],
"publicIPs": {
"addresses": [
{
"address": "13.73.240.12"
}
],
"count": 1
},
"privateIPAddress": "10.0.0.0"
},
"additionalProperties": {}
Expand Down Expand Up @@ -87,11 +96,14 @@
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/firewallPolicies/policy1"
},
"hubIpAddresses": {
"publicIPAddresses": [
{
"address": "13.73.240.12"
}
],
"publicIPs": {
"addresses": [
{
"address": "13.73.240.12"
}
],
"count": 1
},
"privateIPAddress": "10.0.0.0"
},
"ipGroups": [],
Expand Down