Skip to content

Add Power BI Premium#953

Closed
michael-falk wants to merge 1 commit intoAzure:masterfrom
michael-falk:master
Closed

Add Power BI Premium#953
michael-falk wants to merge 1 commit intoAzure:masterfrom
michael-falk:master

Conversation

@michael-falk
Copy link
Copy Markdown

@michael-falk michael-falk commented Feb 21, 2017

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

  • I have read the contribution guidelines.
  • My spec meets the review criteria:
    • The spec conforms to the Swagger 2.0 specification.
    • Validation errors from the Linter extension for VS Code have all been fixed for this spec. (Note: for large, previously checked in specs, there will likely be many errors shown. Please contact our team so we can set a timeframe for fixing these errors if your PR is not going to address them).
    • The spec follows the patterns described in the Swagger good patterns document unless the service API makes this impossible.

This change introduces the swagger spec for Power BI Premium on ARM.
This introduces the following operations:
GET all capacities (in subscription)
GET all capacities (in resource group)
PUT / PATCH / GET / DELETE a single capacity

@azurecla
Copy link
Copy Markdown

Hi @michael-falk, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (mifal). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@jhendrixMSFT
Copy link
Copy Markdown
Member

Hi @michael-falk just wanted to let you know that I'll be reviewing this today.

@jhendrixMSFT
Copy link
Copy Markdown
Member

@michael-falk I have the following feedback so far.

The list operations API is missing. Please see https://github.com/Azure/azure-rest-api-specs/blob/master/arm-resources/resources/2016-09-01/swagger/resources.json#L1696 for an example.

Please add example request/reponse data via x-ms-examples extension. Please see the following commit for an example f2a9a9f#diff-f142889ce5637ec21cbf0a392cf10121

@amarzavery Any feedback from your side?

@jhendrixMSFT
Copy link
Copy Markdown
Member

Hi @michael-falk any update?

Copy link
Copy Markdown
Member

@salameer salameer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michael-falk, this PR has been idle for a while now, kindly note that if we don't recieve a response by the 22nd of March 2017 we will be closing it

@jhendrixMSFT
Copy link
Copy Markdown
Member

Closing due to inactivity. Please re-open when you're ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants