Skip to content

Conversation

@1openwindow
Copy link
Contributor

@1openwindow 1openwindow commented Apr 16, 2020

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 16, 2020

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 16, 2020

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 061b7ec with merge commit 51cd1e0. SDK Automation 13.0.17.20200512.3
  • ️✔️@azure/arm-appplatform [Logs]  [Release SDK Changes]
    [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
    [npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
    [npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
    [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/appPlatformManagementClient.js → ./dist/arm-appplatform.js...
    [npmPack] created ./dist/arm-appplatform.js in 434ms
    [npmPack] npm notice 
    [npmPack] npm notice package: @azure/[email protected]
    [npmPack] npm notice === Tarball Contents === 
    [npmPack] npm notice 2.1kB   esm/appPlatformManagementClient.js             
    [npmPack] npm notice 2.7kB   esm/appPlatformManagementClientContext.js      
    [npmPack] npm notice 11.0kB  esm/operations/apps.js                         
    [npmPack] npm notice 982B    esm/models/appsMappers.js                      
    [npmPack] npm notice 168.9kB dist/arm-appplatform.js                        
    [npmPack] npm notice 57.8kB  dist/arm-appplatform.min.js                    
    [npmPack] npm notice 7.7kB   esm/operations/bindings.js                     
    [npmPack] npm notice 964B    esm/models/bindingsMappers.js                  
    [npmPack] npm notice 6.2kB   esm/operations/certificates.js                 
    [npmPack] npm notice 972B    esm/models/certificatesMappers.js              
    [npmPack] npm notice 9.1kB   esm/operations/customDomains.js                
    [npmPack] npm notice 1.0kB   esm/models/customDomainsMappers.js             
    [npmPack] npm notice 21.4kB  esm/operations/deployments.js                  
    [npmPack] npm notice 990B    esm/models/deploymentsMappers.js               
    [npmPack] npm notice 345B    esm/models/index.js                            
    [npmPack] npm notice 590B    esm/operations/index.js                        
    [npmPack] npm notice 53.5kB  esm/models/mappers.js                          
    [npmPack] npm notice 2.3kB   esm/operations/operations.js                   
    [npmPack] npm notice 560B    esm/models/operationsMappers.js                
    [npmPack] npm notice 3.5kB   esm/models/parameters.js                       
    [npmPack] npm notice 995B    rollup.config.js                               
    [npmPack] npm notice 17.1kB  esm/operations/services.js                     
    [npmPack] npm notice 1.0kB   esm/models/servicesMappers.js                  
    [npmPack] npm notice 2.4kB   esm/operations/skuOperations.js                
    [npmPack] npm notice 584B    esm/models/skuOperationsMappers.js             
    [npmPack] npm notice 1.7kB   package.json                                   
    [npmPack] npm notice 457B    tsconfig.json                                  
    [npmPack] npm notice 881B    esm/appPlatformManagementClient.d.ts.map       
    [npmPack] npm notice 1.2kB   esm/appPlatformManagementClient.js.map         
    [npmPack] npm notice 521B    esm/appPlatformManagementClientContext.d.ts.map
    [npmPack] npm notice 1.4kB   esm/appPlatformManagementClientContext.js.map  
    [npmPack] npm notice 3.5kB   esm/operations/apps.d.ts.map                   
    [npmPack] npm notice 5.6kB   esm/operations/apps.js.map                     
    [npmPack] npm notice 518B    esm/models/appsMappers.d.ts.map                
    [npmPack] npm notice 531B    esm/models/appsMappers.js.map                  
    [npmPack] npm notice 350.0kB dist/arm-appplatform.js.map                    
    [npmPack] npm notice 48.5kB  dist/arm-appplatform.min.js.map                
    [npmPack] npm notice 3.7kB   esm/operations/bindings.d.ts.map               
    [npmPack] npm notice 4.6kB   esm/operations/bindings.js.map                 
    [npmPack] npm notice 513B    esm/models/bindingsMappers.d.ts.map            
    [npmPack] npm notice 526B    esm/models/bindingsMappers.js.map              
    [npmPack] npm notice 2.8kB   esm/operations/certificates.d.ts.map           
    [npmPack] npm notice 3.6kB   esm/operations/certificates.js.map             
    [npmPack] npm notice 521B    esm/models/certificatesMappers.d.ts.map        
    [npmPack] npm notice 534B    esm/models/certificatesMappers.js.map          
    [npmPack] npm notice 4.3kB   esm/operations/customDomains.d.ts.map          
    [npmPack] npm notice 5.3kB   esm/operations/customDomains.js.map            
    [npmPack] npm notice 549B    esm/models/customDomainsMappers.d.ts.map       
    [npmPack] npm notice 562B    esm/models/customDomainsMappers.js.map         
    [npmPack] npm notice 5.8kB   esm/operations/deployments.d.ts.map            
    [npmPack] npm notice 9.9kB   esm/operations/deployments.js.map              
    [npmPack] npm notice 532B    esm/models/deploymentsMappers.d.ts.map         
    [npmPack] npm notice 545B    esm/models/deploymentsMappers.js.map           
    [npmPack] npm notice 21.9kB  esm/models/index.d.ts.map                      
    [npmPack] npm notice 290B    esm/operations/index.d.ts.map                  
    [npmPack] npm notice 126B    esm/models/index.js.map                        
    [npmPack] npm notice 305B    esm/operations/index.js.map                    
    [npmPack] npm notice 3.0kB   esm/models/mappers.d.ts.map                    
    [npmPack] npm notice 30.1kB  esm/models/mappers.js.map                      
    [npmPack] npm notice 1.0kB   esm/operations/operations.d.ts.map             
    [npmPack] npm notice 1.4kB   esm/operations/operations.js.map               
    [npmPack] npm notice 277B    esm/models/operationsMappers.d.ts.map          
    [npmPack] npm notice 290B    esm/models/operationsMappers.js.map            
    [npmPack] npm notice 822B    esm/models/parameters.d.ts.map                 
    [npmPack] npm notice 2.7kB   esm/models/parameters.js.map                   
    [npmPack] npm notice 5.6kB   esm/operations/services.d.ts.map               
    [npmPack] npm notice 9.1kB   esm/operations/services.js.map                 
    [npmPack] npm notice 562B    esm/models/servicesMappers.d.ts.map            
    [npmPack] npm notice 575B    esm/models/servicesMappers.js.map              
    [npmPack] npm notice 1.0kB   esm/operations/skuOperations.d.ts.map          
    [npmPack] npm notice 1.5kB   esm/operations/skuOperations.js.map            
    [npmPack] npm notice 283B    esm/models/skuOperationsMappers.d.ts.map       
    [npmPack] npm notice 296B    esm/models/skuOperationsMappers.js.map         
    [npmPack] npm notice 3.3kB   README.md                                      
    [npmPack] npm notice 1.4kB   esm/appPlatformManagementClient.d.ts           
    [npmPack] npm notice 2.2kB   src/appPlatformManagementClient.ts             
    [npmPack] npm notice 943B    esm/appPlatformManagementClientContext.d.ts    
    [npmPack] npm notice 2.4kB   src/appPlatformManagementClientContext.ts      
    [npmPack] npm notice 10.8kB  esm/operations/apps.d.ts                       
    [npmPack] npm notice 18.6kB  src/operations/apps.ts                         
    [npmPack] npm notice 672B    esm/models/appsMappers.d.ts                    
    [npmPack] npm notice 1.0kB   src/models/appsMappers.ts                      
    [npmPack] npm notice 11.4kB  esm/operations/bindings.d.ts                   
    [npmPack] npm notice 18.7kB  src/operations/bindings.ts                     
    [npmPack] npm notice 654B    esm/models/bindingsMappers.d.ts                
    [npmPack] npm notice 982B    src/models/bindingsMappers.ts                  
    [npmPack] npm notice 8.5kB   esm/operations/certificates.d.ts               
    [npmPack] npm notice 14.4kB  src/operations/certificates.ts                 
    [npmPack] npm notice 662B    esm/models/certificatesMappers.d.ts            
    [npmPack] npm notice 986B    src/models/certificatesMappers.ts              
    [npmPack] npm notice 13.6kB  esm/operations/customDomains.d.ts              
    [npmPack] npm notice 22.4kB  src/operations/customDomains.ts                
    [npmPack] npm notice 721B    esm/models/customDomainsMappers.d.ts           
    [npmPack] npm notice 1.0kB   src/models/customDomainsMappers.ts             
    [npmPack] npm notice 19.0kB  esm/operations/deployments.d.ts                
    [npmPack] npm notice 32.7kB  src/operations/deployments.ts                  
    [npmPack] npm notice 680B    esm/models/deploymentsMappers.d.ts             
    [npmPack] npm notice 1.0kB   src/models/deploymentsMappers.ts               
    [npmPack] npm notice 54.7kB  esm/models/index.d.ts                          
    [npmPack] npm notice 274B    esm/operations/index.d.ts                      
    [npmPack] npm notice 51.8kB  src/models/index.ts                            
    [npmPack] npm notice 558B    src/operations/index.ts                        
    [npmPack] npm notice 4.0kB   esm/models/mappers.d.ts                        
    [npmPack] npm notice 42.0kB  src/models/mappers.ts                          
    [npmPack] npm notice 2.2kB   esm/operations/operations.d.ts                 
    [npmPack] npm notice 4.2kB   src/operations/operations.ts                   
    [npmPack] npm notice 250B    esm/models/operationsMappers.d.ts              
    [npmPack] npm notice 534B    src/models/operationsMappers.ts                
    [npmPack] npm notice 990B    esm/models/parameters.d.ts                     
    [npmPack] npm notice 3.5kB   src/models/parameters.ts                       
    [npmPack] npm notice 16.9kB  esm/operations/services.d.ts                   
    [npmPack] npm notice 30.5kB  src/operations/services.ts                     
    [npmPack] npm notice 737B    esm/models/servicesMappers.d.ts                
    [npmPack] npm notice 1.1kB   src/models/servicesMappers.ts                  
    [npmPack] npm notice 2.0kB   esm/operations/skuOperations.d.ts              
    [npmPack] npm notice 4.1kB   src/operations/skuOperations.ts                
    [npmPack] npm notice 274B    esm/models/skuOperationsMappers.d.ts           
    [npmPack] npm notice 555B    src/models/skuOperationsMappers.ts             
    [npmPack] npm notice 1.1kB   LICENSE.txt                                    
    [npmPack] npm notice === Tarball Details === 
    [npmPack] npm notice name:          @azure/arm-appplatform                  
    [npmPack] npm notice version:       1.0.0                                   
    [npmPack] npm notice filename:      azure-arm-appplatform-1.0.0.tgz         
    [npmPack] npm notice package size:  118.6 kB                                
    [npmPack] npm notice unpacked size: 1.3 MB                                  
    [npmPack] npm notice shasum:        94ac159a04612c2fa8ca7193e8b5dd47a9951b3b
    [npmPack] npm notice integrity:     sha512-T9+6fSQZhHXn3[...]umrz2eYtrSuXA==
    [npmPack] npm notice total files:   119                                     
    [npmPack] npm notice 

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 16, 2020

azure-sdk-for-python - Release

- Breaking Change detected in SDK

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 061b7ec with merge commit 51cd1e0. SDK Automation 13.0.17.20200512.3
  • ⚠️azure-mgmt-appplatform [Logs]  [Release SDK Changes] Breaking Change Detected
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-appplatform
    [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
    [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-appplatform
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    [breaking_change_setup] Cannot uninstall requirement azure-nspkg, not installed
    [breaking_change_setup] Command '['/z/venv/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
    [ChangeLog] Size of delta 29.762% size of original (original: 41140 chars, delta: 12244 chars)
    [ChangeLog] **Features**
    [ChangeLog] 
    [ChangeLog]   - Model ServiceResource has a new parameter sku
    [ChangeLog]   - Model AppResource has a new parameter location
    [ChangeLog]   - Model OperationDetail has a new parameter is_data_action
    [ChangeLog]   - Model AppResourceProperties has a new parameter fqdn
    [ChangeLog]   - Model AppResourceProperties has a new parameter https_only
    [ChangeLog]   - Added operation group CertificatesOperations
    [ChangeLog]   - Added operation group SkuOperations
    [ChangeLog]   - Added operation group CustomDomainsOperations
    [ChangeLog] 
    [ChangeLog] **Breaking changes**
    [ChangeLog] 
    [ChangeLog]   - Operation AppsOperations.create_or_update has a new signature
    [ChangeLog]   - Operation AppsOperations.update has a new signature
    [ChangeLog]   - Model OperationDetail no longer has parameter data_action

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 16, 2020

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 16, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 16, 2020

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

@njuCZ
Copy link
Contributor

njuCZ commented Apr 17, 2020

@1openwindow I have two questions:

  1. it seems all fieds in sku are readonly, so is sku readonly?
  2. in examples, it seems request parameters have sku, will service backend handle it? is it really readonly ?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@1openwindow
Copy link
Contributor Author

1openwindow commented Apr 17, 2020

@1openwindow I have two questions:

  1. it seems all fieds in sku are readonly, so is sku readonly?
  2. in examples, it seems request parameters have sku, will service backend handle it? is it really readonly ?

sku is not readonly. I just removed the "readonly" property in this pull request.

@njuCZ njuCZ added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 23, 2020
Copy link
Contributor

@pilor pilor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@openapi-assignment-bot openapi-assignment-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 11, 2020
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented May 11, 2020

azure-sdk-for-trenton - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented May 11, 2020

Azure CLI Extension Generation

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented May 11, 2020

Azure CLI Extension Generation

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@1openwindow
Copy link
Contributor Author

@pilor please review this PR again.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented May 14, 2020

Azure CLI Extension Generation

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

}
}
},
"ResourceTypeSku": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"ResourceTypeSku" [](start = 4, length = 17)

this is the private contract definition (between your RP and ARM), not the public definition. See specification\datamigration\resource-manager\Microsoft.DataMigration\preview\2017-11-15-preview\definitions\ResourceSkus.json for an example of the public definition

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pilor , thanks. Added ResourceSku in swagger. Please review it.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented May 15, 2020

Azure CLI Extension Generation

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

Copy link
Contributor

@pilor pilor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@pilor pilor added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested labels May 15, 2020
@akning-ms akning-ms merged commit 51cd1e0 into Azure:master May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review potential-sdk-breaking-change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants