Skip to content

autogen automation onboard cli#9019

Closed
qiaozha wants to merge 7 commits intomasterfrom
autogen-automation-onboard-cli
Closed

autogen automation onboard cli#9019
qiaozha wants to merge 7 commits intomasterfrom
autogen-automation-onboard-cli

Conversation

@qiaozha
Copy link
Member

@qiaozha qiaozha commented Apr 13, 2020

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 13, 2020

azure-cli-extensions

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 13, 2020

azure-sdk-for-js

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 13, 2020

azure-sdk-for-go

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 13, 2020

azure-sdk-for-python

failed [Logs] [Expand Details]
  • Generate from c6d28c6 with merge commit a0b4a99223669b16f2e2d64486149582275a3b08. SDK Automation 13.0.17.20200424.4
    SDK Repository Error: {
      "name": "HttpError",
      "status": 401,
      "headers": {
        "access-control-allow-origin": "*",
        "access-control-expose-headers": "ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset",
        "connection": "close",
        "content-length": "83",
        "content-security-policy": "default-src 'none'",
        "content-type": "application/json; charset=utf-8",
        "date": "Fri, 01 May 2020 01:45:52 GMT",
        "referrer-policy": "origin-when-cross-origin, strict-origin-when-cross-origin",
        "server": "GitHub.com",
        "status": "401 Unauthorized",
        "strict-transport-security": "max-age=31536000; includeSubdomains; preload",
        "vary": "Accept-Encoding, Accept, X-Requested-With",
        "x-content-type-options": "nosniff",
        "x-frame-options": "deny",
        "x-github-media-type": "github.machine-man-preview; format=json, github.machine-man-preview; format=json",
        "x-github-request-id": "0481:066B:351FEA:788C5A:5EAB7F50",
        "x-ratelimit-limit": "60",
        "x-ratelimit-remaining": "59",
        "x-ratelimit-reset": "1588301152",
        "x-xss-protection": "1; mode=block"
      },
      "request": {
        "method": "GET",
        "url": "https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-python/git/refs/heads/",
        "headers": {
          "accept": "application/vnd.github.machine-man-preview+json,application/vnd.github.machine-man-preview+json",
          "user-agent": "octokit.js/16.43.1 Node.js/12.16.2 (Linux 5.0; x64)",
          "authorization": "token [REDACTED]"
        },
        "request": {}
      },
      "documentation_url": "https://developer.github.com/v3"
    }
    HttpError: Bad credentials
        at /z/node_modules/@octokit/request/dist-node/index.js:66:23
        at processTicksAndRejections (internal/process/task_queues.js:97:5)

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 13, 2020

azure-sdk-for-java

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 13, 2020

azure-sdk-for-net

️✔️ succeeded [Logs] [Expand Details]

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 17, 2020

azure-sdk-for-trenton

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 9019 in repo Azure/azure-rest-api-specs

@PhoenixHe-NV
Copy link

/azp run automation - sdk

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@akning-ms
Copy link
Contributor

Hi @qiaozha, Are you using this PR for testing Cli Code Gen? If yes, You may put a label 'NotReadyForReview'

@qiaozha
Copy link
Member Author

qiaozha commented Apr 23, 2020

Hi @qiaozha, Are you using this PR for testing Cli Code Gen? If yes, You may put a label 'NotReadyForReview'

I am using this PR to onboard CLI for automation. But because I've made some changes in their swagger, it needs service team to confirm and they haven't give the ETA yet.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@PhoenixHe-NV
Copy link

/azp run automation - sdk

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@qiaozha qiaozha added the NotReadyForReview <valid label in PR review process>It is in draft for swagger or not swagger PR label May 9, 2020
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 2, 2020

[Staging] Swagger Validation Report

~[Staging] BreakingChange: 20 Errors, 0 Warnings [Detail][Expand Details]
Rule Message
1026 - TypeChanged The new version has a different type 'integer' than the previous one ''.
New: Microsoft.Automation/common/v1/schemas.json#L97:9
Old: Microsoft.Automation/stable/2015-10-31/schedule.json#L528:9
1026 - TypeChanged The new version has a different type 'integer' than the previous one ''.
New: Microsoft.Automation/common/v1/schemas.json#L97:9
Old: Microsoft.Automation/stable/2015-10-31/schedule.json#L528:9
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'runbook' renamed or removed?
New: Microsoft.Automation/common/v1/schemas.json#L54:7
Old: Microsoft.Automation/stable/2015-10-31/jobSchedule.json#L318:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'parameters' renamed or removed?
New: Microsoft.Automation/common/v1/schemas.json#L54:7
Old: Microsoft.Automation/stable/2015-10-31/jobSchedule.json#L318:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'jobScheduleId' renamed or removed?
New: Microsoft.Automation/common/v1/schemas.json#L54:7
Old: Microsoft.Automation/stable/2015-10-31/jobSchedule.json#L318:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'schedule' renamed or removed?
New: Microsoft.Automation/common/v1/schemas.json#L54:7
Old: Microsoft.Automation/stable/2015-10-31/jobSchedule.json#L318:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'runOn' renamed or removed?
New: Microsoft.Automation/common/v1/schemas.json#L54:7
Old: Microsoft.Automation/stable/2015-10-31/jobSchedule.json#L318:7
1041 - AddedPropertyInResponse The new version has a new property 'expiryTimeOffsetMinutes' in response that was not found in the old version.
New: Microsoft.Automation/common/v1/schemas.json#L54:7
Old: Microsoft.Automation/stable/2015-10-31/jobSchedule.json#L318:7
1041 - AddedPropertyInResponse The new version has a new property 'isEnabled' in response that was not found in the old version.
New: Microsoft.Automation/common/v1/schemas.json#L54:7
Old: Microsoft.Automation/stable/2015-10-31/jobSchedule.json#L318:7
1041 - AddedPropertyInResponse The new version has a new property 'nextRun' in response that was not found in the old version.
New: Microsoft.Automation/common/v1/schemas.json#L54:7
Old: Microsoft.Automation/stable/2015-10-31/jobSchedule.json#L318:7
Posted by Swagger Pipeline

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 9019 in repo Azure/azure-rest-api-specs

@qiaozha qiaozha closed this Jul 31, 2020
@JackTn
Copy link
Member

JackTn commented Aug 23, 2021

Hi, @qiaozha. The PR has be closed for a long time and it's related branch still exist. If no further used for over 14 days, I will delete this related branch. Please tell me if you still need this branch.

@JackTn
Copy link
Member

JackTn commented Jun 16, 2022

Hi, @qiaozha. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.

2 similar comments
@JackTn
Copy link
Member

JackTn commented Jun 16, 2022

Hi, @qiaozha. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.

@JackTn
Copy link
Member

JackTn commented Jun 16, 2022

Hi, @qiaozha. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.

@JackTn JackTn deleted the autogen-automation-onboard-cli branch July 5, 2022 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DoNotMerge <valid label in PR review process> use to hold merge after approval NotReadyForReview <valid label in PR review process>It is in draft for swagger or not swagger PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants