Skip to content

Network March release#8968

Merged
mmyyrroonn merged 11 commits intomasterfrom
network-march-release
Apr 8, 2020
Merged

Network March release#8968
mmyyrroonn merged 11 commits intomasterfrom
network-march-release

Conversation

@anton-evseev
Copy link
Contributor

Need to get #8707 in first

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

MikhailTryakhov and others added 10 commits March 12, 2020 19:07
#8708)

* Move ExpressRouteGateway definitions inside of virtualWAN.json to fix documentation issues

* Fix readme file

Co-authored-by: Vinaya Damle <vinayada@microsoft.com>
* Adding securityPartnerProvider resource

* Adding securityPartnerProvider resource : 2

* Added Definition for SecurityPartnerProviderListResult

* Updated Readme.md with securityPartnerProvider

* fixing zone..

* Fixing using Prettier

* desc fix

* Fixing enum conflict

* RequiredPropertiesMissingInResourceModel Fix

* capitalizing alphabets

* renaming list/listall

* Updated Tags to Caps

Co-authored-by: Ishani Gupta <isgu@microsoft.com>
* AzureFirewall User Tags Update

* Prettier Fixes

Co-authored-by: Ishani Gupta <isgu@microsoft.com>
* Add IpAllocation resource for Hypernet IP management.

* Fix path issue.

* Fix some issues by PR comments.

* Fix document issue.

* Fix reference with SubResource.

* Fix IpAllocation tags name issue.

* Add patch operation to IpAllocation resource.

* Fix spell issue with pretter.
…customDNSconfig JSON to privateEndpoint. (#8704)

* Adding privateEndpoint child resource privateDNSZoneGroup, as well as adding customDNSconfig JSONto privateendpoint

* Adding endzone keyword for build

* Adding reference to 2020 private endpoint in readme for validation purposes

* Misspelled reference to Get file fixed

* Ran prettier fix on files

* Removing reference in readme

* Added some needed capitilization and punctuation, will be a pt2 to this commit

* Added descriptions

* Rerunning tests.

* Updated definitions for customdnsconfig and record set

* Rebuilding for pr

* Changing word back to original sentence for PR.

* Changed name in example file for create, as well as added List operation and fixed pr comments

* resolved comments based on pr

* Added changes based on PRcomments

* Added integer tag to ttl

* getting rid of type in private endpoint json

* Changed type attribute in privateendpointdnszonegroupget

* Added read only attribute to record set array

Co-authored-by: Shane Baden <shbaden@microsoft.com>
* Add intrusionSystemMode to firewallPolicy

* Change intrusionSystemMode to be either Enabled or Disabled

* fix pretier

* remove white space

* remove the examples as this is a preview feature

Co-authored-by: Shany Pozin <shanyp@microsoft.com>
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 7, 2020

azure-cli-extensions - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 7, 2020

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 249377f with merge commit 0f80028. SDK Automation 13.0.17.20200326.3
  • ⚠️network/mgmt/2015-06-15 [Logs
      No file is changed.
    • ⚠️network/mgmt/2016-03-30 [Logs
        No file is changed.
      • ⚠️network/mgmt/2016-06-01 [Logs
          No file is changed.
        • ️✔️network/mgmt/2016-09-01 [Logs]  [Release SDK Changes]
        • ️✔️network/mgmt/2016-12-01 [Logs]  [Release SDK Changes]
        • ⚠️network/mgmt/2017-03-01 [Logs
            No file is changed.
          • ⚠️network/mgmt/2017-06-01 [Logs
              No file is changed.
            • ⚠️network/mgmt/2017-08-01 [Logs
                No file is changed.
              • ⚠️network/mgmt/2017-09-01 [Logs
                  No file is changed.
                • ⚠️network/mgmt/2017-10-01 [Logs
                    No file is changed.
                  • ⚠️network/mgmt/2017-11-01 [Logs
                      No file is changed.
                    • ⚠️network/mgmt/2018-01-01 [Logs
                        No file is changed.
                      • ⚠️network/mgmt/2018-02-01 [Logs
                          No file is changed.
                        • ⚠️network/mgmt/2018-04-01 [Logs
                            No file is changed.
                          • ⚠️network/mgmt/2018-06-01 [Logs
                              No file is changed.
                            • ⚠️network/mgmt/2018-07-01 [Logs
                                No file is changed.
                              • ⚠️network/mgmt/2018-08-01 [Logs
                                  No file is changed.
                                • ⚠️network/mgmt/2018-10-01 [Logs
                                    No file is changed.
                                  • ⚠️network/mgmt/2018-11-01 [Logs
                                      No file is changed.
                                    • ⚠️network/mgmt/2018-12-01 [Logs
                                        No file is changed.
                                      • ⚠️network/mgmt/2019-02-01 [Logs
                                          No file is changed.
                                        • ⚠️network/mgmt/2019-04-01 [Logs
                                            No file is changed.
                                          • ⚠️network/mgmt/2019-06-01 [Logs
                                              No file is changed.
                                            • ⚠️network/mgmt/2019-07-01 [Logs
                                                No file is changed.
                                              • ⚠️network/mgmt/2019-08-01 [Logs
                                                  No file is changed.
                                                • ⚠️network/mgmt/2019-09-01 [Logs
                                                    No file is changed.
                                                  • ️✔️network/mgmt/2019-11-01 [Logs]  [Release SDK Changes]
                                                  • ️✔️network/mgmt/2019-12-01 [Logs]  [Release SDK Changes]
                                                  • ⚠️preview/network/mgmt/2015-05-01-preview [Logs
                                                      No file is changed.

                                                    @openapi-sdkautomation
                                                    Copy link

                                                    openapi-sdkautomation bot commented Apr 7, 2020

                                                    azure-sdk-for-java - Release

                                                    ⚠️ warning [Logs] [Expand Details]
                                                    • ⚠️ Generate from 249377f with merge commit 0f80028. SDK Automation 13.0.17.20200326.3
                                                    • ️✔️sdk/network/mgmt-v2019_02_01 [Logs]  [Release SDK Changes]
                                                    • ⚠️sdk/network/mgmt-v2019_04_01 [Logs]  [Release SDK Changes]
                                                        [mvn] [ERROR] COMPILATION ERROR : 
                                                        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_04_01/src/main/java/com/microsoft/azure/management/network/v2019_04_01/implementation/LocationAvailablePrivateEndpointTypeModelImpl.java:[37,28] cannot find symbol
                                                        [mvn]   symbol:   method serviceName()
                                                        [mvn]   location: class com.microsoft.azure.management.network.v2019_04_01.implementation.AvailablePrivateEndpointTypeInner
                                                        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_04_01/src/main/java/com/microsoft/azure/management/network/v2019_04_01/implementation/LocationAvailablePrivateEndpointTypeImpl.java:[37,28] cannot find symbol
                                                        [mvn]   symbol:   method serviceName()
                                                        [mvn]   location: class com.microsoft.azure.management.network.v2019_04_01.implementation.AvailablePrivateEndpointTypeInner
                                                        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_04_01/src/main/java/com/microsoft/azure/management/network/v2019_04_01/implementation/AvailableResourceGroupPrivateEndpointTypesImpl.java:[23,30] cannot find symbol
                                                        [mvn]   symbol:   method availableResourceGroupPrivateEndpointTypes()
                                                        [mvn]   location: class com.microsoft.azure.management.network.v2019_04_01.implementation.NetworkManagementClientImpl
                                                        [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-network: Compilation failure: Compilation failure: 
                                                        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_04_01/src/main/java/com/microsoft/azure/management/network/v2019_04_01/implementation/LocationAvailablePrivateEndpointTypeModelImpl.java:[37,28] cannot find symbol
                                                        [mvn] [ERROR]   symbol:   method serviceName()
                                                        [mvn] [ERROR]   location: class com.microsoft.azure.management.network.v2019_04_01.implementation.AvailablePrivateEndpointTypeInner
                                                        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_04_01/src/main/java/com/microsoft/azure/management/network/v2019_04_01/implementation/LocationAvailablePrivateEndpointTypeImpl.java:[37,28] cannot find symbol
                                                        [mvn] [ERROR]   symbol:   method serviceName()
                                                        [mvn] [ERROR]   location: class com.microsoft.azure.management.network.v2019_04_01.implementation.AvailablePrivateEndpointTypeInner
                                                        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_04_01/src/main/java/com/microsoft/azure/management/network/v2019_04_01/implementation/AvailableResourceGroupPrivateEndpointTypesImpl.java:[23,30] cannot find symbol
                                                        [mvn] [ERROR]   symbol:   method availableResourceGroupPrivateEndpointTypes()
                                                        [mvn] [ERROR]   location: class com.microsoft.azure.management.network.v2019_04_01.implementation.NetworkManagementClientImpl
                                                        [mvn] [ERROR] -> [Help 1]
                                                        [mvn] [ERROR] 
                                                        [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
                                                        [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
                                                        [mvn] [ERROR] 
                                                        [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
                                                        [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
                                                      • ️✔️sdk/network/mgmt-v2019_06_01 [Logs]  [Release SDK Changes]
                                                      • ️✔️sdk/network/mgmt-v2019_07_01 [Logs]  [Release SDK Changes]
                                                      • ️✔️sdk/network/mgmt-v2019_08_01 [Logs]  [Release SDK Changes]
                                                      • ⚠️sdk/network/mgmt-v2019_09_01 [Logs]  [Release SDK Changes]
                                                          [mvn] [ERROR] COMPILATION ERROR : 
                                                          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_09_01/src/main/java/com/microsoft/azure/management/network/v2019_09_01/Subnet.java:[108,10] cannot find symbol
                                                          [mvn]   symbol:   class ResourceNavigationLinkInner
                                                          [mvn]   location: interface com.microsoft.azure.management.network.v2019_09_01.Subnet
                                                          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_09_01/src/main/java/com/microsoft/azure/management/network/v2019_09_01/Subnet.java:[118,10] cannot find symbol
                                                          [mvn]   symbol:   class ServiceAssociationLinkInner
                                                          [mvn]   location: interface com.microsoft.azure.management.network.v2019_09_01.Subnet
                                                          [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-network: Compilation failure: Compilation failure: 
                                                          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_09_01/src/main/java/com/microsoft/azure/management/network/v2019_09_01/Subnet.java:[108,10] cannot find symbol
                                                          [mvn] [ERROR]   symbol:   class ResourceNavigationLinkInner
                                                          [mvn] [ERROR]   location: interface com.microsoft.azure.management.network.v2019_09_01.Subnet
                                                          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_09_01/src/main/java/com/microsoft/azure/management/network/v2019_09_01/Subnet.java:[118,10] cannot find symbol
                                                          [mvn] [ERROR]   symbol:   class ServiceAssociationLinkInner
                                                          [mvn] [ERROR]   location: interface com.microsoft.azure.management.network.v2019_09_01.Subnet
                                                          [mvn] [ERROR] -> [Help 1]
                                                          [mvn] [ERROR] 
                                                          [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
                                                          [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
                                                          [mvn] [ERROR] 
                                                          [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
                                                          [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

                                                        @azuresdkci
                                                        Copy link
                                                        Contributor

                                                        Can one of the admins verify this patch?

                                                        @openapi-sdkautomation
                                                        Copy link

                                                        openapi-sdkautomation bot commented Apr 7, 2020

                                                        azure-sdk-for-js - Release

                                                        ️✔️ succeeded [Logs] [Expand Details]
                                                        • ️✔️ Generate from 249377f with merge commit 0f80028. SDK Automation 13.0.17.20200326.3
                                                        • ️✔️@azure/arm-network [Logs]  [Release SDK Changes]
                                                          [npmPack] npm WARN lifecycle @azure/arm-network@20.0.0~prepack: cannot run in wd @azure/arm-network@20.0.0 npm install && npm run build (wd=/z/work/azure-sdk-for-js/sdk/network/arm-network)

                                                        @openapi-sdkautomation
                                                        Copy link

                                                        openapi-sdkautomation bot commented Apr 7, 2020

                                                        azure-sdk-for-python - Release

                                                        failed [Logs] [Expand Details]
                                                        • Generate from 249377f with merge commit 0f80028. SDK Automation 13.0.17.20200326.3
                                                          SDK Repository Error: {}
                                                          Error: git fetch main error: RPC failed; curl 56 GnuTLS recv error (-54): Error in the pull function.
                                                          fatal: The remote end hung up unexpectedly
                                                          fatal: early EOF
                                                          fatal: index-pack failed
                                                          
                                                          at Object.<anonymous> (/z/node_modules/@ts-common/azure-js-dev-tools/dist/lib/run.js:557:31)
                                                          at step (/z/node_modules/tslib/tslib.js:136:27)
                                                          at Object.next (/z/node_modules/tslib/tslib.js:117:57)
                                                          at fulfilled (/z/node_modules/tslib/tslib.js:107:62)
                                                          at runMicrotasks (<anonymous>)
                                                          at processTicksAndRejections (internal/process/task_queues.js:97:5)</pre></li></ul></details>
                                                          

                                                        @openapi-sdkautomation
                                                        Copy link

                                                        openapi-sdkautomation bot commented Apr 7, 2020

                                                        azure-sdk-for-net - Release

                                                        ️✔️ succeeded [Logs] [Expand Details]

                                                        * DPDTimeout Multiple Radius changes
                                                        
                                                        * PR feedback, resource changes
                                                        
                                                        * PR feedback, example changes
                                                        
                                                        * examples fix
                                                        
                                                        * PR feedback
                                                        
                                                        * CI fix
                                                        
                                                        * prettier fix attempt
                                                        @azure-pipelines
                                                        Copy link

                                                        Azure Pipelines successfully started running 1 pipeline(s).

                                                        @mmyyrroonn
                                                        Copy link
                                                        Contributor

                                                        @zikalino @number213 If it's ok to merge, please let me know and I can merge it. LGTM.

                                                        @anton-evseev
                                                        Copy link
                                                        Contributor Author

                                                        @myronfanqiu please merge as all the changes have been already reviewed in their PRs

                                                        @mmyyrroonn mmyyrroonn merged commit 0f80028 into master Apr 8, 2020
                                                        @akning-ms akning-ms deleted the network-march-release branch September 14, 2020 02:08
                                                        00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
                                                        * Adds base for updating Microsoft.Network from version stable/2019-12-01 to version 2020-03-01
                                                        
                                                        * Updates readme
                                                        
                                                        * Updates API version in new specs and examples
                                                        
                                                        * Move ExpressRouteGateway definitions inside of virtualWAN.json to fix… (Azure#8708)
                                                        
                                                        * Move ExpressRouteGateway definitions inside of virtualWAN.json to fix documentation issues
                                                        
                                                        * Fix readme file
                                                        
                                                        Co-authored-by: Vinaya Damle <vinayada@microsoft.com>
                                                        
                                                        * Adding SecurityPartnerProvider Resource (Azure#8721)
                                                        
                                                        * Adding securityPartnerProvider resource
                                                        
                                                        * Adding securityPartnerProvider resource : 2
                                                        
                                                        * Added Definition for SecurityPartnerProviderListResult
                                                        
                                                        * Updated Readme.md with securityPartnerProvider
                                                        
                                                        * fixing zone..
                                                        
                                                        * Fixing using Prettier
                                                        
                                                        * desc fix
                                                        
                                                        * Fixing enum conflict
                                                        
                                                        * RequiredPropertiesMissingInResourceModel Fix
                                                        
                                                        * capitalizing alphabets
                                                        
                                                        * renaming list/listall
                                                        
                                                        * Updated Tags to Caps
                                                        
                                                        Co-authored-by: Ishani Gupta <isgu@microsoft.com>
                                                        
                                                        * AzureFirewall User Tags Update (Azure#8748)
                                                        
                                                        * AzureFirewall User Tags Update
                                                        
                                                        * Prettier Fixes
                                                        
                                                        Co-authored-by: Ishani Gupta <isgu@microsoft.com>
                                                        
                                                        * Add IpAllocation resource for Hypernet IP management. (Azure#8701)
                                                        
                                                        * Add IpAllocation resource for Hypernet IP management.
                                                        
                                                        * Fix path issue.
                                                        
                                                        * Fix some issues by PR comments.
                                                        
                                                        * Fix document issue.
                                                        
                                                        * Fix reference with SubResource.
                                                        
                                                        * Fix IpAllocation tags name issue.
                                                        
                                                        * Add patch operation to IpAllocation resource.
                                                        
                                                        * Fix spell issue with pretter.
                                                        
                                                        * Introducing force policy association feature (Azure#8738)
                                                        
                                                        * Adding privateEndpoint child resource privateDNSZoneGroup and adding customDNSconfig JSON to privateEndpoint. (Azure#8704)
                                                        
                                                        * Adding privateEndpoint child resource privateDNSZoneGroup, as well as adding customDNSconfig JSONto privateendpoint
                                                        
                                                        * Adding endzone keyword for build
                                                        
                                                        * Adding reference to 2020 private endpoint in readme for validation purposes
                                                        
                                                        * Misspelled reference to Get file fixed
                                                        
                                                        * Ran prettier fix on files
                                                        
                                                        * Removing reference in readme
                                                        
                                                        * Added some needed capitilization and punctuation, will be a pt2 to this commit
                                                        
                                                        * Added descriptions
                                                        
                                                        * Rerunning tests.
                                                        
                                                        * Updated definitions for customdnsconfig and record set
                                                        
                                                        * Rebuilding for pr
                                                        
                                                        * Changing word back to original sentence for PR.
                                                        
                                                        * Changed name in example file for create, as well as added List operation and fixed pr comments
                                                        
                                                        * resolved comments based on pr
                                                        
                                                        * Added changes based on PRcomments
                                                        
                                                        * Added integer tag to ttl
                                                        
                                                        * getting rid of type in private endpoint json
                                                        
                                                        * Changed type attribute in privateendpointdnszonegroupget
                                                        
                                                        * Added read only attribute to record set array
                                                        
                                                        Co-authored-by: Shane Baden <shbaden@microsoft.com>
                                                        
                                                        * Adding intrusionSystemMode property to firewallPolicy (Azure#8885)
                                                        
                                                        * Add intrusionSystemMode to firewallPolicy
                                                        
                                                        * Change intrusionSystemMode to be either Enabled or Disabled
                                                        
                                                        * fix pretier
                                                        
                                                        * remove white space
                                                        
                                                        * remove the examples as this is a preview feature
                                                        
                                                        Co-authored-by: Shany Pozin <shanyp@microsoft.com>
                                                        
                                                        * DPDTimeout Multiple Radius for VPN Gateways (Network) (Azure#8707)
                                                        
                                                        * DPDTimeout Multiple Radius changes
                                                        
                                                        * PR feedback, resource changes
                                                        
                                                        * PR feedback, example changes
                                                        
                                                        * examples fix
                                                        
                                                        * PR feedback
                                                        
                                                        * CI fix
                                                        
                                                        * prettier fix attempt
                                                        
                                                        Co-authored-by: Mikhail <mitryakh@microsoft.com>
                                                        Co-authored-by: vinayada1 <vinayadamle@gmail.com>
                                                        Co-authored-by: Vinaya Damle <vinayada@microsoft.com>
                                                        Co-authored-by: Ishani Gupta <ishani.gupta27.ig@gmail.com>
                                                        Co-authored-by: Ishani Gupta <isgu@microsoft.com>
                                                        Co-authored-by: liuh-80 <58683130+liuh-80@users.noreply.github.com>
                                                        Co-authored-by: Venkata Krishnan Anantha Raman <venkatakrishnansvpr@gmail.com>
                                                        Co-authored-by: Shane Baden <naruto.shane@gmail.com>
                                                        Co-authored-by: Shane Baden <shbaden@microsoft.com>
                                                        Co-authored-by: Shany Pozin <shanyp@gmail.com>
                                                        Co-authored-by: Shany Pozin <shanyp@microsoft.com>
                                                        Co-authored-by: Henry Chen <henche@microsoft.com>
                                                        Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

                                                        Labels

                                                        None yet

                                                        Projects

                                                        None yet

                                                        Development

                                                        Successfully merging this pull request may close these issues.

                                                        Comments