Adding Managed HSM support #8962

riteshchitlangia1 · 2020-04-07T00:27:43Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

azure-pipelines · 2020-04-07T00:27:59Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-04-07T00:29:13Z

azure-sdk-for-python

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 4ccfff0 with merge commit c27ac3022ace3b96318ab3c8b1742db21bc71ad8. SDK Automation 13.0.17.20200326.3
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-04-07T00:29:14Z

azure-cli-extensions

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-04-07T00:29:16Z

azure-sdk-for-go

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 4ccfff0 with merge commit c27ac3022ace3b96318ab3c8b1742db21bc71ad8. SDK Automation 13.0.17.20200326.3
⚠️keyvault/mgmt/2015-06-01 [Logs]
```
No file is changed.
```
⚠️keyvault/mgmt/2016-10-01 [Logs]
```
No file is changed.
```
⚠️keyvault/mgmt/2018-02-14 [Logs]
```
No file is changed.
```

openapi-sdkautomation · 2020-04-07T00:29:16Z

azure-sdk-for-java

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 4ccfff0 with merge commit c27ac3022ace3b96318ab3c8b1742db21bc71ad8. SDK Automation 13.0.17.20200326.3

⚠️sdk/keyvault/mgmt-v2015_06_01 [Logs] [Preview SDK Changes]

[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.8:jar (default-cli) on project azure-keyvault: MavenReportException: Error while creating archive: 
[mvn] [ERROR] Exit code: 1 - /z/work/azure-sdk-for-java/sdk/keyvault/mgmt-v2015_06_01/src/main/java/com/microsoft/azure/management/keyvault/v2015_06_01/package-info.java:11: warning: a package-info.java file has already been seen for package com.microsoft.azure.management.keyvault.v2015_06_01
[mvn] [ERROR] package com.microsoft.azure.management.keyvault.v2015_06_01;
[mvn] [ERROR]                                                ^
[mvn] [ERROR] javadoc: warning - Multiple sources of package comments found for package "com.microsoft.azure.management.keyvault.v2015_06_01"
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/keyvault/mgmt-v2015_06_01/src/main/java/com/microsoft/azure/management/keyvault/v20150601/Vaults.java:13: error: cannot access Vault
[mvn] [ERROR] import com.microsoft.azure.management.keyvault.v20150601.models.Vault;
[mvn] [ERROR]                                                                ^
[mvn] [ERROR]   bad source file: /z/work/azure-sdk-for-java/sdk/keyvault/mgmt-v2015_06_01/src/main/java/com/microsoft/azure/management/keyvault/v20150601/models/Vault.java
[mvn] [ERROR]     file does not contain class com.microsoft.azure.management.keyvault.v20150601.models.Vault
[mvn] [ERROR]     Please remove or make sure it appears in the correct subdirectory of the sourcepath.
[mvn] [ERROR] 
[mvn] [ERROR] Command line was: /usr/lib/jvm/java-8-openjdk-amd64/jre/../bin/javadoc @options @packages
[mvn] [ERROR] 
[mvn] [ERROR] Refer to the generated Javadoc files in '/z/work/azure-sdk-for-java/sdk/keyvault/mgmt-v2015_06_01/target/apidocs' dir.
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

⚠️sdk/keyvault/mgmt-v2016_10_01 [Logs] [Preview SDK Changes]

[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.8:jar (default-cli) on project azure-keyvault: MavenReportException: Error while creating archive: 
[mvn] [ERROR] Exit code: 1 - /z/work/azure-sdk-for-java/sdk/keyvault/mgmt-v2016_10_01/src/main/java/com/microsoft/azure/management/keyvault/v2016_10_01/package-info.java:11: warning: a package-info.java file has already been seen for package com.microsoft.azure.management.keyvault.v2016_10_01
[mvn] [ERROR] package com.microsoft.azure.management.keyvault.v2016_10_01;
[mvn] [ERROR]                                                ^
[mvn] [ERROR] javadoc: warning - Multiple sources of package comments found for package "com.microsoft.azure.management.keyvault.v2016_10_01"
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/keyvault/mgmt-v2016_10_01/src/main/java/com/microsoft/azure/management/keyvault/v20161001/Operations.java:13: error: cannot access Operation
[mvn] [ERROR] import com.microsoft.azure.management.keyvault.v20161001.models.Operation;
[mvn] [ERROR]                                                                ^
[mvn] [ERROR]   bad source file: /z/work/azure-sdk-for-java/sdk/keyvault/mgmt-v2016_10_01/src/main/java/com/microsoft/azure/management/keyvault/v20161001/models/Operation.java
[mvn] [ERROR]     file does not contain class com.microsoft.azure.management.keyvault.v20161001.models.Operation
[mvn] [ERROR]     Please remove or make sure it appears in the correct subdirectory of the sourcepath.
[mvn] [ERROR] 
[mvn] [ERROR] Command line was: /usr/lib/jvm/java-8-openjdk-amd64/jre/../bin/javadoc @options @packages
[mvn] [ERROR] 
[mvn] [ERROR] Refer to the generated Javadoc files in '/z/work/azure-sdk-for-java/sdk/keyvault/mgmt-v2016_10_01/target/apidocs' dir.
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

⚠️sdk/keyvault/mgmt-v2018_02_14_preview [Logs] [Preview SDK Changes]

[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.8:jar (default-cli) on project azure-keyvault: MavenReportException: Error while creating archive: 
[mvn] [ERROR] Exit code: 1 - /z/work/azure-sdk-for-java/sdk/keyvault/mgmt-v2018_02_14_preview/src/main/java/com/microsoft/azure/management/keyvault/v20180214preview/Operations.java:13: error: cannot access Operation
[mvn] [ERROR] import com.microsoft.azure.management.keyvault.v20180214preview.models.Operation;
[mvn] [ERROR]                                                                       ^
[mvn] [ERROR]   bad source file: /z/work/azure-sdk-for-java/sdk/keyvault/mgmt-v2018_02_14_preview/src/main/java/com/microsoft/azure/management/keyvault/v20180214preview/models/Operation.java
[mvn] [ERROR]     file does not contain class com.microsoft.azure.management.keyvault.v20180214preview.models.Operation
[mvn] [ERROR]     Please remove or make sure it appears in the correct subdirectory of the sourcepath.
[mvn] [ERROR] 
[mvn] [ERROR] Command line was: /usr/lib/jvm/java-8-openjdk-amd64/jre/../bin/javadoc @options @packages
[mvn] [ERROR] 
[mvn] [ERROR] Refer to the generated Javadoc files in '/z/work/azure-sdk-for-java/sdk/keyvault/mgmt-v2018_02_14_preview/target/apidocs' dir.
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

openapi-sdkautomation · 2020-04-07T00:29:16Z

azure-sdk-for-js

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 4ccfff0 with merge commit c27ac3022ace3b96318ab3c8b1742db21bc71ad8. SDK Automation 13.0.17.20200326.3

️✔️@azure/arm-keyvault [Logs] [Preview SDK Changes]

azure-arm-keyvault-1.2.1.tgz

[npmPack] npm WARN lifecycle @azure/[email protected]~prepack: cannot run in wd @azure/[email protected] npm install && npm run build (wd=/z/work/azure-sdk-for-js/sdk/keyvault/arm-keyvault)

openapi-sdkautomation · 2020-04-07T00:29:16Z

azure-sdk-for-net

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 4ccfff0 with merge commit c27ac3022ace3b96318ab3c8b1742db21bc71ad8. SDK Automation 13.0.17.20200326.3
️✔️Microsoft.Azure.Management.KeyVault [Logs] [Preview SDK Changes]
- Microsoft.Azure.Management.KeyVault.3.0.0.nupkg
- Microsoft.Azure.Management.KeyVault.3.0.0.snupkg

azuresdkci · 2020-04-07T00:42:45Z

Can one of the admins verify this patch?

heaths

Can you email the OpenAPI Hub link containing the semantic diff? It's incredibly difficult to see what changed otherwise. See my various emails for 7.1-preview for an example, or just go to OpenAPI Hub and configure it. You may have to do it manually, ie. specify the branch URL and version for each.

heaths · 2020-04-07T00:46:54Z

specification/keyvault/resource-manager/readme.md

 - Microsoft.KeyVault/preview/2018-02-14-preview/providers.json
 ```

+### Tag: package-preview-2020-04


Please use the format as you see above. OpenAPI Hub may create this format, but it's inconsistent with all over services I looked at.

Hi, Please find Open API Hub link below;
#8996

heaths · 2020-04-09T18:11:49Z

...cation/keyvault/resource-manager/Microsoft.KeyVault/preview/2020-04-01-preview/keyvault.json

@@ -0,0 +1,1835 @@
+{


It's difficult to tell what was added or otherwise changed in GitHub this way. Please generate a semantic diff using the following instructions:

Go to https://aka.ms/openapihub

Click on Specs Diff & Change Log.

Select Using OpenAPI Configuration File & Tag.

Set the Source URL to the new or changed readme.md file, e.g. https://github.com/Azure/azure-rest-api-specs/blob/4ccfff0a78bee40837834c3780c2b10d8641bc62/specification/keyvault/resource-manager/readme.md

Select the new version in Tags from Source URL, e.g. "package-preview-2020-04".

Set the Target URL to the old readme.md file, e.g. https://github.com/Azure/azure-rest-api-specs/blob/master/specification/keyvault/resource-manager/readme.md

Select the old version in Tags from Target URL, e.g. "package-2019-09".

Click Compare!.

You can paste the link here. Note: I might have source and target reversed because the labels are not obvious. I've asked the OpenAPI Hub team to change this to just "old" and "new", for example.

KrisBash

Signing off with comment

KrisBash · 2020-04-10T23:11:52Z

...tion/keyvault/resource-manager/Microsoft.KeyVault/preview/2020-04-01-preview/managedHsm.json

+          }
+        ],
+        "responses": {
+          "202": {


Is this the service behavior? While supported, 201/azure-asyncoperation is preferred/more common

fengzhou-msft · 2020-04-22T06:10:36Z

Please fix CI following the doc.

fengzhou-msft · 2020-05-09T05:44:17Z

@riteshchitlangia1 please take a look at the comments.

fengzhou-msft · 2020-08-18T02:44:50Z

@riteshchitlangia1 is this PR still needed?

riteshchitlangia1 · 2020-08-18T20:02:33Z

@riteshchitlangia1 is this PR still needed?

No, this is not needed.

Adding Managed HSM support

4ccfff0

riteshchitlangia1 requested review from heaths and schaabs as code owners April 7, 2020 00:27

openapi-assignment-bot bot assigned fengzhou-msft Apr 7, 2020

heaths requested changes Apr 7, 2020

View reviewed changes

fengzhou-msft added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 9, 2020

heaths requested changes Apr 9, 2020

View reviewed changes

KrisBash approved these changes Apr 10, 2020

View reviewed changes

KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Apr 10, 2020

heaths self-requested a review April 22, 2020 20:34

fengzhou-msft added the Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review label Aug 18, 2020

fengzhou-msft closed this Aug 25, 2020

Adding Managed HSM support #8962

Adding Managed HSM support #8962

Uh oh!

Conversation

riteshchitlangia1 commented Apr 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

azure-pipelines bot commented Apr 7, 2020

Uh oh!

openapi-sdkautomation bot commented Apr 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python

Uh oh!

openapi-sdkautomation bot commented Apr 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-cli-extensions

Uh oh!

openapi-sdkautomation bot commented Apr 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go

Uh oh!

openapi-sdkautomation bot commented Apr 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java

Uh oh!

openapi-sdkautomation bot commented Apr 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js

Uh oh!

openapi-sdkautomation bot commented Apr 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net

Uh oh!

azuresdkci commented Apr 7, 2020

Uh oh!

heaths left a comment

Choose a reason for hiding this comment

Uh oh!

heaths Apr 7, 2020

Choose a reason for hiding this comment

Uh oh!

riteshchitlangia1 Apr 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

heaths Apr 9, 2020

Choose a reason for hiding this comment

Uh oh!

KrisBash left a comment

Choose a reason for hiding this comment

Uh oh!

KrisBash Apr 10, 2020

Choose a reason for hiding this comment

Uh oh!

fengzhou-msft commented Apr 22, 2020

Uh oh!

fengzhou-msft commented May 9, 2020

Uh oh!

fengzhou-msft commented Aug 18, 2020

Uh oh!

riteshchitlangia1 commented Aug 18, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

riteshchitlangia1 commented Apr 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 7, 2020 •

edited

Loading

riteshchitlangia1 Apr 9, 2020 •

edited

Loading