Skip to content

Logic Apps Swagger fixes#8934

Merged
allenjzhang merged 7 commits intoAzure:masterfrom
nidhi-pathak:master
Apr 8, 2020
Merged

Logic Apps Swagger fixes#8934
allenjzhang merged 7 commits intoAzure:masterfrom
nidhi-pathak:master

Conversation

@nidhi-pathak
Copy link
Contributor

This PR includes logic app swagger and corresponding example fixes for the latest stable release.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 3, 2020

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from a3c5519 with merge commit 02489b2. SDK Automation 13.0.17.20200326.3
  • ️✔️sdk/logic/mgmt-v2016_06_01 [Logs]  [Release SDK Changes]
  • ️✔️sdk/logic/mgmt-v2018_07_01_preview [Logs]  [Release SDK Changes]
  • ⚠️sdk/logic/mgmt-v2019_05_01 [Logs]  [Release SDK Changes]
      [mvn] [ERROR] COMPILATION ERROR : 
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/logic/mgmt-v2019_05_01/src/main/java/com/microsoft/azure/management/logic/v2019_05_01/IntegrationServiceEnvironmentNetworkHealths.java:[27,16] cannot find symbol
      [mvn]   symbol:   class Map
      [mvn]   location: interface com.microsoft.azure.management.logic.v2019_05_01.IntegrationServiceEnvironmentNetworkHealths
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/logic/mgmt-v2019_05_01/src/main/java/com/microsoft/azure/management/logic/v2019_05_01/IntegrationServiceEnvironmentNetworkHealths.java:[27,28] cannot find symbol
      [mvn]   symbol:   class IntegrationServiceEnvironmentSubnetNetworkHealthInner
      [mvn]   location: interface com.microsoft.azure.management.logic.v2019_05_01.IntegrationServiceEnvironmentNetworkHealths
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/logic/mgmt-v2019_05_01/src/main/java/com/microsoft/azure/management/logic/v2019_05_01/implementation/IntegrationServiceEnvironmentNetworkHealthsImpl.java:[30,23] cannot find symbol
      [mvn]   symbol:   class Map
      [mvn]   location: class com.microsoft.azure.management.logic.v2019_05_01.implementation.IntegrationServiceEnvironmentNetworkHealthsImpl
      [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-logic: Compilation failure: Compilation failure: 
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/logic/mgmt-v2019_05_01/src/main/java/com/microsoft/azure/management/logic/v2019_05_01/IntegrationServiceEnvironmentNetworkHealths.java:[27,16] cannot find symbol
      [mvn] [ERROR]   symbol:   class Map
      [mvn] [ERROR]   location: interface com.microsoft.azure.management.logic.v2019_05_01.IntegrationServiceEnvironmentNetworkHealths
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/logic/mgmt-v2019_05_01/src/main/java/com/microsoft/azure/management/logic/v2019_05_01/IntegrationServiceEnvironmentNetworkHealths.java:[27,28] cannot find symbol
      [mvn] [ERROR]   symbol:   class IntegrationServiceEnvironmentSubnetNetworkHealthInner
      [mvn] [ERROR]   location: interface com.microsoft.azure.management.logic.v2019_05_01.IntegrationServiceEnvironmentNetworkHealths
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/logic/mgmt-v2019_05_01/src/main/java/com/microsoft/azure/management/logic/v2019_05_01/implementation/IntegrationServiceEnvironmentNetworkHealthsImpl.java:[30,23] cannot find symbol
      [mvn] [ERROR]   symbol:   class Map
      [mvn] [ERROR]   location: class com.microsoft.azure.management.logic.v2019_05_01.implementation.IntegrationServiceEnvironmentNetworkHealthsImpl
      [mvn] [ERROR] -> [Help 1]
      [mvn] [ERROR] 
      [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
      [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
      [mvn] [ERROR] 
      [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
      [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Apr 3, 2020

    azure-cli-extensions - Release

    failed [Logs] [Expand Details]
    • Generate from a3c5519 with merge commit 02489b2. SDK Automation 13.0.17.20200326.3
      [AutoRest] 
      [AutoRest] NO TEST SCENARIO PROVIDED - DEFAULT WILL BE USED
      [AutoRest] ADD FOLLOWING SECTION TO readme.cli.md FILE TO MODIFY IT
      [AutoRest] --------------------------------------------------------
      [AutoRest]   test-scenario:
      [AutoRest]     - name: Create or update a workflow
      [AutoRest]     - name: Create or update an integration account
      [AutoRest]     - name: Create or update a map
      [AutoRest]     - name: Create or update an integration service environment
      [AutoRest]     - name: Create or update schema
      [AutoRest]     - name: Create or update an integration account session
      [AutoRest]     - name: Create or update a partner
      [AutoRest]     - name: Create or update an agreement
      [AutoRest]     - name: Create or update a certificate
      [AutoRest]     - name: Create or update an account assembly
      [AutoRest]     - name: Create or update a batch configuration
      [AutoRest]     - name: Get a repetition request history
      [AutoRest]     - name: Get a request history
      [AutoRest]     - name: Get a scoped repetition
      [AutoRest]     - name: Get a repetition
      [AutoRest]     - name: Get a batch configuration
      [AutoRest]     - name: Gets the integration service environment managed Apis
      [AutoRest]     - name: Get an integration account assembly
      [AutoRest]     - name: Gets the integration service environment network health
      [AutoRest]     - name: Get certificate by name
      [AutoRest]     - name: Get a workflow trigger history
      [AutoRest]     - name: Get agreement by name
      [AutoRest]     - name: Get partner by name
      [AutoRest]     - name: Get an integration account session
      [AutoRest]     - name: Get schema by name
      [AutoRest]     - name: Get a run operation
      [AutoRest]     - name: Get integration service environment by name
      [AutoRest]     - name: Get a workflow run action
      [AutoRest]     - name: Get map by name
      [AutoRest]     - name: Get a workflow trigger
      [AutoRest]     - name: Get a workflow version
      [AutoRest]     - name: Get integration account by name
      [AutoRest]     - name: Get a run for a workflow
      [AutoRest]     - name: Get a workflow
      [AutoRest]     - name: List repetition request history
      [AutoRest]     - name: Gets the integration service environment managed Apis
      [AutoRest]     - name: List a request history
      [AutoRest]     - name: List the scoped repetitions
      [AutoRest]     - name: Gets the integration service environment managed Apis
      [AutoRest]     - name: List repetitions
      [AutoRest]     - name: List integration service environment skus
      [AutoRest]     - name: List batch configurations
      [AutoRest]     - name: List a workflow trigger history
      [AutoRest]     - name: Get certificates by integration account name
      [AutoRest]     - name: List integration account assemblies
      [AutoRest]     - name: Get agreements by integration account name
      [AutoRest]     - name: Get partners by integration account name
      [AutoRest]     - name: Get a list of integration account sessions
      [AutoRest]     - name: Get schemas by integration account name
      [AutoRest]     - name: Get maps by integration account name
      [AutoRest]     - name: List a workflow run actions
      [AutoRest]     - name: List a workflows versions
      [AutoRest]     - name: List workflow triggers
      [AutoRest]     - name: List workflow runs
      [AutoRest]     - name: List integration service environments by resource group name
      [AutoRest]     - name: List integration accounts by resource group name
      [AutoRest]     - name: List all workflows in a resource group
      [AutoRest]     - name: List integration service environments by subscription
      [AutoRest]     - name: List integration accounts by subscription
      [AutoRest]     - name: List all workflows in a subscription
      [AutoRest]     - name: List expression traces for a repetition
      [AutoRest]     - name: Get the callback url for an integration account assembly
      [AutoRest]     - name: Get the content callback url
      [AutoRest]     - name: Get the content callback url
      [AutoRest]     - name: Get the content callback url
      [AutoRest]     - name: Get the callback url for a trigger of a workflow version
      [AutoRest]     - name: Gets the integration service environment managed Apis
      [AutoRest]     - name: Get the content callback url
      [AutoRest]     - name: List expression traces
      [AutoRest]     - name: Resubmit a workflow run based on the trigger history
      [AutoRest]     - name: Restarts an integration service environment
      [AutoRest]     - name: Regenerate access key
      [AutoRest]     - name: Get the callback URL for a trigger
      [AutoRest]     - name: Log a tracked event
      [AutoRest]     - name: Patch an integration service environment
      [AutoRest]     - name: Get Integration Account callback URL
      [AutoRest]     - name: Get trigger schema
      [AutoRest]     - name: List IntegrationAccount callback URL
      [AutoRest]     - name: Set trigger state
      [AutoRest]     - name: Validate a workflow
      [AutoRest]     - name: Reset trigger
      [AutoRest]     - name: Generate an upgraded definition
      [AutoRest]     - name: Run a workflow trigger
      [AutoRest]     - name: Cancel a workflow run
      [AutoRest]     - name: Regenerate the callback URL access key for request triggers
      [AutoRest]     - name: Patch an integration account
      [AutoRest]     - name: Get callback url
      [AutoRest]     - name: Get the swagger for a workflow
      [AutoRest]     - name: Validate a workflow
      [AutoRest]     - name: Disable a workflow
      [AutoRest]     - name: Enable a workflow
      [AutoRest]     - name: Move a workflow
      [AutoRest]     - name: Patch a workflow
      [AutoRest]     - name: Delete a batch configuration
      [AutoRest]     - name: Deletes the integration service environment managed Apis
      [AutoRest]     - name: Delete an integration account assembly
      [AutoRest]     - name: Delete a certificate
      [AutoRest]     - name: Delete an agreement
      [AutoRest]     - name: Delete a partner
      [AutoRest]     - name: Delete an integration account session
      [AutoRest]     - name: Delete a schema by name
      [AutoRest]     - name: Delete an integration account
      [AutoRest]     - name: Delete a map
      [AutoRest]     - name: Delete an integration account
      [AutoRest]     - name: Delete a workflow
      [AutoRest] --------------------------------------------------------
    • logic [Logs
        Error: spawn bundle ENOENT
        Error: spawn rake ENOENT
        Cli has no registered package commands.
        SDK Repository Package Error: HttpError: Resource not accessible by integration, {"name":"HttpError","status":403,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 08 Apr 2020 22:57:39 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"403 Forbidden","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.machine-man-preview; format=json","x-github-request-id":"0480:2ED1:BB51B:1E7EFD:5E8E56E3","x-ratelimit-limit":"12500","x-ratelimit-remaining":"12300","x-ratelimit-reset":"1586388326","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/repos/Azure/azure-cli-extensions/pulls","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.35.0 Node.js/12.16.1 (Linux 5.0; x64)","authorization":"token [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{\"base\":\"master\",\"head\":\"AzureSDKAutomation:sdkAutomation/logic\",\"title\":\"[ReleasePR logic] Logic Apps Swagger fixes\",\"body\":\"Created to release logic.Reopen this PR to release the SDK.\\nIf you can't reopen it, click here to create a new one.\",\"maintainer_can_modify\":false}","request":{"validate":{"base":{"required":true,"type":"string"},"body":{"type":"string"},"draft":{"type":"boolean"},"head":{"required":true,"type":"string"},"maintainer_can_modify":{"type":"boolean"},"owner":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"title":{"required":true,"type":"string"}}}},"documentation_url":"https://developer.github.com/v3/pulls/#create-a-pull-request"}

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Apr 3, 2020

      azure-sdk-for-go - Release

      ⚠️ warning [Logs] [Expand Details]
      • ⚠️ Generate from a3c5519 with merge commit 02489b2. SDK Automation 13.0.17.20200326.3
      • ⚠️logic/mgmt/2016-06-01 [Logs
          No file is changed.
        • ️✔️logic/mgmt/2019-05-01 [Logs]  [Release SDK Changes]
        • ⚠️preview/logic/mgmt/2015-02-01-preview [Logs
            No file is changed.
          • ⚠️preview/logic/mgmt/2015-08-01-preview [Logs
              No file is changed.
            • ⚠️preview/logic/mgmt/2018-07-01-preview [Logs
                No file is changed.

              @openapi-sdkautomation
              Copy link

              openapi-sdkautomation bot commented Apr 3, 2020

              azure-sdk-for-net - Release

              failed [Logs] [Expand Details]
              • Generate from a3c5519 with merge commit 02489b2. SDK Automation 13.0.17.20200326.3
              • Microsoft.Azure.Management.Logic [Logs]  [Release SDK Changes]
                  Failed to create the package Microsoft.Azure.Management.Logic.
                  Error: dotnet msbuild build.proj /t:CreateNugetPackage /p:Scope=logic /v:n /p:SkipTests=true , {} 

                @openapi-sdkautomation
                Copy link

                openapi-sdkautomation bot commented Apr 3, 2020

                azure-sdk-for-js - Release

                ️✔️ succeeded [Logs] [Expand Details]
                • ️✔️ Generate from a3c5519 with merge commit 02489b2. SDK Automation 13.0.17.20200326.3
                • ️✔️@azure/arm-logic [Logs]  [Release SDK Changes]
                  [npmPack] npm WARN lifecycle @azure/arm-logic@6.0.2~prepack: cannot run in wd @azure/arm-logic@6.0.2 npm install && npm run build (wd=/z/work/azure-sdk-for-js/sdk/logic/arm-logic)

                @openapi-sdkautomation
                Copy link

                openapi-sdkautomation bot commented Apr 3, 2020

                azure-sdk-for-python - Release

                - Breaking Change detected in SDK

                ⚠️ warning [Logs] [Expand Details]
                • ⚠️ Generate from a3c5519 with merge commit 02489b2. SDK Automation 13.0.17.20200326.3
                • ⚠️azure-mgmt-logic [Logs]  [Release SDK Changes] Breaking Change Detected
                  [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
                  [build_package]   warnings.warn(msg)
                  [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
                  [build_package]   warnings.warn(msg)
                  [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
                  [breaking_change_setup] Cannot uninstall requirement azure-nspkg, not installed
                  [breaking_change_setup] Command '['/usr/local/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
                  [ChangeLog] Size of delta 23.626% size of original (original: 168878 chars, delta: 39899 chars)
                  [ChangeLog] **Features**
                  [ChangeLog] 
                  [ChangeLog]   - Model Workflow has a new parameter access_control
                  [ChangeLog]   - Model Workflow has a new parameter integration_service_environment
                  [ChangeLog]   - Model Workflow has a new parameter endpoints_configuration
                  [ChangeLog]   - Model IntegrationAccount has a new parameter integration_service_environment
                  [ChangeLog]   - Model IntegrationAccount has a new parameter state
                  [ChangeLog]   - Model WorkflowVersion has a new parameter access_control
                  [ChangeLog]   - Model WorkflowVersion has a new parameter provisioning_state
                  [ChangeLog]   - Model WorkflowVersion has a new parameter endpoints_configuration
                  [ChangeLog]   - Model TrackingEvent has a new parameter record
                  [ChangeLog]   - Model OperationDisplay has a new parameter description
                  [ChangeLog]   - Model WorkflowTriggerHistory has a new parameter scheduled_time
                  [ChangeLog]   - Model Operation has a new parameter properties
                  [ChangeLog]   - Model Operation has a new parameter origin
                  [ChangeLog]   - Added operation group IntegrationServiceEnvironmentNetworkHealthOperations
                  [ChangeLog]   - Added operation group IntegrationServiceEnvironmentManagedApisOperations
                  [ChangeLog]   - Added operation group IntegrationServiceEnvironmentManagedApiOperations
                  [ChangeLog]   - Added operation group IntegrationServiceEnvironmentsOperations
                  [ChangeLog]   - Added operation group IntegrationServiceEnvironmentSkusOperations
                  [ChangeLog] 
                  [ChangeLog] **Breaking changes**
                  [ChangeLog] 
                  [ChangeLog]   - Operation WorkflowsOperations.validate_by_location has a new signature
                  [ChangeLog]   - Operation WorkflowsOperations.move has a new signature
                  [ChangeLog]   - Operation WorkflowsOperations.update has a new signature
                  [ChangeLog]   - Model IntegrationAccount no longer has parameter properties

                @azuresdkci
                Copy link
                Contributor

                Can one of the admins verify this patch?

                @allenjzhang
                Copy link
                Contributor

                allenjzhang commented Apr 3, 2020

                Code style issues has been found in PR. Please follow https://aka.ms/AA6h31t to fix the issues. Thanks! #Resolved

                @azure-pipelines
                Copy link

                Azure Pipelines successfully started running 1 pipeline(s).

                @azure-pipelines
                Copy link

                Azure Pipelines successfully started running 1 pipeline(s).

                @nidhi-pathak
                Copy link
                Contributor Author

                Code style issues has been found in PR. Please follow https://aka.ms/AA6h31t to fix the issues. Thanks!

                @nidhi-pathak nidhi-pathak reopened this Apr 3, 2020
                @azure-pipelines
                Copy link

                Azure Pipelines successfully started running 1 pipeline(s).

                @bquantump
                Copy link
                Member

                In Workflow_Update via a patch, the workflow should be removed as parameter as it is is not supported via a patch. Only ARM parameters are supported via a patch per discussion with Rohitha.

                @ChenTanyi ChenTanyi added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 7, 2020
                @azure-pipelines
                Copy link

                Azure Pipelines successfully started running 1 pipeline(s).

                @azure-pipelines
                Copy link

                Azure Pipelines successfully started running 1 pipeline(s).

                @allenjzhang allenjzhang merged commit 02489b2 into Azure:master Apr 8, 2020
                00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
                * Logic Apps Swagger fixes
                
                * Logic Apps Swagger fixes
                
                * Logic apps swagger fix addressed CR comments.
                
                * Logic apps swagger fix addressed CR comments II.
                
                * Logic apps swagger fix addressed CR comments III.
                
                * Logic apps swagger fix addressed CR comments IV
                
                Co-authored-by: Nidhi Pathak <npathak@microsoft.com>
                Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

                Labels

                WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required

                Projects

                None yet

                Development

                Successfully merging this pull request may close these issues.

                6 participants