-
Notifications
You must be signed in to change notification settings - Fork 5.6k
add linked workspace endpoints(Ready for review) #8918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 17 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
0b0aa1d
add linked workspace endpoints
RichardLi1437 581191c
add comma
RichardLi1437 acbebef
fix swagger
RichardLi1437 54993fa
fix check
RichardLi1437 c4a058a
typo
RichardLi1437 5546928
fix1
RichardLi1437 4bb407f
fix2
RichardLi1437 c75f92d
fix2
RichardLi1437 83b22d7
add delink
RichardLi1437 3d71103
fix3
RichardLi1437 8dae84c
add getLinkedWorkspace example
RichardLi1437 7ba5335
add example
RichardLi1437 0f1d15e
add 404 response example
RichardLi1437 a3f173a
fix4
RichardLi1437 f3a884d
add linked workspace examples
RichardLi1437 cbda199
add examples
RichardLi1437 37067e1
remove trailing whitespaces
RichardLi1437 a688022
remove 404
RichardLi1437 cd46fd0
remove 404
RichardLi1437 57f4b0c
remove 404
RichardLi1437 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -413,6 +413,7 @@ deletedstorage | |
| deletefailed | ||
| deleteissuers | ||
| deletesas | ||
| delink | ||
| demorun | ||
| denylist | ||
| deployer | ||
|
|
||
27 changes: 27 additions & 0 deletions
27
...r/Microsoft.MachineLearningServices/stable/2020-03-01/examples/createLinkedWorkspace.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "00000000-1111-2222-3333-444444444444", | ||
| "resourceGroupName": "resourceGroup-1234", | ||
| "workspaceName": "workspace-123", | ||
| "parameters": { | ||
| "linkName": "link-12", | ||
| "resourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/resourceGroup-4321/providers/Microsoft.Synapse/workspaces/linkedWorkspace-1234", | ||
| "userAssignedIdentityResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/resourceGroup-4321/providers/Microsoft.ManagedIdentity/userAssignedIdentities/uai123" | ||
| } | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "linkName": "link-12", | ||
| "linkType": "Synapse", | ||
| "subscriptionId": "00000000-1111-2222-3333-444444444444", | ||
| "resourceGroupName": "resourceGroup-4321", | ||
| "providerNamespace": "Microsoft.Synapse", | ||
| "resourceType": "workspaces", | ||
| "workspaceName": "linkedWorkspace-1234", | ||
| "userAssignedIdentityResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/resourceGroup-4321/providers/Microsoft.ManagedIdentity/userAssignedIdentities/uai123", | ||
| "resourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/resourceGroup-4321/providers/Microsoft.Synapse/workspaces/linkedWorkspace-1234" | ||
| } | ||
| } | ||
| } | ||
| } |
12 changes: 12 additions & 0 deletions
12
...r/Microsoft.MachineLearningServices/stable/2020-03-01/examples/deleteLinkedWorkspace.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "00000000-1111-2222-3333-444444444444", | ||
| "resourceGroupName": "resourceGroup-1234", | ||
| "workspaceName": "workspace-123", | ||
| "linkName": "link-12" | ||
| }, | ||
| "responses": { | ||
| "200": {}, | ||
| "204": {} | ||
| } | ||
| } |
31 changes: 31 additions & 0 deletions
31
...ager/Microsoft.MachineLearningServices/stable/2020-03-01/examples/getLinkedWorkspace.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "00000000-1111-2222-3333-444444444444", | ||
| "resourceGroupName": "resourceGroup-1234", | ||
| "workspaceName": "workspace-123", | ||
| "linkName": "link-12" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "linkName": "link-12", | ||
| "linkType": "Synapse", | ||
| "subscriptionId": "00000000-1111-2222-3333-444444444444", | ||
| "resourceGroupName": "resourceGroup-4321", | ||
| "providerNamespace": "Microsoft.Synapse", | ||
| "resourceType": "workspaces", | ||
| "workspaceName": "linkedWorkspace-1234", | ||
| "userAssignedIdentityResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/resourceGroup-4321/providers/Microsoft.ManagedIdentity/userAssignedIdentities/uai123", | ||
| "resourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/resourceGroup-4321/providers/Microsoft.Synapse/workspaces/linkedWorkspace-1234" | ||
| } | ||
| }, | ||
| "404": { | ||
| "body": { | ||
| "error": { | ||
| "code": "UserError", | ||
| "message": "There is no such a linked workspace link-12 in AML workspace workspace-123" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
36 changes: 36 additions & 0 deletions
36
...er/Microsoft.MachineLearningServices/stable/2020-03-01/examples/listLinkedWorkspaces.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "00000000-1111-2222-3333-444444444444", | ||
| "resourceGroupName": "resourceGroup-1234", | ||
| "workspaceName": "workspace-123", | ||
| "link-resourceGroup": "linkRg-123" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": [ | ||
| { | ||
| "linkName": "link-12", | ||
| "linkType": "Synapse", | ||
| "subscriptionId": "00000000-1111-2222-3333-444444444444", | ||
| "resourceGroupName": "linkRg-123", | ||
| "providerNamespace": "Microsoft.Synapse", | ||
| "resourceType": "workspaces", | ||
| "workspaceName": "linkedWorkspace-1234", | ||
| "userAssignedIdentityResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/resourceGroup-4321/providers/Microsoft.ManagedIdentity/userAssignedIdentities/uai123", | ||
| "resourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/linkRg-123/providers/Microsoft.Synapse/workspaces/linkedWorkspace-1234" | ||
| }, | ||
| { | ||
| "linkName": "link-13", | ||
| "linkType": "Synapse", | ||
| "subscriptionId": "00000000-1111-2222-3333-444444444444", | ||
| "resourceGroupName": "linkRg-123", | ||
| "providerNamespace": "Microsoft.Synapse", | ||
| "resourceType": "workspaces", | ||
| "workspaceName": "linkedWorkspace-4321", | ||
| "userAssignedIdentityResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/resourceGroup-4321/providers/Microsoft.ManagedIdentity/userAssignedIdentities/uai321", | ||
| "resourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/linkRg-123/providers/Microsoft.Synapse/workspaces/linkedWorkspace-4321" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
34 changes: 34 additions & 0 deletions
34
...r/Microsoft.MachineLearningServices/stable/2020-03-01/examples/updateLinkedWorkspace.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "00000000-1111-2222-3333-444444444444", | ||
| "resourceGroupName": "resourceGroup-1234", | ||
| "workspaceName": "workspace-123", | ||
| "linkName": "link-12", | ||
| "parameters": { | ||
| "userAssignedIdentityResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/resourceGroup-4321/providers/Microsoft.ManagedIdentity/userAssignedIdentities/uai124" | ||
| } | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "linkName": "link-12", | ||
| "linkType": "Synapse", | ||
| "subscriptionId": "00000000-1111-2222-3333-444444444444", | ||
| "resourceGroupName": "resourceGroup-4321", | ||
| "providerNamespace": "Microsoft.Synapse", | ||
| "resourceType": "workspaces", | ||
| "workspaceName": "linkedWorkspace-1234", | ||
| "userAssignedIdentityResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/resourceGroup-4321/providers/Microsoft.ManagedIdentity/userAssignedIdentities/uai124", | ||
| "resourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/resourceGroup-4321/providers/Microsoft.Synapse/workspaces/linkedWorkspace-1234" | ||
| } | ||
| }, | ||
| "404": { | ||
| "body": { | ||
| "error": { | ||
| "code": "UserError", | ||
| "message": "There is no such a linked workspace link-12 in AML workspace workspace-123" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not an RPC-compliant resource payload. You should have a top level
id,'name,typeproperty and all the resource properties should go into thepropertiesproperty. Please take a look at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/resource-api-reference.md#resource-api-reference.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LinkedWorkspace is not yet a resource.