Managed Instance failover swagger#8911
Merged
PhoenixHe-NV merged 10 commits intoAzure:masterfrom Jun 12, 2020
Merged
Conversation
|
Azure Pipelines successfully started running 1 pipeline(s). |
5 tasks
azure-sdk-for-net - Release
|
azure-sdk-for-python - Release
|
azure-sdk-for-java - Release
|
azure-sdk-for-js - Release
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
Contributor
|
Can one of the admins verify this patch? |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Apr 1, 2020
Closed
|
Azure Pipelines successfully started running 1 pipeline(s). |
milanbrkic-ms
changed the title
|
Pull request contains merge conflicts. |
|
Comment was made before the most recent commit for PR 8911 in repo Azure/azure-rest-api-specs |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
API reviews are a weekly rotation described here. Please reach out to this week or next week's reviewer |
allenjzhang
suggested changes
May 29, 2020
...n/sql/resource-manager/Microsoft.Sql/preview/2019-06-01-preview/FailoverManagedInstance.json
Outdated
Show resolved
Hide resolved
| "type": "string", | ||
| "x-ms-parameter-location": "method" | ||
| }, | ||
| "ServerNameParameter": { |
Contributor
There was a problem hiding this comment.
There are many unused and duplicate definitions here. They should be removed. I looked over other json in SQL, seems there are copy and paste since they exhibit same pattern. This creates problems in our codegen(autorest) and producing duplicate class schemas.
I opened an issue on our side to work with you to clean up these swaggers in the future.
| "x-ms-parameter-location": "method" | ||
| } | ||
| }, | ||
| "securityDefinitions": { |
Contributor
There was a problem hiding this comment.
nit: We would like to standardize security and securityDefinitions at beginning of the file to create consistency layout and ease of review.
Contributor
|
@MilanBrkicFON, pretty straightforward PR, though I have noticed consistent pattern issues with SQL swagger files. Please take a look at these easy fixes. Will loop back to work with you to cleanup if these are manually created. If these are generated, please incorporate feedback and make appropriate changes to generate higher quality swagger in the future. BTW, this is SDK team review. As per policy, ARM folks need to sign off for new APIs. Giving the low complexity of this PR, it should be a quick sign off. Please engage ARM folks per @pilor's instruction. |
allenjzhang
reviewed
May 29, 2020
...n/sql/resource-manager/Microsoft.Sql/preview/2019-06-01-preview/FailoverManagedInstance.json
Outdated
Show resolved
Hide resolved
Contributor
|
/azp run automation - sdk |
|
Azure Pipelines successfully started running 1 pipeline(s). |
[Staging] Swagger Validation Report️~[Staging] BreakingChange [Detail]Posted by Swagger Pipeline |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@allenjzhang Thanks for the review. I think I've addressed all of your comments. Can you please check again? |
Contributor
Author
|
/azp run automation - sdk |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pilor
added
ARMSignedOff
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
milanbrkic-ms
commented
Jun 4, 2020
| "$ref": "../../../../../common-types/resource-management/v1/types.json#/parameters/ResourceGroupNameParameter" | ||
| }, | ||
| { | ||
| "$ref": "#/parameters/SubscriptionIdParameter" |
Contributor
Author
There was a problem hiding this comment.
I was getting
The subscription ID that identifies an Azure subscription.
, ---
The ID of the target subscription.
).
Error: '$.parameters.SubscriptionIdParameter.description' has incompatible values (---
The subscription ID that identifies an Azure subscription.
, ---
The ID of the target subscription.
).
when I referenced common-types/resource-management/v1/types.json#/parameters/SubscriptionIdParameter and didn't know how to fix that.
Contributor
There was a problem hiding this comment.
Can you try update this to common-type AND remove the subscription id definition below on Line 95? I think that should do it. In the meantime, I remove the change requested status. Thx
Contributor
Author
There was a problem hiding this comment.
I did try, but I was getting the error when execute autorest specification\sql\resource-manager\readme.md --azure-validator=true (I pasted error in comment above).
Can we just leave it as is? I would really appreciate to merge this changes, so I could continue with client SDKs
allenjzhang
approved these changes
Jun 8, 2020
Contributor
|
/azp run automation - sdk |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@pilor @allenjzhang @NullMDR Can someone merge this PR please? I am not authorized to do it. |
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
* Failover managed instance API docs * fix parameters * typo fix * fix version * changes in readme.md * Removed unused parameters and rearranged little bit * fixes Co-authored-by: Milan Brkic <mibrkic@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.