-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Feature/alshulma/update stable version #8884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
allenjzhang
merged 49 commits into
Azure:master
from
alshulma:feature/alshulma/UpdateStableVersion
Jun 30, 2020
Merged
Feature/alshulma/update stable version #8884
allenjzhang
merged 49 commits into
Azure:master
from
alshulma:feature/alshulma/UpdateStableVersion
Jun 30, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You don't have permission to trigger SDK Automation. |
Contributor
|
Can one of the admins verify this patch? |
…perties to a separate object definition
"discriminator": "kind", in AlertRuleKind and DataConnectorKind
Kind discriminator required
…e using definitions" This reverts commit c24e7d0. Revert "extracted MicrosoftSecurityProductName to enum" This reverts commit 2389fc9. Revert "extracted MicrosoftSecurityIncidentCreationAlertRuleTemplateCommonProperties to a separate object definition" This reverts commit 7228009. Revert "fix incorrect hierarchy in MicrosoftSecurityIncidentCreationAlertRuleTemplate" This reverts commit dbf12a9. revert 03ace77 revert 1cc27d5 Revert "Fixed Analytics issues + CloudError from common" This reverts commit 39bffde. Revert Analytics Changes
This reverts commit abee5fb.
…et on the using definitions"" This reverts commit 81054a9.
add "format": "int32" to integer types
Change DataConnectorKind to enum and fix DataConnector to use it in the property
Change SettingsKind to enum and use in the Settings properties.
79f6847 to
9ba3fa0
Compare
markcowl
approved these changes
Jun 30, 2020
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure CLI Extension Generation - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
* Update stable version * Some updates * Another change * Remove objects * Removed IncidentConfiguration * Fix issues * revert preview * Add objects * Add Entity * Add more * EntityCommonProperties * Changes * prettier * Remove * Make pretty * Remove unneeded definitions * Update incidents definition and examples * Update CreateOfficeDataConnetor.json delete read only from data connector examples * Update CreateOfficeDataConnetor.json Delete read only from data connector create * Update CreateFusionAlertRule.json Change "true" to true * Update CreateBookmark.json remove type, name, id since are read only * Update CreateActionOfAlertRule.json remove name, id and type from example since are read only * Update CreateBookmark.json delete read only email and names * Update CreateBookmark.json remove , * Update operationId of GET on a single incident comment Co-authored-by: Mark Cowlishaw <[email protected]> * Update SecurityInsights.json Add "description": "OK, Operation successfully completed", * Update SecurityInsights.json Remove redundant , * Fixed Analytics issues + CloudError from common * More fixes to the Analytics sections * fixed AlertRuleKind after referencing to it - changed to string * fix incorrect hierarchy in MicrosoftSecurityIncidentCreationAlertRuleTemplate * extracted MicrosoftSecurityIncidentCreationAlertRuleTemplateCommonProperties to a separate object definition * extracted MicrosoftSecurityProductName to enum * Update SecurityInsights.json "discriminator": "kind", in AlertRuleKind and DataConnectorKind * Update SecurityInsights.json Kind discriminator required * remove discriminator and required from enum - it is set on the using definitions * Revert "remove discriminator and required from enum - it is set on the using definitions" This reverts commit c24e7d0. Revert "extracted MicrosoftSecurityProductName to enum" This reverts commit 2389fc9. Revert "extracted MicrosoftSecurityIncidentCreationAlertRuleTemplateCommonProperties to a separate object definition" This reverts commit 7228009. Revert "fix incorrect hierarchy in MicrosoftSecurityIncidentCreationAlertRuleTemplate" This reverts commit dbf12a9. revert 03ace77 revert 1cc27d5 Revert "Fixed Analytics issues + CloudError from common" This reverts commit 39bffde. Revert Analytics Changes * revert the discriminator kind change * Revert "revert the discriminator kind change" This reverts commit abee5fb. * Revert "Revert "remove discriminator and required from enum - it is set on the using definitions"" This reverts commit 81054a9. * Update SecurityInsights.json add "format": "int32" to integer types * DataConnectorKind to enum Change DataConnectorKind to enum and fix DataConnector to use it in the property * SettingsKind to enum Change SettingsKind to enum and use in the Settings properties. * Remove double allOff in connectors * Fix connectors inner properties * fix scheduled alert rule template properties * fixed nested all of issue in analytic rules templates * Fix inner allof in connectors properties Co-authored-by: Itai Yankelevsky <[email protected]> Co-authored-by: ofshomro <[email protected]> Co-authored-by: ityankel <[email protected]> Co-authored-by: Mark Cowlishaw <[email protected]> Co-authored-by: Laith Hisham <[email protected]> Co-authored-by: Ofir Shomron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Approved-BreakingChange
DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.