Skip to content

Conversation

@alshulma
Copy link
Contributor

@alshulma alshulma commented Mar 31, 2020

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

You don't have permission to trigger SDK Automation.
Please add yourself to Azure group from opensource portal if you are MSFT employee,
or please ask reviewer to add comment *** /openapibot sdkautomation ***.
Please ask [email protected] (or NullMDR in github) for additional help.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@alshulma alshulma closed this Mar 31, 2020
@alshulma alshulma reopened this Mar 31, 2020
@alshulma alshulma closed this Mar 31, 2020
@alshulma alshulma reopened this Mar 31, 2020
@alshulma alshulma closed this Mar 31, 2020
@alshulma alshulma reopened this Mar 31, 2020
@alshulma alshulma closed this Mar 31, 2020
@alshulma alshulma reopened this Mar 31, 2020
@alshulma alshulma closed this Mar 31, 2020
@alshulma alshulma reopened this Mar 31, 2020
@alshulma alshulma closed this Mar 31, 2020
@alshulma alshulma reopened this Mar 31, 2020
@alshulma alshulma closed this Mar 31, 2020
@alshulma alshulma reopened this Mar 31, 2020
@alshulma alshulma closed this Mar 31, 2020
laithhisham and others added 18 commits June 3, 2020 16:40
"discriminator": "kind", in AlertRuleKind and DataConnectorKind
Kind discriminator required
…e using definitions"

This reverts commit c24e7d0.

Revert "extracted MicrosoftSecurityProductName to enum"

This reverts commit 2389fc9.

Revert "extracted MicrosoftSecurityIncidentCreationAlertRuleTemplateCommonProperties to a separate object definition"

This reverts commit 7228009.

Revert "fix incorrect hierarchy in MicrosoftSecurityIncidentCreationAlertRuleTemplate"

This reverts commit dbf12a9.

revert 03ace77

revert 1cc27d5

Revert "Fixed Analytics issues + CloudError from common"

This reverts commit 39bffde.

Revert Analytics Changes
…et on the using definitions""

This reverts commit 81054a9.
add "format": "int32" to integer types
Change DataConnectorKind to enum and fix DataConnector to use it in the property
Change SettingsKind to enum and use in the Settings properties.
@laithhisham laithhisham force-pushed the feature/alshulma/UpdateStableVersion branch from 79f6847 to 9ba3fa0 Compare June 21, 2020 18:22
@markcowl markcowl added Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 and removed Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review labels Jun 30, 2020
@allenjzhang allenjzhang merged commit 847615b into Azure:master Jun 30, 2020
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 30, 2020

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 30, 2020

Azure CLI Extension Generation - Release

  • Installation instruction for service securityinsight [Preview Changes]
    az extension add --source=https://sdkautomation.blob.core.windows.net/sdkautomation-pipeline/Azure/azure-rest-api-specs/8884/azure-cli-extensions/Azure/azure-cli-extensions/securityinsight/sentinel-0.1.0-py3-none-any.whl
️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 999a343 with merge commit 847615b. Azure CLI Automation 13.0.17.20200619.4
    [AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'AlertsDataTypeOfDataConnector-alerts' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
    [AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'AwsCloudTrailDataConnectorDataTypes-logs' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
    [AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'OfficeDataConnectorDataTypes-exchange' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
    [AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'OfficeDataConnectorDataTypes-sharePoint' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
    [AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'TIDataConnectorDataTypes-indicators' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ActionsList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AlertRuleTemplatesList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AlertRulesList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'BookmarkList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'CloudError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'DataConnectorList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'IncidentCommentList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'IncidentList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'OfficeConsentList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationsList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceWithEtag' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorAdditionalInfo' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/PropertyRedeclarationWarning): Schema 'MCASDataConnectorDataTypes' has a property 'alerts' that is already declared the parent schema 'AlertsDataTypeOfDataConnector' but isn't significantly different. The property has been removed from MCASDataConnectorDataTypes
    [AutoRest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
    [AutoRest] 
    [AutoRest] NO TEST SCENARIO PROVIDED - DEFAULT WILL BE USED
    [AutoRest] ADD FOLLOWING SECTION TO readme.cli.md FILE TO MODIFY IT
    [AutoRest] --------------------------------------------------------
    [AutoRest]   test-scenario:
    [AutoRest]     - name: /Actions/get/Get all actions of alert rule.
    [AutoRest]     - name: /AlertRuleTemplates/get/Get alert rule template by Id.
    [AutoRest]     - name: /AlertRuleTemplates/get/Get all alert rule templates.
    [AutoRest]     - name: /AlertRules/put/Creates or updates a Fusion alert rule.
    [AutoRest]     - name: /AlertRules/put/Creates or updates a MicrosoftSecurityIncidentCreation rule.
    [AutoRest]     - name: /AlertRules/put/Creates or updates a Scheduled alert rule.
    [AutoRest]     - name: /AlertRules/put/Creates or updates an action of alert rule.
    [AutoRest]     - name: /AlertRules/get/Get a Fusion alert rule.
    [AutoRest]     - name: /AlertRules/get/Get a MicrosoftSecurityIncidentCreation rule.
    [AutoRest]     - name: /AlertRules/get/Get a Scheduled alert rule.
    [AutoRest]     - name: /AlertRules/get/Get all alert rules.
    [AutoRest]     - name: /AlertRules/get/Get an action of alert rule.
    [AutoRest]     - name: /Bookmarks/put/Creates or updates a bookmark.
    [AutoRest]     - name: /Bookmarks/get/Get a bookmark.
    [AutoRest]     - name: /Bookmarks/get/Get all bookmarks.
    [AutoRest]     - name: /DataConnectors/put/Creates or updates an Office365 data connector.
    [AutoRest]     - name: /DataConnectors/get/Get a ASC data connector.
    [AutoRest]     - name: /DataConnectors/get/Get a MCAS data connector.
    [AutoRest]     - name: /DataConnectors/get/Get a MDATP data connector
    [AutoRest]     - name: /DataConnectors/get/Get a TI data connector.
    [AutoRest]     - name: /DataConnectors/get/Get all data connectors.
    [AutoRest]     - name: /DataConnectors/get/Get an AAD data connector.
    [AutoRest]     - name: /DataConnectors/get/Get an AATP data connector.
    [AutoRest]     - name: /DataConnectors/get/Get an AwsCloudTrail data connector.
    [AutoRest]     - name: /DataConnectors/get/Get an Office365 data connector.
    [AutoRest]     - name: /IncidentComments/put/Creates an incident comment.
    [AutoRest]     - name: /IncidentComments/get/Get all incident comments.
    [AutoRest]     - name: /IncidentComments/get/Get an incident comment.
    [AutoRest]     - name: /Incidents/put/Creates or updates an incident.
    [AutoRest]     - name: /Incidents/get/Get all incidents.
    [AutoRest]     - name: /Incidents/get/Get an incident.
    [AutoRest]     - name: /AlertRules/delete/Delete an alert rule.
    [AutoRest]     - name: /AlertRules/delete/Delete an action of alert rule.
    [AutoRest]     - name: /Bookmarks/delete/Delete a bookmark.
    [AutoRest]     - name: /DataConnectors/delete/Delete an Office365 data connector.
    [AutoRest]     - name: /Incidents/delete/Delete an incident.
    [AutoRest] --------------------------------------------------------
  • ️✔️securityinsight [View full logs]  [Release Azure CLI Changes]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 30, 2020

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
* Update stable version

* Some updates

* Another change

* Remove objects

* Removed IncidentConfiguration

* Fix issues

* revert preview

* Add objects

* Add Entity

* Add more

* EntityCommonProperties

* Changes

* prettier

* Remove

* Make pretty

* Remove unneeded definitions

* Update incidents definition and examples

* Update CreateOfficeDataConnetor.json

delete read only from data connector examples

* Update CreateOfficeDataConnetor.json

Delete read only from data connector create

* Update CreateFusionAlertRule.json

Change "true" to true

* Update CreateBookmark.json

remove type, name, id since are read only

* Update CreateActionOfAlertRule.json

remove name, id and type from example since are read only

* Update CreateBookmark.json

delete read only email and names

* Update CreateBookmark.json

remove ,

* Update operationId of GET on a single incident comment

Co-authored-by: Mark Cowlishaw <[email protected]>

* Update SecurityInsights.json

Add "description": "OK, Operation successfully completed",

* Update SecurityInsights.json

Remove redundant ,

* Fixed Analytics issues + CloudError from common

* More fixes to the Analytics sections

* fixed AlertRuleKind after referencing to it - changed to string

* fix incorrect hierarchy in MicrosoftSecurityIncidentCreationAlertRuleTemplate

* extracted MicrosoftSecurityIncidentCreationAlertRuleTemplateCommonProperties to a separate object definition

* extracted MicrosoftSecurityProductName to enum

* Update SecurityInsights.json

"discriminator": "kind", in AlertRuleKind and DataConnectorKind

* Update SecurityInsights.json

Kind discriminator required

* remove discriminator and required from enum - it is set on the using definitions

* Revert "remove discriminator and required from enum - it is set on the using definitions"

This reverts commit c24e7d0.

Revert "extracted MicrosoftSecurityProductName to enum"

This reverts commit 2389fc9.

Revert "extracted MicrosoftSecurityIncidentCreationAlertRuleTemplateCommonProperties to a separate object definition"

This reverts commit 7228009.

Revert "fix incorrect hierarchy in MicrosoftSecurityIncidentCreationAlertRuleTemplate"

This reverts commit dbf12a9.

revert 03ace77

revert 1cc27d5

Revert "Fixed Analytics issues + CloudError from common"

This reverts commit 39bffde.

Revert Analytics Changes

* revert the discriminator kind change

* Revert "revert the discriminator kind change"

This reverts commit abee5fb.

* Revert "Revert "remove discriminator and required from enum - it is set on the using definitions""

This reverts commit 81054a9.

* Update SecurityInsights.json

add "format": "int32" to integer types

* DataConnectorKind to enum

Change DataConnectorKind to enum and fix DataConnector to use it in the property

* SettingsKind to enum

Change SettingsKind to enum and use in the Settings properties.

* Remove double allOff in connectors

* Fix connectors inner properties

* fix scheduled alert rule template properties

* fixed nested all of issue in analytic rules templates

* Fix inner allof in connectors properties

Co-authored-by: Itai Yankelevsky <[email protected]>
Co-authored-by: ofshomro <[email protected]>
Co-authored-by: ityankel <[email protected]>
Co-authored-by: Mark Cowlishaw <[email protected]>
Co-authored-by: Laith Hisham <[email protected]>
Co-authored-by: Ofir Shomron <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Development

Successfully merging this pull request may close these issues.