Skip to content

not setting the identity property of Resource as readonly#8861

Merged
ArcturusZhang merged 1 commit into
masterfrom
update_mlservices_identity
Mar 30, 2020
Merged

not setting the identity property of Resource as readonly#8861
ArcturusZhang merged 1 commit into
masterfrom
update_mlservices_identity

Conversation

@iscai-msft
Copy link
Copy Markdown
Contributor

@iscai-msft iscai-msft commented Mar 27, 2020

This caused an issue, since Workspace was being used as an input parameter, and the type property of its identity property is required to pass, but since identity was set to readonly, type was not being passed.

@iscai-msft iscai-msft requested a review from RodgeFu March 27, 2020 21:21
@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Mar 27, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@iscai-msft iscai-msft requested a review from lmazuel March 27, 2020 21:22
@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Mar 27, 2020 •
edited
Loading

azure-sdk-for-python - Release

- Breaking Change detected in SDK

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 587cd2b with merge commit 0d7c1e2. SDK Automation 13.0.17.20200326.3
  • ⚠️azure-mgmt-machinelearningservices [Logs]  [Release SDK Changes] Breaking Change Detected
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[breaking_change_setup] Cannot uninstall requirement azure-nspkg, not installed
[breaking_change_setup] Command '['/usr/local/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
[ChangeLog] Size of delta 35.371% size of original (original: 50293 chars, delta: 17789 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog]   - Model Workspace has a new parameter encryption
[ChangeLog]   - Model Workspace has a new parameter service_provisioned_resource_group
[ChangeLog]   - Model Workspace has a new parameter image_build_compute
[ChangeLog]   - Model Workspace has a new parameter shared_private_link_resources
[ChangeLog]   - Model Workspace has a new parameter sku
[ChangeLog]   - Model Workspace has a new parameter allow_public_access_when_behind_vnet
[ChangeLog]   - Model Workspace has a new parameter private_link_count
[ChangeLog]   - Model Workspace has a new parameter private_endpoint_connections
[ChangeLog]   - Model Workspace has a new parameter hbi_workspace
[ChangeLog]   - Model VirtualMachineSize has a new parameter gpus
[ChangeLog]   - Model AmlComputeProperties has a new parameter remote_login_port_public_access
[ChangeLog]   - Model ComputeResource has a new parameter sku
[ChangeLog]   - Model WorkspaceUpdateParameters has a new parameter sku
[ChangeLog]   - Model Resource has a new parameter sku
[ChangeLog]   - Added operation group PrivateEndpointConnectionsOperations
[ChangeLog]   - Added operation group PrivateLinkResourcesOperations
[ChangeLog]   - Added operation group QuotasOperations
[ChangeLog]   - Added operation group AzureMachineLearningWorkspacesOperationsMixin
[ChangeLog]   - Added operation group WorkspaceFeaturesOperations
[ChangeLog] 
[ChangeLog] **Breaking changes**
[ChangeLog] 
[ChangeLog]   - Model AmlComputeNodeInformation has a new signature

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Mar 27, 2020 •
edited
Loading

azure-cli-extensions - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Mar 27, 2020 •
edited
Loading

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Mar 27, 2020 •
edited
Loading

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Mar 27, 2020 •
edited
Loading

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 587cd2b with merge commit 0d7c1e2. SDK Automation 13.0.17.20200326.3
  • ️✔️Microsoft.Azure.Management.MachineLearningServices [Logs]  [Release SDK Changes]
      No Artifact Generated.

    @openapi-sdkautomation
    Copy link
    Copy Markdown

    openapi-sdkautomation Bot commented Mar 27, 2020 •
    edited
    Loading

    azure-sdk-for-js - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from 587cd2b with merge commit 0d7c1e2. SDK Automation 13.0.17.20200326.3
    • ️✔️@azure/arm-machinelearningservices [Logs]  [Release SDK Changes] 
      [npmPack] npm WARN lifecycle @azure/arm-machinelearningservices@3.0.0~prepack: cannot run in wd @azure/arm-machinelearningservices@3.0.0 npm install && npm run build (wd=/z/work/azure-sdk-for-js/sdk/machinelearningservices/arm-machinelearningservices)

    @azuresdkci
    Copy link
    Copy Markdown
    Contributor

    azuresdkci commented Mar 27, 2020

    Can one of the admins verify this patch?

    This was referenced Mar 27, 2020
    Closed
    Closed
    Closed
    RodgeFu
    RodgeFu approved these changes Mar 28, 2020
    View reviewed changes
    Copy link
    Copy Markdown
    Member

    @RodgeFu RodgeFu left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    :shipit:

    @ArcturusZhang ArcturusZhang merged commit 0d7c1e2 into master Mar 30, 2020
    @ArcturusZhang ArcturusZhang deleted the update_mlservices_identity branch March 30, 2020 03:14
    00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
    @iscai-msft @00Kai0
    not setting the identity property of Resource as readonly (Azure#8861)
    448dfb6
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @RodgeFu RodgeFu RodgeFu approved these changes

    @ArcturusZhang ArcturusZhang ArcturusZhang approved these changes

    @lmazuel lmazuel Awaiting requested review from lmazuel

    +1 more reviewer

    @zhaomuzhi zhaomuzhi zhaomuzhi approved these changes

    Reviewers whose approvals may not affect merge requirements

    Assignees

    @ArcturusZhang ArcturusZhang

    Labels

    None yet

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    5 participants

    @iscai-msft @azuresdkci @RodgeFu @zhaomuzhi @ArcturusZhang