Skip to content

Add readonly property - reference to private link scoped resources#8843

Merged
mmyyrroonn merged 1 commit into
Azure:masterfrom
arolshan:microsoft.insights-privatelink-scoped-resources
Mar 27, 2020
Merged

Add readonly property - reference to private link scoped resources#8843
mmyyrroonn merged 1 commit into
Azure:masterfrom
arolshan:microsoft.insights-privatelink-scoped-resources

Conversation

@arolshan
Copy link
Copy Markdown
Contributor

@arolshan arolshan commented Mar 26, 2020 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Mar 26, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Mar 26, 2020 •
edited
Loading

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Mar 26, 2020 •
edited
Loading

azure-cli-extensions - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Mar 26, 2020 •
edited
Loading

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 1b5980a with merge commit 4cd7471. SDK Automation 13.0.17.20200326.3
  • ️✔️@azure/arm-appinsights [Logs]  [Release SDK Changes] 
    [npmPack] npm WARN lifecycle @azure/arm-appinsights@2.1.0~prepack: cannot run in wd @azure/arm-appinsights@2.1.0 npm install && npm run build (wd=/z/work/azure-sdk-for-js/sdk/applicationinsights/arm-appinsights)

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Mar 26, 2020 •
edited
Loading

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 1b5980a with merge commit 4cd7471. SDK Automation 13.0.17.20200326.3
  • ️✔️azure-mgmt-applicationinsights [Logs]  [Release SDK Changes] 
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[breaking_change_setup] Cannot uninstall requirement azure-nspkg, not installed
[breaking_change_setup] Command '['/usr/local/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
[ChangeLog] Size of delta 2.535% size of original (original: 50134 chars, delta: 1271 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog]   - Model ApplicationInsightsComponent has a new parameter retention_in_days
[ChangeLog]   - Model ApplicationInsightsComponent has a new parameter private_link_scoped_resources
[ChangeLog]   - Model ApplicationInsightsComponent has a new parameter immediate_purge_data_on30_days
[ChangeLog]   - Model ApplicationInsightsComponent has a new parameter connection_string
[ChangeLog]   - Model ApplicationInsightsComponent has a new parameter disable_ip_masking

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Mar 26, 2020 •
edited
Loading

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 1b5980a with merge commit 4cd7471. SDK Automation 13.0.17.20200326.3
  • ️✔️Microsoft.Azure.ApplicationInsights [Logs]  [Release SDK Changes]
      No Artifact Generated.

    @openapi-sdkautomation
    Copy link
    Copy Markdown

    openapi-sdkautomation Bot commented Mar 26, 2020 •
    edited
    Loading

    azure-sdk-for-java - Release

    ️✔️ succeeded [Logs] [Expand Details]

    This was referenced Mar 26, 2020
    Closed
    Closed
    Closed
    @azuresdkci
    Copy link
    Copy Markdown
    Contributor

    azuresdkci commented Mar 26, 2020

    Can one of the admins verify this patch?

    @arolshan arolshan closed this Mar 26, 2020
    @arolshan arolshan force-pushed the microsoft.insights-privatelink-scoped-resources branch from bc6689d to c23ee60 Compare March 26, 2020 18:02
    @openapi-sdkautomation openapi-sdkautomation Bot mentioned this pull request Mar 26, 2020
    Closed
    @arolshan arolshan reopened this Mar 26, 2020
    @azure-pipelines
    Copy link
    Copy Markdown

    azure-pipelines Bot commented Mar 26, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    1 similar comment
    @azure-pipelines
    Copy link
    Copy Markdown

    azure-pipelines Bot commented Mar 26, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    @arolshan arolshan requested review from KrisBash and d3r3kk and removed request for KrisBash March 26, 2020 18:14
    @pilor pilor added ARMReviewInProgress WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 26, 2020
    pilor
    pilor approved these changes Mar 26, 2020
    View reviewed changes
    Copy link
    Copy Markdown
    Contributor

    @pilor pilor left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    :shipit:

    @pilor pilor added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMReviewInProgress WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 26, 2020
    mmyyrroonn
    mmyyrroonn reviewed Mar 27, 2020
    View reviewed changes
    Comment thread ...pplicationinsights/resource-manager/Microsoft.Insights/stable/2015-05-01/components_API.json
    "readOnly": true,
    "type": "array",
    "items": {
    "$ref": "#/definitions/PrivateLinkScopedResource"
    Copy link
    Copy Markdown
    Contributor

    @mmyyrroonn mmyyrroonn Mar 27, 2020

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    since I'm also working on this feature for Azure CLI, I have a quick question for this one. Does it mean several private link scoped resource can be linked to one app component?

    @mmyyrroonn mmyyrroonn merged commit 4cd7471 into Azure:master Mar 27, 2020
    00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
    @arolshan @00Kai0
    Update components_API.json (Azure#8843)
    6cbd1b9
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @d3r3kk d3r3kk Awaiting requested review from d3r3kk

    2 more reviewers

    @pilor pilor pilor approved these changes

    @mmyyrroonn mmyyrroonn mmyyrroonn approved these changes

    Reviewers whose approvals may not affect merge requirements

    Assignees

    @mmyyrroonn mmyyrroonn

    Labels

    ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    4 participants

    @arolshan @azuresdkci @pilor @mmyyrroonn