[DO NOT MERGE !!!] SLB changes for new backend pool addresses format. by ninzavivek · Pull Request #8826 · Azure/azure-rest-api-specs

ninzavivek · 2020-03-24T21:48:47Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

azure-pipelines · 2020-03-24T21:49:04Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-03-24T21:50:19Z

azure-sdk-for-java

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 98cadb1 with merge commit d66930c0a58729354dfa1f30ae3b73e411395c5a. SDK Automation 13.0.17.20200326.3
️✔️sdk/network/mgmt-v2019_02_01 [Logs] [Preview SDK Changes]

⚠️sdk/network/mgmt-v2019_04_01 [Logs] [Preview SDK Changes]

[mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_04_01/src/main/java/com/microsoft/azure/management/network/v2019_04_01/implementation/LocationAvailablePrivateEndpointTypeModelImpl.java:[37,28] cannot find symbol
[mvn]   symbol:   method serviceName()
[mvn]   location: class com.microsoft.azure.management.network.v2019_04_01.implementation.AvailablePrivateEndpointTypeInner
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_04_01/src/main/java/com/microsoft/azure/management/network/v2019_04_01/implementation/LocationAvailablePrivateEndpointTypeImpl.java:[37,28] cannot find symbol
[mvn]   symbol:   method serviceName()
[mvn]   location: class com.microsoft.azure.management.network.v2019_04_01.implementation.AvailablePrivateEndpointTypeInner
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_04_01/src/main/java/com/microsoft/azure/management/network/v2019_04_01/implementation/AvailableResourceGroupPrivateEndpointTypesImpl.java:[23,30] cannot find symbol
[mvn]   symbol:   method availableResourceGroupPrivateEndpointTypes()
[mvn]   location: class com.microsoft.azure.management.network.v2019_04_01.implementation.NetworkManagementClientImpl
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-network: Compilation failure: Compilation failure: 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_04_01/src/main/java/com/microsoft/azure/management/network/v2019_04_01/implementation/LocationAvailablePrivateEndpointTypeModelImpl.java:[37,28] cannot find symbol
[mvn] [ERROR]   symbol:   method serviceName()
[mvn] [ERROR]   location: class com.microsoft.azure.management.network.v2019_04_01.implementation.AvailablePrivateEndpointTypeInner
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_04_01/src/main/java/com/microsoft/azure/management/network/v2019_04_01/implementation/LocationAvailablePrivateEndpointTypeImpl.java:[37,28] cannot find symbol
[mvn] [ERROR]   symbol:   method serviceName()
[mvn] [ERROR]   location: class com.microsoft.azure.management.network.v2019_04_01.implementation.AvailablePrivateEndpointTypeInner
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_04_01/src/main/java/com/microsoft/azure/management/network/v2019_04_01/implementation/AvailableResourceGroupPrivateEndpointTypesImpl.java:[23,30] cannot find symbol
[mvn] [ERROR]   symbol:   method availableResourceGroupPrivateEndpointTypes()
[mvn] [ERROR]   location: class com.microsoft.azure.management.network.v2019_04_01.implementation.NetworkManagementClientImpl
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

️✔️sdk/network/mgmt-v2019_06_01 [Logs] [Preview SDK Changes]
️✔️sdk/network/mgmt-v2019_07_01 [Logs] [Preview SDK Changes]
️✔️sdk/network/mgmt-v2019_08_01 [Logs] [Preview SDK Changes]

⚠️sdk/network/mgmt-v2019_09_01 [Logs] [Preview SDK Changes]

[mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_09_01/src/main/java/com/microsoft/azure/management/network/v2019_09_01/Subnet.java:[108,10] cannot find symbol
[mvn]   symbol:   class ResourceNavigationLinkInner
[mvn]   location: interface com.microsoft.azure.management.network.v2019_09_01.Subnet
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_09_01/src/main/java/com/microsoft/azure/management/network/v2019_09_01/Subnet.java:[118,10] cannot find symbol
[mvn]   symbol:   class ServiceAssociationLinkInner
[mvn]   location: interface com.microsoft.azure.management.network.v2019_09_01.Subnet
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-network: Compilation failure: Compilation failure: 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_09_01/src/main/java/com/microsoft/azure/management/network/v2019_09_01/Subnet.java:[108,10] cannot find symbol
[mvn] [ERROR]   symbol:   class ResourceNavigationLinkInner
[mvn] [ERROR]   location: interface com.microsoft.azure.management.network.v2019_09_01.Subnet
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_09_01/src/main/java/com/microsoft/azure/management/network/v2019_09_01/Subnet.java:[118,10] cannot find symbol
[mvn] [ERROR]   symbol:   class ServiceAssociationLinkInner
[mvn] [ERROR]   location: interface com.microsoft.azure.management.network.v2019_09_01.Subnet
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

openapi-sdkautomation · 2020-03-24T21:50:21Z

azure-sdk-for-go

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 98cadb1 with merge commit d66930c0a58729354dfa1f30ae3b73e411395c5a. SDK Automation 13.0.17.20200326.3
⚠️network/mgmt/2015-06-15 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2016-03-30 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2016-06-01 [Logs]
```
No file is changed.
```
️✔️network/mgmt/2016-09-01 [Logs] [Preview SDK Changes]
- network.mgmt.2016-09-01.zip
️✔️network/mgmt/2016-12-01 [Logs] [Preview SDK Changes]
- network.mgmt.2016-12-01.zip
⚠️network/mgmt/2017-03-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2017-06-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2017-08-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2017-09-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2017-10-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2017-11-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2018-01-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2018-02-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2018-04-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2018-06-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2018-07-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2018-08-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2018-10-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2018-11-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2018-12-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2019-02-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2019-04-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2019-06-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2019-07-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2019-08-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2019-09-01 [Logs]
```
No file is changed.
```
️✔️network/mgmt/2019-11-01 [Logs] [Preview SDK Changes]
- network.mgmt.2019-11-01.zip
⚠️preview/network/mgmt/2015-05-01-preview [Logs]
```
No file is changed.
```

openapi-sdkautomation · 2020-03-24T21:50:23Z

azure-sdk-for-net

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 98cadb1 with merge commit d66930c0a58729354dfa1f30ae3b73e411395c5a. SDK Automation 13.0.17.20200326.3

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.Network [Logs] [Preview SDK Changes]
- Microsoft.Azure.Management.Network.19.19.0-preview.nupkg
- Microsoft.Azure.Management.Network.19.19.0-preview.snupkg

openapi-sdkautomation · 2020-03-24T21:50:27Z

azure-sdk-for-js

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 98cadb1 with merge commit d66930c0a58729354dfa1f30ae3b73e411395c5a. SDK Automation 13.0.17.20200326.3

️✔️@azure/arm-network [Logs] [Preview SDK Changes]

azure-arm-network-20.0.0.tgz

[npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
[npmPack] npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/networkManagementClient.js → ./dist/arm-network.js...
[npmPack] created ./dist/arm-network.js in 2.5s

openapi-sdkautomation · 2020-03-24T21:50:30Z

azure-sdk-for-python

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 98cadb1 with merge commit d66930c0a58729354dfa1f30ae3b73e411395c5a. SDK Automation 13.0.17.20200326.3
```
Failed to find any diff after autorest so no changed packages was found.
```

azuresdkci · 2020-03-24T21:54:39Z

Can one of the admins verify this patch?

azure-pipelines · 2020-03-25T15:32:16Z

Azure Pipelines successfully started running 1 pipeline(s).

anton-evseev

LGTM except a few nitpicks

specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/loadBalancer.json

azure-pipelines · 2020-03-25T16:38:10Z

Azure Pipelines successfully started running 1 pipeline(s).

lirenhe · 2020-03-26T07:13:25Z

@ninzavivek, I saw this is still in draft mode, please let us know when it is ready for SDK/ARM review.

azure-pipelines · 2020-03-26T12:25:22Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-04-01T17:46:31Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-04-01T18:05:11Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-04-01T18:25:06Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-04-01T18:43:35Z

Azure Pipelines successfully started running 1 pipeline(s).

anton-evseev · 2020-04-09T10:09:27Z

Closed in favor of #8993

ninzavivek added 3 commits March 20, 2020 14:03

Changes for new backend pool

a07763d

fix some validation

3926be9

Added ref to examples

04a516b

openapi-assignment-bot bot assigned lirenhe Mar 24, 2020

ninzavivek requested review from MikhailTryakhov, aegal and anton-evseev March 24, 2020 21:49

fixing validation error

1975d08

anton-evseev suggested changes Mar 25, 2020

View reviewed changes

Addressed feedback

d61c48e

ninzavivek requested a review from gmainar March 25, 2020 17:09

fix network validation

0fb9f02

add changes for nic configuration

0eeb8cd

fix example

5a99250

fixed exampel validation

80bbbbd

fix prettier check

98cadb1

ninzavivek changed the title ~~SLB changes for new backend pool addresses format.~~ [DO NOT MERGE !!!] SLB changes for new backend pool addresses format. Apr 1, 2020

lirenhe added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Apr 2, 2020

anton-evseev closed this Apr 9, 2020

Conversation

ninzavivek commented Mar 24, 2020

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

azure-pipelines bot commented Mar 24, 2020

Uh oh!

openapi-sdkautomation bot commented Mar 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java

Uh oh!

openapi-sdkautomation bot commented Mar 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go

Uh oh!

openapi-sdkautomation bot commented Mar 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net

Uh oh!

openapi-sdkautomation bot commented Mar 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js

Uh oh!

openapi-sdkautomation bot commented Mar 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python

Uh oh!

azuresdkci commented Mar 24, 2020

Uh oh!

azure-pipelines bot commented Mar 25, 2020

Uh oh!

anton-evseev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

azure-pipelines bot commented Mar 25, 2020

Uh oh!

lirenhe commented Mar 26, 2020

Uh oh!

azure-pipelines bot commented Mar 26, 2020

Uh oh!

azure-pipelines bot commented Apr 1, 2020

Uh oh!

azure-pipelines bot commented Apr 1, 2020

Uh oh!

azure-pipelines bot commented Apr 1, 2020

Uh oh!

azure-pipelines bot commented Apr 1, 2020

Uh oh!

anton-evseev commented Apr 9, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

openapi-sdkautomation bot commented Mar 24, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 24, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 24, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 24, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 24, 2020 •

edited

Loading