Skip to content

Add api-version 2019-12-01 of apimanagement for go SDK #8817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2020
Merged

Add api-version 2019-12-01 of apimanagement for go SDK #8817

merged 1 commit into from
Mar 24, 2020

Conversation

@ArcturusZhang
Copy link
Member

@ArcturusZhang ArcturusZhang commented Mar 24, 2020

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 24, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@azuresdkci
Copy link
Contributor

azuresdkci commented Mar 24, 2020

Can one of the admins verify this patch?

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 24, 2020 •
edited
Loading

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 24, 2020 •
edited
Loading

azure-sdk-for-python - Release

- Breaking Change detected in SDK

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 9884c3a with merge commit fae82ba. SDK Automation 13.0.17.20200320.2
  • ⚠️azure-mgmt-apimanagement [Logs]  [Release SDK Changes] Breaking Change Detected
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[breaking_change_setup] Cannot uninstall requirement azure-nspkg, not installed
[breaking_change_setup] Command '['/usr/local/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
[ChangeLog] Size of delta 12.559% size of original (original: 232886 chars, delta: 29248 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog] - Model TagDescriptionContract has a new parameter tag_id
[ChangeLog] - Model AdditionalLocation has a new parameter disable_gateway
[ChangeLog] - Model ApiManagementServiceResource has a new parameter disable_gateway
[ChangeLog] - Model ApiManagementServiceResource has a new parameter api_version_constraint
[ChangeLog] - Model ApiManagementServiceResource has a new parameter developer_portal_url
[ChangeLog] - Model ApiManagementServiceIdentity has a new parameter user_assigned_identities
[ChangeLog] - Model ApiManagementServiceUpdateParameters has a new parameter disable_gateway
[ChangeLog] - Model ApiManagementServiceUpdateParameters has a new parameter api_version_constraint
[ChangeLog] - Model ApiManagementServiceUpdateParameters has a new parameter developer_portal_url
[ChangeLog] - Model IdentityProviderUpdateParameters has a new parameter signin_tenant
[ChangeLog] - Model SchemaContract has a new parameter value
[ChangeLog] - Model SchemaContract has a new parameter definitions
[ChangeLog] - Model IdentityProviderBaseParameters has a new parameter signin_tenant
[ChangeLog] - Model ApiManagementServiceBaseProperties has a new parameter disable_gateway
[ChangeLog] - Model ApiManagementServiceBaseProperties has a new parameter api_version_constraint
[ChangeLog] - Model ApiManagementServiceBaseProperties has a new parameter developer_portal_url
[ChangeLog] - Model UserCreateParameters has a new parameter app_type
[ChangeLog] - Model IdentityProviderContract has a new parameter signin_tenant
[ChangeLog] - Model DiagnosticContract has a new parameter verbosity
[ChangeLog] - Model DiagnosticContract has a new parameter http_correlation_protocol
[ChangeLog] - Model DiagnosticContract has a new parameter log_client_ip
[ChangeLog] - Added operation DelegationSettingsOperations.list_secrets
[ChangeLog] - Added operation AuthorizationServerOperations.list_secrets
[ChangeLog] - Added operation IdentityProviderOperations.list_secrets
[ChangeLog] - Added operation SubscriptionOperations.list_secrets
[ChangeLog] - Added operation TenantAccessGitOperations.list_secrets
[ChangeLog] - Added operation OpenIdConnectProviderOperations.list_secrets
[ChangeLog] - Added operation TenantAccessOperations.list_secrets
[ChangeLog] - Added operation group GatewayHostnameConfigurationOperations
[ChangeLog] - Added operation group NamedValueOperations
[ChangeLog] - Added operation group PolicyDescriptionOperations
[ChangeLog] - Added operation group GatewayApiOperations
[ChangeLog] - Added operation group GatewayOperations
[ChangeLog] 
[ChangeLog] **Breaking changes**
[ChangeLog] 
[ChangeLog] - Operation ApiTagDescriptionOperations.get has a new signature
[ChangeLog] - Operation ApiTagDescriptionOperations.create_or_update has a new signature
[ChangeLog] - Operation ApiTagDescriptionOperations.get_entity_tag has a new signature
[ChangeLog] - Operation ApiTagDescriptionOperations.delete has a new signature
[ChangeLog] - Operation ApiSchemaOperations.create_or_update has a new signature
[ChangeLog] - Parameter capacity of model ApiManagementServiceSkuProperties is now required
[ChangeLog] - Operation ApiSchemaOperations.create_or_update has a new signature
[ChangeLog] - Model AuthenticationSettingsContract no longer has parameter subscription_key_required
[ChangeLog] - Model SchemaContract no longer has parameter document
[ChangeLog] - Model DiagnosticContract no longer has parameter enable_http_correlation_headers
[ChangeLog] - Model AuthorizationServerContractBaseProperties no longer has parameter client_secret
[ChangeLog] - Removed operation group PolicySnippetOperations
[ChangeLog] - Removed operation group PropertyOperations

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 24, 2020 •
edited
Loading

azure-cli-extensions - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 24, 2020 •
edited
Loading

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 24, 2020 •
edited
Loading

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 24, 2020 •
edited
Loading

azure-sdk-for-net - Release

❌ failed [Logs] [Expand Details]
  • ❌ Generate from 9884c3a with merge commit fae82ba. SDK Automation 13.0.17.20200320.2
  • ❌Microsoft.Azure.Management.ApiManagement [Logs]  [Release SDK Changes] 
      Failed to create the package Microsoft.Azure.Management.ApiManagement.
Error: dotnet msbuild build.proj /t:CreateNugetPackage /p:Scope=apimanagement /v:n /p:SkipTests=true , {}

    @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Mar 24, 2020
    Closed
    This was referenced Mar 24, 2020
    Closed
    Closed
    @isra-fel
    Copy link
    Member

    isra-fel commented Mar 24, 2020 •
    edited
    Loading

    I don't know why the following thing is generated

    [MSBuild]      3>ResourceProviderTests/SetupMsiTests.cs(98,69): error CS0246: The type or namespace name 'Components16nk615schemasapimanagementserviceidentitypropertiesuserassignedidentitiesadditionalproperties' could not be found (are you missing a using directive or an assembly reference?) [/z/work/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]

    but it's already failing in this PR (for the same reason): #8796

    @ArcturusZhang ArcturusZhang merged commit fae82ba into Azure:master Mar 24, 2020
    @ArcturusZhang ArcturusZhang deleted the add-api-version-2019-12-for-apimanagement branch March 24, 2020 06:23
    00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
    @ArcturusZhang @00Kai0
    Add api-version 2019-12-01 of apimanagement for go SDK (Azure#8817)
    23b67b4
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @solankisamir solankisamir Awaiting requested review from solankisamir

    1 more reviewer

    @mmyyrroonn mmyyrroonn mmyyrroonn approved these changes

    Reviewers whose approvals may not affect merge requirements

    Assignees

    @lirenhe lirenhe

    @mmyyrroonn mmyyrroonn

    Labels

    None yet

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    5 participants

    @ArcturusZhang @azuresdkci @isra-fel @mmyyrroonn @lirenhe