Skip to content

Comments

[Hub Generated] Review request for Microsoft.CostManagement to add version preview/2019-03-01-preview#8732

Merged
akning-ms merged 6 commits intoAzure:masterfrom
elabicha:dev-cost-management-Microsoft.CostManagement-2019-03-01-preview
Mar 29, 2020
Merged

[Hub Generated] Review request for Microsoft.CostManagement to add version preview/2019-03-01-preview#8732
akning-ms merged 6 commits intoAzure:masterfrom
elabicha:dev-cost-management-Microsoft.CostManagement-2019-03-01-preview

Conversation

@elabicha
Copy link
Contributor

@elabicha elabicha commented Mar 17, 2020 •
edited
Loading

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 17, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 17, 2020 •
edited
Loading

azure-cli-extensions - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 17, 2020 •
edited
Loading

azure-sdk-for-python - Release

- Breaking Change detected in SDK

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 19bb3ab with merge commit 3d645d0. SDK Automation 13.0.17.20200326.3
  • ⚠️azure-mgmt-costmanagement [Logs]  [Release SDK Changes] Breaking Change Detected
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[breaking_change_setup] Cannot uninstall requirement azure-nspkg, not installed
[breaking_change_setup] Command '['/usr/local/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
[ChangeLog] Size of delta 17.137% size of original (original: 14116 chars, delta: 2419 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog]   - Added operation DimensionsOperations.list
[ChangeLog]   - Added operation QueryOperations.usage
[ChangeLog] 
[ChangeLog] **Breaking changes**
[ChangeLog] 
[ChangeLog]   - Model QueryDataset no longer has parameter sorting
[ChangeLog]   - Removed operation DimensionsOperations.list_by_subscription
[ChangeLog]   - Removed operation QueryOperations.usage_by_scope

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 17, 2020 •
edited
Loading

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 17, 2020 •
edited
Loading

azure-sdk-for-js - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 17, 2020 •
edited
Loading

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 17, 2020 •
edited
Loading

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 19bb3ab with merge commit 3d645d0. SDK Automation 13.0.17.20200326.3
  • ⚠️costmanagement/mgmt/2018-05-31 [Logs]  
      No file is changed.
    • ⚠️costmanagement/mgmt/2019-01-01 [Logs]  
        No file is changed.
      • ⚠️costmanagement/mgmt/2019-10-01 [Logs]  
          No file is changed.
        • ⚠️preview/costmanagement/mgmt/2018-08-01-preview [Logs]  
            No file is changed.
          • ️✔️preview/costmanagement/mgmt/2019-03-01 [Logs]  [Release SDK Changes]

          @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Mar 17, 2020
          Closed
          @azuresdkci
          Copy link
          Contributor

          azuresdkci commented Mar 17, 2020

          Can one of the admins verify this patch?

          @akning-ms
          Copy link
          Contributor

          akning-ms commented Mar 17, 2020

          Hi @elabicha Can you fix modal validation and prettiercheck failure in your PR?

          @akning-ms akning-ms added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 17, 2020
          @azure-pipelines
          Copy link

          azure-pipelines bot commented Mar 17, 2020

          Azure Pipelines successfully started running 1 pipeline(s).

          @azure-pipelines
          Copy link

          azure-pipelines bot commented Mar 17, 2020

          Azure Pipelines successfully started running 1 pipeline(s).

          @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Mar 17, 2020
          Closed
          @azure-pipelines
          Copy link

          azure-pipelines bot commented Mar 19, 2020

          Azure Pipelines successfully started running 1 pipeline(s).

          @anthony-c-martin anthony-c-martin added ARMChangesRequested and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 20, 2020
          @azure-pipelines
          Copy link

          azure-pipelines bot commented Mar 26, 2020

          Azure Pipelines successfully started running 1 pipeline(s).

          @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Mar 26, 2020
          Closed
          @anthony-c-martin anthony-c-martin added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested labels Mar 26, 2020
          @azure-pipelines
          Copy link

          azure-pipelines bot commented Mar 26, 2020

          Azure Pipelines successfully started running 1 pipeline(s).

          @akning-ms
          Copy link
          Contributor

          akning-ms commented Mar 27, 2020

          @elabicha there is potential python sdk breaking change detected in this PR. Can I know little more about this api preview version. e.g will it use for generate sdk or use for generate Azure CLI/PS etc?

          @elabicha
          Copy link
          Contributor Author

          elabicha commented Mar 29, 2020

          CloudConnectors is a feature that is in public preview and it will not be used for sdk release.

          @akning-ms akning-ms merged commit 3d645d0 into Azure:master Mar 29, 2020
          00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
          @elabicha @00Kai0
          [Hub Generated] Review request for Microsoft.CostManagement to add ve…
          60310cf 
          …rsion preview/2019-03-01-preview (Azure#8732)

* adding check eligibility api

* adding a newline at the end of files

* fixing spacing and parameters in example

* fixing validations

* changes based on review

* change to camel case
          Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

          Reviewers

          @anthony-c-martin anthony-c-martin anthony-c-martin left review comments

          @akning-ms akning-ms akning-ms approved these changes

          Assignees

          @akning-ms akning-ms

          Labels

          ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review potential-sdk-breaking-change

          Projects

          None yet

          Milestone

          No milestone

          Development

          Successfully merging this pull request may close these issues.

          4 participants

          @elabicha @azuresdkci @akning-ms @anthony-c-martin