Update informationProtectionPolicies.json #8677

ranisha2 · 2020-03-11T11:29:05Z

Update informationProtectionPolicies.json

Fix PUT: Missing parameter
Add missing parameters to the sensitivity label and information type

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Update informationProtectionPolicies.json - Fix PUT: Missing parameter - Add missing parameters to the sensitivity label and information type

azure-pipelines · 2020-03-11T11:43:10Z

Azure Pipelines successfully started running 1 pipeline(s).

azuresdkci · 2020-03-11T12:05:03Z

Can one of the admins verify this patch?

openapi-sdkautomation · 2020-03-11T13:15:18Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 040fb3a with merge commit fea3b43. SDK Automation 13.0.17.20200320.2
️✔️preview/security/mgmt/v1.0 [Logs] [Release SDK Changes]
- preview.security.mgmt.v1.0.zip
️✔️preview/security/mgmt/v2.0 [Logs] [Release SDK Changes]
- preview.security.mgmt.v2.0.zip
️✔️preview/security/mgmt/v3.0 [Logs] [Release SDK Changes]
- preview.security.mgmt.v3.0.zip

openapi-sdkautomation · 2020-03-11T13:15:31Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 040fb3a with merge commit fea3b43. SDK Automation 13.0.17.20200320.2

️✔️@azure/arm-security [Logs] [Release SDK Changes]

azure-arm-security-1.2.0.tgz

[npmPack] npm WARN lifecycle @azure/[email protected]~prepack: cannot run in wd @azure/[email protected] npm install && npm run build (wd=/z/work/azure-sdk-for-js/sdk/security/arm-security)

openapi-sdkautomation · 2020-03-11T13:15:31Z

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-03-11T13:15:45Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 040fb3a with merge commit fea3b43. SDK Automation 13.0.17.20200320.2
️✔️Microsoft.Azure.Management.SecurityCenter [Logs] [Release SDK Changes]
- Microsoft.Azure.Management.SecurityCenter.1.1.1.nupkg
- Microsoft.Azure.Management.SecurityCenter.1.1.1.snupkg

openapi-sdkautomation · 2020-03-11T13:15:53Z

azure-sdk-for-python - Release

- Breaking Change detected in SDK

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 040fb3a with merge commit fea3b43. SDK Automation 13.0.17.20200320.2

⚠️azure-mgmt-security [Logs] [Release SDK Changes] Breaking Change Detected

[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[breaking_change_setup] Cannot uninstall requirement azure-nspkg, not installed
[breaking_change_setup] Command '['/usr/local/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
[ChangeLog] Size of delta 38.353% size of original (original: 116214 chars, delta: 44571 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog]   - Model SensitivityLabel has a new parameter rank
[ChangeLog]   - Model SensitivityLabel has a new parameter description
[ChangeLog]   - Model IoTSecuritySolutionModel has a new parameter unmasked_ip_logging_status
[ChangeLog]   - Model JitNetworkAccessRequest has a new parameter justification
[ChangeLog]   - Model JitNetworkAccessPolicyInitiateRequest has a new parameter justification
[ChangeLog]   - Model AppWhitelistingPutGroupData has a new parameter protection_mode
[ChangeLog]   - Model VmRecommendation has a new parameter enforcement_support
[ChangeLog]   - Model AppWhitelistingGroup has a new parameter protection_mode
[ChangeLog]   - Model IoTSecurityAggregatedAlert has a new parameter top_devices_list
[ChangeLog]   - Model InformationType has a new parameter description
[ChangeLog]   - Added operation AlertsOperations.update_resource_group_level_alert_state_to_dismiss
[ChangeLog]   - Added operation AlertsOperations.update_resource_group_level_alert_state_to_reactivate
[ChangeLog]   - Added operation AlertsOperations.update_subscription_level_alert_state_to_dismiss
[ChangeLog]   - Added operation AlertsOperations.update_subscription_level_alert_state_to_reactivate
[ChangeLog]   - Added operation AdaptiveApplicationControlsOperations.delete
[ChangeLog]   - Added operation IotSecuritySolutionOperations.create_or_update
[ChangeLog]   - Added operation IotSecuritySolutionOperations.list_by_resource_group
[ChangeLog]   - Added operation IotSecuritySolutionOperations.list_by_subscription
[ChangeLog]   - Added operation group SubAssessmentsOperations
[ChangeLog]   - Added operation group AssessmentsMetadataOperations
[ChangeLog]   - Added operation group IotSecuritySolutionsAnalyticsAggregatedAlertOperations
[ChangeLog]   - Added operation group AutomationsOperations
[ChangeLog]   - Added operation group IotSecuritySolutionAnalyticsOperations
[ChangeLog]   - Added operation group IotSecuritySolutionsAnalyticsRecommendationOperations
[ChangeLog]   - Added operation group AdaptiveNetworkHardeningsOperations
[ChangeLog]   - Added operation group AssessmentsOperations
[ChangeLog]   - Added operation group DeviceSecurityGroupsOperations
[ChangeLog] 
[ChangeLog] **Breaking changes**
[ChangeLog] 
[ChangeLog]   - Operation JitNetworkAccessPoliciesOperations.initiate has a new signature
[ChangeLog]   - Operation InformationProtectionPoliciesOperations.create_or_update has a new signature
[ChangeLog]   - Removed operation AlertsOperations.update_subscription_level_alert_state
[ChangeLog]   - Removed operation AlertsOperations.update_resource_group_level_alert_state
[ChangeLog]   - Removed operation IotSecuritySolutionOperations.create
[ChangeLog]   - Removed operation group IoTSecuritySolutionsAnalyticsAggregatedAlertOperations
[ChangeLog]   - Removed operation group IoTSecuritySolutionsOperations
[ChangeLog]   - Removed operation group IoTSecuritySolutionsAnalyticsRecommendationOperations
[ChangeLog]   - Removed operation group IoTSecuritySolutionsResourceGroupOperations
[ChangeLog]   - Removed operation group IoTSecuritySolutionsAnalyticsAggregatedAlertsOperations
[ChangeLog]   - Removed operation group IoTSecuritySolutionsAnalyticsOperations
[ChangeLog]   - Removed operation group IoTSecuritySolutionsAnalyticsRecommendationsOperations

bashahee · 2020-03-18T17:53:53Z

@weidongxu-microsoft can this PR be merged?

The existing swagger is invalid, hence the failures in this PR's tests. Moreover, existing SDK clients are not usable now, so we need this swagger merged in order to update SDK clients package with working clients.

weidongxu-microsoft · 2020-03-19T01:20:39Z

@bashahee

I will email arm review on this, with your reason here (this is still a needed step). Then I will ask PM to force merge.

bashahee · 2020-03-19T07:25:39Z

Thanks @weidongxu-microsoft for the help!

weidongxu-microsoft · 2020-03-25T01:53:10Z

@akning-ms Can you help merge this?

BreakingChange is due to existing swagger is invalid (hence this PR).

openapi-sdkautomation · 2020-03-26T02:41:13Z

azure-cli-extensions - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

* Update informationProtectionPolicies.json Update informationProtectionPolicies.json - Fix PUT: Missing parameter - Add missing parameters to the sensitivity label and information type * Update CreateOrUpdateInformationProtectionPolicy_example.json

Update informationProtectionPolicies.json

96771ed

Update informationProtectionPolicies.json - Fix PUT: Missing parameter - Add missing parameters to the sensitivity label and information type

openapi-assignment-bot bot assigned weidongxu-microsoft Mar 11, 2020

weidongxu-microsoft added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 11, 2020

Update CreateOrUpdateInformationProtectionPolicy_example.json

040fb3a

bashahee self-assigned this Mar 11, 2020

bashahee requested review from bashahee and removed request for bashahee March 11, 2020 11:55

bashahee removed their assignment Mar 11, 2020

weidongxu-microsoft approved these changes Mar 19, 2020

View reviewed changes

pilor added ARMReviewInProgress ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMReviewInProgress WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 24, 2020

pilor approved these changes Mar 24, 2020

View reviewed changes

weidongxu-microsoft assigned akning-ms Mar 25, 2020

weidongxu-microsoft added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Mar 25, 2020

weidongxu-microsoft removed their assignment Mar 26, 2020

akning-ms merged commit fea3b43 into Azure:master Mar 26, 2020

bashahee mentioned this pull request Apr 3, 2020

Update Information Protection SDK Clients Azure/azure-sdk-for-net#10932

Merged

Update informationProtectionPolicies.json #8677

Update informationProtectionPolicies.json #8677

Uh oh!

Conversation

ranisha2 commented Mar 11, 2020

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

azure-pipelines bot commented Mar 11, 2020

Uh oh!

azuresdkci commented Mar 11, 2020

Uh oh!

openapi-sdkautomation bot commented Mar 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go - Release

Uh oh!

openapi-sdkautomation bot commented Mar 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js - Release

Uh oh!

openapi-sdkautomation bot commented Mar 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java - Release

Uh oh!

openapi-sdkautomation bot commented Mar 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net - Release

Uh oh!

openapi-sdkautomation bot commented Mar 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python - Release

- Breaking Change detected in SDK

Uh oh!

bashahee commented Mar 18, 2020

Uh oh!

weidongxu-microsoft commented Mar 19, 2020

Uh oh!

bashahee commented Mar 19, 2020

Uh oh!

weidongxu-microsoft commented Mar 25, 2020

Uh oh!

openapi-sdkautomation bot commented Mar 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-cli-extensions - Release

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

openapi-sdkautomation bot commented Mar 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 26, 2020 •

edited

Loading