Skip to content

[acr] update default package tag and PrivateEndpointConnection resource for containerregistry #8646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akning-ms merged 3 commits into from
Mar 24, 2020
Merged

[acr] update default package tag and PrivateEndpointConnection resource for containerregistry #8646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7127d2a
update default package tag
Mar 9, 2020
2a0ec7d
Update typescript autorest config file.
Mar 18, 2020
a810e7b
PrivateEndpointConnection should inherit proxyresource
Mar 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 26 additions & 13 deletions ...rce-manager/Microsoft.ContainerRegistry/preview/2019-12-01-preview/containerregistry.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1520,20 +1520,12 @@
"PrivateEndpointConnection": {
"description": "An object that represents a private endpoint connection for a container registry.",
"type": "object",
"allOf": [
{
"$ref": "#/definitions/ProxyResource"
}
],
"properties": {
"type": {
"description": "The resource type is private endpoint connection.",
"type": "string",
"readOnly": true
},
"id": {
"description": "The resource ID.",
"type": "string"
},
"name": {
"description": "The name of the resource.",
"type": "string"
},
"properties": {
"$ref": "#/definitions/PrivateEndpointConnectionProperties",
"description": "The properties of a private endpoint connection.",
Expand Down Expand Up @@ -2897,6 +2889,27 @@
}
}
},
"ProxyResource": {
"description": "The resource model definition for a ARM proxy resource. It will have everything other than required location and tags.",
"properties": {
"id": {
"description": "The resource ID.",
"type": "string",
"readOnly": true
},
"name": {
"description": "The name of the resource.",
"type": "string",
"readOnly": true
},
"type": {
"description": "The type of the resource.",
"type": "string",
"readOnly": true
}
},
"x-ms-azure-resource": true
},
"Resource": {
"description": "An Azure resource.",
"required": [
Expand Down
2 changes: 1 addition & 1 deletion specification/containerregistry/resource-manager/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ These are the global settings for the ContainerRegistry API.

``` yaml
openapi-type: arm
tag: package-2019-06-preview
tag: package-2019-12-preview
```


Expand Down
2 changes: 1 addition & 1 deletion specification/containerregistry/resource-manager/readme.typescript.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Please also specify `--typescript-sdks-folder=<path to root folder of your azure

``` yaml $(typescript)
input-file:
- Microsoft.ContainerRegistry/stable/2019-05-01/containerregistry.json
- Microsoft.ContainerRegistry/preview/2019-12-01-preview/containerregistry.json
- Microsoft.ContainerRegistry/preview/2019-06-01-preview/containerregistry_build.json
- Microsoft.ContainerRegistry/preview/2019-05-01-preview/containerregistry_scopemap.json
typescript:
Expand Down