Skip to content

remove private link related apis#8629

Merged
markcowl merged 2 commits into
Azure:masterfrom
arolshan:microsoft.operationalinsights-remove-privatelink
Mar 26, 2020
Merged

remove private link related apis#8629
markcowl merged 2 commits into
Azure:masterfrom
arolshan:microsoft.operationalinsights-remove-privatelink

Conversation

@arolshan
Copy link
Copy Markdown
Contributor

@arolshan arolshan commented Mar 8, 2020 •
edited
Loading

this API was never used and never even tested in public.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@arolshan
remove private link related apis
f3752e3 
this API was never used and never even tested in public.
@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Mar 8, 2020

Azure Pipelines successfully started running 1 pipeline(s).

4 similar comments
@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Mar 8, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Mar 8, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Mar 8, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Mar 8, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@azuresdkci
Copy link
Copy Markdown
Contributor

azuresdkci commented Mar 8, 2020

Can one of the admins verify this patch?

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Mar 8, 2020 •
edited
Loading

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Mar 8, 2020 •
edited
Loading

azure-sdk-for-python - Release

- Breaking Change detected in SDK

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 4ae9bdd with merge commit 621d0b3. SDK Automation 13.0.17.20200326.3
  • ⚠️azure-mgmt-loganalytics [Logs]  [Release SDK Changes] Breaking Change Detected
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[breaking_change_setup] Cannot uninstall requirement azure-nspkg, not installed
[breaking_change_setup] Command '['/usr/local/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
[ChangeLog] Size of delta 19.139% size of original (original: 16631 chars, delta: 3183 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog]   - Added operation group OperationalInsightsManagementClientOperationsMixin
[ChangeLog] 
[ChangeLog] **Breaking changes**
[ChangeLog] 
[ChangeLog]   - Removed operation WorkspacesOperations.get_schema
[ChangeLog]   - Removed operation WorkspacesOperations.purge
[ChangeLog]   - Removed operation WorkspacesOperations.get_search_results
[ChangeLog]   - Removed operation WorkspacesOperations.update_search_results
[ChangeLog]   - Removed operation WorkspacesOperations.list_link_targets
[ChangeLog]   - Removed operation group SavedSearchesOperations
[ChangeLog]   - Removed operation group StorageInsightsOperations

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Mar 8, 2020 •
edited
Loading

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Mar 8, 2020 •
edited
Loading

azure-sdk-for-net

❌ failed [Logs] [Expand Details]
  • ❌ Generate from f3752e3 with merge commit d831f55c871f0da4241ebf5f07d7a4e5798f3001. SDK Automation 13.0.17.20191226.1 
    [AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
  • ❌Microsoft.Azure.Management.OperationalInsights [Logs]  
      SDK Repository Package Error: Error: git push --set-upstream integration sdkAutomation/Microsoft.Azure.Management.OperationalInsights --force To https://github.com/AzureSDKAutomation/azure-sdk-for-net
 ! [remote rejected]     sdkAutomation/Microsoft.Azure.Management.OperationalInsights -> sdkAutomation/Microsoft.Azure.Management.OperationalInsights (cannot lock ref 'refs/heads/sdkAutomation/Microsoft.Azure.Management.OperationalInsights': is at f362ed2fc3c06cf85065101bc4862eedea950421 but expected 71a2a5cd959bef2b07c275b5325343605f20c0ac)
error: failed to push some refs to 'https://x-access-token:v1.513f165abaeac7fa5462df8843a677725bf4cc5d@github.com/AzureSDKAutomation/azure-sdk-for-net'
, {}
SDK Repository Package Error: Error: git push --set-upstream generation sdkAutomation/Microsoft.Azure.Management.OperationalInsights@8629 --force To https://github.com/AzureSDKAutomation/azure-sdk-for-net
 ! [remote rejected]     sdkAutomation/Microsoft.Azure.Management.OperationalInsights@8629 -> sdkAutomation/Microsoft.Azure.Management.OperationalInsights@8629 (cannot lock ref 'refs/heads/sdkAutomation/Microsoft.Azure.Management.OperationalInsights@8629': reference already exists)
error: failed to push some refs to 'https://x-access-token:v1.513f165abaeac7fa5462df8843a677725bf4cc5d@github.com/AzureSDKAutomation/azure-sdk-for-net'
, {}

    @openapi-sdkautomation
    Copy link
    Copy Markdown

    openapi-sdkautomation Bot commented Mar 8, 2020 •
    edited
    Loading

    azure-sdk-for-js - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from 4ae9bdd with merge commit 621d0b3. SDK Automation 13.0.17.20200326.3
    • ️✔️@azure/arm-operationalinsights [Logs]  [Release SDK Changes] 
      [npmPack] npm WARN lifecycle @azure/arm-operationalinsights@1.2.0~prepack: cannot run in wd @azure/arm-operationalinsights@1.2.0 npm install && npm run build (wd=/z/work/azure-sdk-for-js/sdk/operationalinsights/arm-operationalinsights)

    @openapi-sdkautomation
    Copy link
    Copy Markdown

    openapi-sdkautomation Bot commented Mar 8, 2020 •
    edited
    Loading

    azure-sdk-for-go - Release

    ⚠️ warning [Logs] [Expand Details]

    This was referenced Mar 8, 2020
    Closed
    Closed
    Closed
    @azure-pipelines
    Copy link
    Copy Markdown

    azure-pipelines Bot commented Mar 8, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    @markcowl markcowl added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 10, 2020
    @markcowl markcowl removed their assignment Mar 19, 2020
    @pilor pilor added ARMReviewInProgress ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMReviewInProgress WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 23, 2020
    @pilor
    Copy link
    Copy Markdown
    Contributor

    pilor commented Mar 23, 2020

    These are not in the RP manifest. If there is no use I'm fine with removing them from the API side

    @markcowl markcowl merged commit 621d0b3 into Azure:master Mar 26, 2020
    @openapi-sdkautomation
    Copy link
    Copy Markdown

    openapi-sdkautomation Bot commented Mar 26, 2020 •
    edited
    Loading

    azure-cli-extensions - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
    @arolshan @00Kai0
    remove private link related apis (Azure#8629)
    a66b426 
    * remove private link related apis

this API was never used and never even tested in public.

* Update OperationalInsights.json
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @markcowl markcowl markcowl approved these changes

    +1 more reviewer

    @pilor pilor pilor approved these changes

    Reviewers whose approvals may not affect merge requirements

    Assignees

    No one assigned

    Labels

    ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    4 participants

    @arolshan @azuresdkci @pilor @markcowl