[Synapse Management] Update sqlPool.json and add integrationRuntime.json by aim-for-better · Pull Request #8628 · Azure/azure-rest-api-specs

aim-for-better · 2020-03-08T14:06:46Z

update sqlPool.json to add 202 response
add integrationRuntime.json and related example

ARM team has reviewed integrationRuntime.json and related example in https://github.com/Azure/azure-rest-api-specs-pr/pull/1024
Hope this information can reduce ARM review time.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

azure-pipelines · 2020-03-08T14:07:02Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-08T14:07:25Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-08T14:07:27Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-08T14:07:27Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-08T14:07:35Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-08T14:07:36Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-08T14:07:42Z

Azure Pipelines successfully started running 1 pipeline(s).

azuresdkci · 2020-03-08T14:08:05Z

Can one of the admins verify this patch?

azure-pipelines · 2020-03-08T14:15:29Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-03-08T14:21:28Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 0575ac3 with merge commit 39df77d. SDK Automation 13.0.17.20200326.3
️✔️preview/synapse/mgmt/2019-06-01-preview [Logs] [Release SDK Changes]
- preview.synapse.mgmt.2019-06-01-preview.zip

openapi-sdkautomation · 2020-03-08T14:21:32Z

azure-sdk-for-java - Release

❌ failed [Logs] [Expand Details]

❌ Generate from 0575ac3 with merge commit 39df77d. SDK Automation 13.0.17.20200326.3

[AutoRest] FATAL: System.Exception: Duplicate File Generation: src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/IntegrationRuntimeNodeIpAddress.java
[AutoRest]    at AutoRest.Core.CodeGenerator.d__13.MoveNext() in /home/vsts/work/1/s/autorest.common/src/CodeGenerator.cs:line 151
[AutoRest] --- End of stack trace from previous location where exception was thrown ---
[AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
[AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
[AutoRest]    at AutoRest.Core.CodeGenerator.d__12.MoveNext() in /home/vsts/work/1/s/autorest.common/src/CodeGenerator.cs:line 121
[AutoRest] --- End of stack trace from previous location where exception was thrown ---
[AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
[AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
[AutoRest]    at AutoRest.Java.Azure.Fluent.CodeGeneratorJvaf.d__6.MoveNext() in /home/vsts/work/1/s/src/azurefluent/CodeGeneratorJvaf.cs:line 106
[AutoRest] --- End of stack trace from previous location where exception was thrown ---
[AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
[AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
[AutoRest]    at AutoRest.Java.Program.d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 114
[AutoRest] --- End of stack trace from previous location where exception was thrown ---
[AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
[AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
[AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
[AutoRest]    at NewPlugin.d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
[AutoRest] FATAL: java/generate - FAILED
[AutoRest] FATAL: Error: Plugin java reported failure.
[AutoRest] Failure during batch task - {"tag":"package-2019-06-01-preview"} -- Error: Plugin java reported failure..
[AutoRest]   Error: Plugin java reported failure.
Failed to run autorest.
Error: /z/node_modules/.bin/autorest --version=2.0.4413 --java --verbose --multiapi --use=@microsoft.azure/autorest.java@2.1.95 --azure-libraries-for-java-folder=/z/work/azure-sdk-for-java /z/work/azure-rest-api-specs/specification/synapse/resource-manager/readme.md FATAL: System.Exception: Duplicate File Generation: src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/IntegrationRuntimeNodeIpAddress.java
   at AutoRest.Core.CodeGenerator.d__13.MoveNext() in /home/vsts/work/1/s/autorest.common/src/CodeGenerator.cs:line 151
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Core.CodeGenerator.d__12.MoveNext() in /home/vsts/work/1/s/autorest.common/src/CodeGenerator.cs:line 121
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Java.Azure.Fluent.CodeGeneratorJvaf.d__6.MoveNext() in /home/vsts/work/1/s/src/azurefluent/CodeGeneratorJvaf.cs:line 106
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Java.Program.d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 114
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at NewPlugin.d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
FATAL: java/generate - FAILED
FATAL: Error: Plugin java reported failure.
Failure during batch task - {"tag":"package-2019-06-01-preview"} -- Error: Plugin java reported failure..
  Error: Plugin java reported failure.
, {}

openapi-sdkautomation · 2020-03-08T14:21:37Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 0575ac3 with merge commit 39df77d. SDK Automation 13.0.17.20200326.3
️✔️Microsoft.Azure.Management.Synapse [Logs] [Release SDK Changes]
- Microsoft.Azure.Management.Synapse.0.1.0-preview.1.nupkg
- Microsoft.Azure.Management.Synapse.0.1.0-preview.1.snupkg

openapi-sdkautomation · 2020-03-08T14:21:39Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 0575ac3 with merge commit 39df77d. SDK Automation 13.0.17.20200326.3

️✔️@azure/arm-synapse [Logs] [Release SDK Changes]

azure-arm-synapse-1.0.0.tgz

[npmPack] npm WARN lifecycle @azure/arm-synapse@1.0.0~prepack: cannot run in wd @azure/arm-synapse@1.0.0 npm install && npm run build (wd=/z/work/azure-sdk-for-js/sdk/synapse/arm-synapse)

openapi-sdkautomation · 2020-03-08T14:21:39Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 0575ac3 with merge commit 39df77d. SDK Automation 13.0.17.20200326.3

️✔️azure-mgmt-synapse [Logs] [Release SDK Changes]

[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[breaking_change_setup] Cannot uninstall requirement azure-nspkg, not installed
[breaking_change_setup] Command '['/usr/local/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
[ChangeLog] Size of delta 36.832% size of original (original: 110838 chars, delta: 40824 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog]   - Added operation group IntegrationRuntimeAuthKeysOperations
[ChangeLog]   - Added operation group IntegrationRuntimeNodeIpAddressOperations
[ChangeLog]   - Added operation group IntegrationRuntimeCredentialsOperations
[ChangeLog]   - Added operation group IntegrationRuntimeMonitoringDataOperations
[ChangeLog]   - Added operation group IntegrationRuntimesOperations
[ChangeLog]   - Added operation group IntegrationRuntimeObjectMetadataOperations
[ChangeLog]   - Added operation group IntegrationRuntimeConnectionInfosOperations
[ChangeLog]   - Added operation group IntegrationRuntimeStatusOperations
[ChangeLog]   - Added operation group IntegrationRuntimeNodesOperations

azure-pipelines · 2020-03-09T04:27:13Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-09T05:25:25Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-10T10:45:58Z

Azure Pipelines successfully started running 1 pipeline(s).

yungezz · 2020-03-10T11:13:34Z

just curious, why use post get here? #Resolved

If that is the case, then why are the body parameters not modeled in this swagger file?

Hi @anthony-c-martin , I am sorry for giving a wrong reason for why it it post.
I checked with backend team, they said it is a action instead of simply get resource, the action need to be audited and loged. So it is Post instead of Get. Thanks

yungezz · 2020-03-10T11:14:24Z

same as above

same as above

Checked with backend, this api requires parameters to be passed in the body.

fengzhou-msft

LGTM

fengzhou-msft · 2020-03-10T14:30:48Z

Do you have a default value for ttl?

Do you have a default value for ttl?

No

2. add integrationRuntime.json and related example

azure-pipelines · 2020-03-11T03:38:02Z

Azure Pipelines successfully started running 1 pipeline(s).

aim-for-better · 2020-03-11T06:34:17Z

@yungezz , Can we remove WaitForARMFeedback label? ARM team has reviewed integrationRuntime.json and related example in Azure/azure-rest-api-specs-pr#1024

yungezz · 2020-03-11T07:52:23Z

@yungezz , Can we remove WaitForARMFeedback label? ARM team has reviewed integrationRuntime.json and related example in Azure/azure-rest-api-specs-pr#1024

hi @arm-for-better, I compared integrationRuntime.json in this PR with the one in https://github.com/Azure/azure-rest-api-specs-pr/pull/1024/, there're lots of diffs including new operations like "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/integrationRuntimes/{integrationRuntimeName}/disableInteractiveQuery", "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/integrationRuntimes/{integrationRuntimeName}/removeNode": {
, and change on request paramters. This need ARM review again

aim-for-better · 2020-03-11T09:07:10Z

@yungezz , Can we remove WaitForARMFeedback label? ARM team has reviewed integrationRuntime.json and related example in Azure/azure-rest-api-specs-pr#1024

hi @arm-for-better, I compared integrationRuntime.json in this PR with the one in Azure/azure-rest-api-specs-pr#1024, there're lots of diffs including new operations like "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/integrationRuntimes/{integrationRuntimeName}/disableInteractiveQuery", "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/integrationRuntimes/{integrationRuntimeName}/removeNode": {
, and change on request paramters. This need ARM review again

Ok, It makes sense to me.

azure-pipelines · 2020-03-16T10:54:44Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-03-16T12:03:41Z

azure-cli-extensions - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

PhoenixHe-NV · 2020-03-17T01:38:56Z

/azp run

azure-pipelines · 2020-03-17T01:39:14Z

Azure Pipelines successfully started running 3 pipeline(s).

aim-for-better · 2020-03-19T04:36:55Z

@anthony-c-martin could you please help do the ARM review? we are blocked on ARM review for a long time. Thanks in advance.

anthony-c-martin · 2020-03-17T15:39:52Z

 exportdevices
 exporterrors
 exportstatus
+Exprired


?
there is a property named "isIdentityCertExprired"
backend team said it's typo but they can't change it because it will cause breaking change. So in order to pass validation i have to add this as custom word

This review hasn't been signed off on yet, so I don't see how it's possible to have a breaking change. Please ask the backend team to fix this.

@fengzhou-msft, @yungezz is there any way to merge this PR in without adding Exprired to the custom-words list?

@fengzhou-msft, @yungezz is there any way to merge this PR in without adding Exprired to the custom-words list?

Hi @anthony-c-martin I have removed Exprired from the custom-words list and added it to cSpell.json to suppress spell check

anthony-c-martin · 2020-03-20T05:43:03Z

+          "type": "string"
+        }
+      },
+      "additionalProperties": {


What additional properties are allowed here? Can they be modeled in swagger?

What additional properties are allowed here? Can they be modeled in swagger?

checked with backend team, they said it was a work around to keep the sdk compatible because backend returns more properties as time goes.

anthony-c-martin · 2020-03-20T05:44:56Z

If that is the case, then why are the body parameters not modeled in this swagger file?

Hi @anthony-c-martin , I am sorry for giving a wrong reason for why it it post.
I checked with backend team, they said it is a action instead of simply get resource, the action need to be audited and loged. So it is Post instead of Get. Thanks

anthony-c-martin · 2020-03-20T05:45:32Z

+        }
+      }
+    },
+    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/integrationRuntimes/{integrationRuntimeName}/nodes/{nodeName}/ipAddress": {


Please use a verb here - e.g getIpAddress rather than just ipAddress

Please use a verb here - e.g getIpAddress rather than just ipAddress

Hi anthony, change api needs backend team support. The backend just use ipAddress.
Please wait me for checking this with the backend team

Please use a verb here - e.g getIpAddress rather than just ipAddress

Hi @anthony-c-martin I understand your point and I agree with you. But the datafactory is an existing service, synapse reused their some functionality, backend team won't change the api path because the effort is large. Can we ignore this?

azure-pipelines · 2020-03-26T02:47:51Z

Azure Pipelines successfully started running 1 pipeline(s).

aim-for-better · 2020-03-27T03:55:10Z

/azp run

azure-pipelines · 2020-03-27T03:55:29Z

Azure Pipelines successfully started running 3 pipeline(s).

…son (Azure#8628)

openapi-assignment-bot Bot assigned yungezz Mar 8, 2020

aim-for-better force-pushed the UpdateSqlPoolAndIntegrationRuntime branch from 07b2091 to 7bd348f Compare March 9, 2020 04:26

aim-for-better force-pushed the UpdateSqlPoolAndIntegrationRuntime branch from 7bd348f to 0dd8662 Compare March 9, 2020 05:25

aim-for-better requested a review from fengzhou-msft March 9, 2020 06:23

aim-for-better force-pushed the UpdateSqlPoolAndIntegrationRuntime branch from 0dd8662 to afd6796 Compare March 10, 2020 10:45

yungezz reviewed Mar 10, 2020

View reviewed changes

yungezz added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 10, 2020

fengzhou-msft approved these changes Mar 10, 2020

View reviewed changes

1. update sqlPool.json to add 202 response

45d940b

2. add integrationRuntime.json and related example

aim-for-better force-pushed the UpdateSqlPoolAndIntegrationRuntime branch from afd6796 to 45d940b Compare March 11, 2020 03:37

aim-for-better requested a review from anthony-c-martin March 19, 2020 04:36

anthony-c-martin requested changes Mar 20, 2020

View reviewed changes

Remove Exprired from custom-words.txt and add it to cSpell.json

0575ac3

anthony-c-martin added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 26, 2020

anthony-c-martin approved these changes Mar 26, 2020

View reviewed changes

aim-for-better requested a review from yungezz March 26, 2020 16:26

yungezz added Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 potential-sdk-breaking-change labels Mar 27, 2020

yungezz merged commit 39df77d into Azure:master Mar 27, 2020

00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020

[Synapse Management] Update sqlPool.json and add integrationRuntime.j…

0b1756a

…son (Azure#8628)

nschonni mentioned this pull request Jan 24, 2021

Azure Synapse GA API Version #12502

Merged

25 tasks

Conversation

aim-for-better commented Mar 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

azure-pipelines Bot commented Mar 8, 2020

Uh oh!

azure-pipelines Bot commented Mar 8, 2020

Uh oh!

azure-pipelines Bot commented Mar 8, 2020

Uh oh!

azure-pipelines Bot commented Mar 8, 2020

Uh oh!

azure-pipelines Bot commented Mar 8, 2020

Uh oh!

azure-pipelines Bot commented Mar 8, 2020

Uh oh!

azure-pipelines Bot commented Mar 8, 2020

Uh oh!

azuresdkci commented Mar 8, 2020

Uh oh!

azure-pipelines Bot commented Mar 8, 2020

Uh oh!

openapi-sdkautomation Bot commented Mar 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go - Release

Uh oh!

openapi-sdkautomation Bot commented Mar 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java - Release

Uh oh!

openapi-sdkautomation Bot commented Mar 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net - Release

Uh oh!

openapi-sdkautomation Bot commented Mar 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js - Release

Uh oh!

openapi-sdkautomation Bot commented Mar 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python - Release

Uh oh!

azure-pipelines Bot commented Mar 9, 2020

Uh oh!

azure-pipelines Bot commented Mar 9, 2020

Uh oh!

azure-pipelines Bot commented Mar 10, 2020

Uh oh!

yungezz Mar 10, 2020 • edited by aim-for-better Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anthony-c-martin Mar 20, 2020 • edited by aim-for-better Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fengzhou-msft left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

azure-pipelines Bot commented Mar 11, 2020

Uh oh!

aim-for-better commented Mar 11, 2020

Uh oh!

yungezz commented Mar 11, 2020

Uh oh!

aim-for-better commented Mar 11, 2020

Uh oh!

azure-pipelines Bot commented Mar 16, 2020

Uh oh!

aim-for-better commented Mar 8, 2020 •

edited

Loading

openapi-sdkautomation Bot commented Mar 8, 2020 •

edited

Loading

openapi-sdkautomation Bot commented Mar 8, 2020 •

edited

Loading

openapi-sdkautomation Bot commented Mar 8, 2020 •

edited

Loading

openapi-sdkautomation Bot commented Mar 8, 2020 •

edited

Loading

openapi-sdkautomation Bot commented Mar 8, 2020 •

edited

Loading

yungezz Mar 10, 2020 •

edited by aim-for-better

Loading

anthony-c-martin Mar 20, 2020 •

edited by aim-for-better

Loading

openapi-sdkautomation Bot commented Mar 16, 2020 •

edited

Loading

aim-for-better Mar 20, 2020 •

edited

Loading

aim-for-better Mar 23, 2020 •

edited

Loading

anthony-c-martin Mar 20, 2020 •

edited by aim-for-better

Loading

aim-for-better Mar 20, 2020 •

edited

Loading