Skip to content

Adding the hostnames camelCasing naming convention for python sdk generation#8605

Closed
sobaner-zz wants to merge 1 commit intoAzure:masterfrom
sobaner-zz:appgwwclistener
Closed

Adding the hostnames camelCasing naming convention for python sdk generation#8605
sobaner-zz wants to merge 1 commit intoAzure:masterfrom
sobaner-zz:appgwwclistener

Conversation

@sobaner-zz
Copy link

@sobaner-zz sobaner-zz commented Mar 5, 2020

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

3 similar comments
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

Copy link
Contributor

@anton-evseev anton-evseev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bugfix, so it shouldn't be considered breaking change

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 5, 2020

azure-sdk-for-go

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 6e7eb8d with merge commit cd124398bbc71fee882b75a8a72837112efc1ee3. SDK Automation 13.0.17.20191226.1
  • ⚠️network/mgmt/2015-06-15 [Logs
      No file is changed.
    • ⚠️network/mgmt/2016-03-30 [Logs
        No file is changed.
      • ⚠️network/mgmt/2016-06-01 [Logs
          No file is changed.
        • ️✔️network/mgmt/2016-09-01 [Logs]  [Preview SDK Changes]
        • ️✔️network/mgmt/2016-12-01 [Logs]  [Preview SDK Changes]
        • ⚠️network/mgmt/2017-03-01 [Logs
            No file is changed.
          • ⚠️network/mgmt/2017-06-01 [Logs
              No file is changed.
            • ⚠️network/mgmt/2017-08-01 [Logs
                No file is changed.
              • ⚠️network/mgmt/2017-09-01 [Logs
                  No file is changed.
                • ⚠️network/mgmt/2017-10-01 [Logs
                    No file is changed.
                  • ⚠️network/mgmt/2017-11-01 [Logs
                      No file is changed.
                    • ⚠️network/mgmt/2018-01-01 [Logs
                        No file is changed.
                      • ⚠️network/mgmt/2018-02-01 [Logs
                          No file is changed.
                        • ⚠️network/mgmt/2018-04-01 [Logs
                            No file is changed.
                          • ⚠️network/mgmt/2018-06-01 [Logs
                              No file is changed.
                            • ⚠️network/mgmt/2018-07-01 [Logs
                                No file is changed.
                              • ⚠️network/mgmt/2018-08-01 [Logs
                                  No file is changed.
                                • ⚠️network/mgmt/2018-10-01 [Logs
                                    No file is changed.
                                  • ⚠️network/mgmt/2018-11-01 [Logs
                                      No file is changed.
                                    • ⚠️network/mgmt/2018-12-01 [Logs
                                        No file is changed.
                                      • ⚠️network/mgmt/2019-02-01 [Logs
                                          No file is changed.
                                        • ⚠️network/mgmt/2019-04-01 [Logs
                                            No file is changed.
                                          • ⚠️network/mgmt/2019-06-01 [Logs
                                              No file is changed.
                                            • ⚠️network/mgmt/2019-07-01 [Logs
                                                No file is changed.
                                              • ⚠️network/mgmt/2019-08-01 [Logs
                                                  No file is changed.
                                                • ⚠️network/mgmt/2019-09-01 [Logs
                                                    No file is changed.
                                                  • ️✔️network/mgmt/2019-11-01 [Logs]  [Preview SDK Changes]
                                                  • ⚠️preview/network/mgmt/2015-05-01-preview [Logs
                                                      No file is changed.

                                                    @openapi-sdkautomation
                                                    Copy link

                                                    openapi-sdkautomation bot commented Mar 5, 2020

                                                    azure-sdk-for-java

                                                    ⚠️ warning [Logs] [Expand Details]
                                                    • ⚠️ Generate from 6e7eb8d with merge commit cd124398bbc71fee882b75a8a72837112efc1ee3. SDK Automation 13.0.17.20191226.1
                                                    • ️✔️sdk/network/mgmt-v2019_02_01 [Logs]  [Preview SDK Changes]
                                                    • ⚠️sdk/network/mgmt-v2019_04_01 [Logs]  [Preview SDK Changes]
                                                        [mvn] [ERROR] COMPILATION ERROR : 
                                                        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_04_01/src/main/java/com/microsoft/azure/management/network/v2019_04_01/implementation/LocationAvailablePrivateEndpointTypeModelImpl.java:[37,28] cannot find symbol
                                                        [mvn]   symbol:   method serviceName()
                                                        [mvn]   location: class com.microsoft.azure.management.network.v2019_04_01.implementation.AvailablePrivateEndpointTypeInner
                                                        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_04_01/src/main/java/com/microsoft/azure/management/network/v2019_04_01/implementation/LocationAvailablePrivateEndpointTypeImpl.java:[37,28] cannot find symbol
                                                        [mvn]   symbol:   method serviceName()
                                                        [mvn]   location: class com.microsoft.azure.management.network.v2019_04_01.implementation.AvailablePrivateEndpointTypeInner
                                                        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_04_01/src/main/java/com/microsoft/azure/management/network/v2019_04_01/implementation/AvailableResourceGroupPrivateEndpointTypesImpl.java:[23,30] cannot find symbol
                                                        [mvn]   symbol:   method availableResourceGroupPrivateEndpointTypes()
                                                        [mvn]   location: class com.microsoft.azure.management.network.v2019_04_01.implementation.NetworkManagementClientImpl
                                                        [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-network: Compilation failure: Compilation failure: 
                                                        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_04_01/src/main/java/com/microsoft/azure/management/network/v2019_04_01/implementation/LocationAvailablePrivateEndpointTypeModelImpl.java:[37,28] cannot find symbol
                                                        [mvn] [ERROR]   symbol:   method serviceName()
                                                        [mvn] [ERROR]   location: class com.microsoft.azure.management.network.v2019_04_01.implementation.AvailablePrivateEndpointTypeInner
                                                        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_04_01/src/main/java/com/microsoft/azure/management/network/v2019_04_01/implementation/LocationAvailablePrivateEndpointTypeImpl.java:[37,28] cannot find symbol
                                                        [mvn] [ERROR]   symbol:   method serviceName()
                                                        [mvn] [ERROR]   location: class com.microsoft.azure.management.network.v2019_04_01.implementation.AvailablePrivateEndpointTypeInner
                                                        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_04_01/src/main/java/com/microsoft/azure/management/network/v2019_04_01/implementation/AvailableResourceGroupPrivateEndpointTypesImpl.java:[23,30] cannot find symbol
                                                        [mvn] [ERROR]   symbol:   method availableResourceGroupPrivateEndpointTypes()
                                                        [mvn] [ERROR]   location: class com.microsoft.azure.management.network.v2019_04_01.implementation.NetworkManagementClientImpl
                                                        [mvn] [ERROR] -> [Help 1]
                                                        [mvn] [ERROR] 
                                                        [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
                                                        [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
                                                        [mvn] [ERROR] 
                                                        [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
                                                        [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
                                                      • ️✔️sdk/network/mgmt-v2019_06_01 [Logs]  [Preview SDK Changes]
                                                      • ️✔️sdk/network/mgmt-v2019_07_01 [Logs]  [Preview SDK Changes]
                                                      • ️✔️sdk/network/mgmt-v2019_08_01 [Logs]  [Preview SDK Changes]
                                                      • ⚠️sdk/network/mgmt-v2019_09_01 [Logs]  [Preview SDK Changes]
                                                          [mvn] [ERROR] COMPILATION ERROR : 
                                                          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_09_01/src/main/java/com/microsoft/azure/management/network/v2019_09_01/Subnet.java:[108,10] cannot find symbol
                                                          [mvn]   symbol:   class ResourceNavigationLinkInner
                                                          [mvn]   location: interface com.microsoft.azure.management.network.v2019_09_01.Subnet
                                                          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_09_01/src/main/java/com/microsoft/azure/management/network/v2019_09_01/Subnet.java:[118,10] cannot find symbol
                                                          [mvn]   symbol:   class ServiceAssociationLinkInner
                                                          [mvn]   location: interface com.microsoft.azure.management.network.v2019_09_01.Subnet
                                                          [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-network: Compilation failure: Compilation failure: 
                                                          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_09_01/src/main/java/com/microsoft/azure/management/network/v2019_09_01/Subnet.java:[108,10] cannot find symbol
                                                          [mvn] [ERROR]   symbol:   class ResourceNavigationLinkInner
                                                          [mvn] [ERROR]   location: interface com.microsoft.azure.management.network.v2019_09_01.Subnet
                                                          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_09_01/src/main/java/com/microsoft/azure/management/network/v2019_09_01/Subnet.java:[118,10] cannot find symbol
                                                          [mvn] [ERROR]   symbol:   class ServiceAssociationLinkInner
                                                          [mvn] [ERROR]   location: interface com.microsoft.azure.management.network.v2019_09_01.Subnet
                                                          [mvn] [ERROR] -> [Help 1]
                                                          [mvn] [ERROR] 
                                                          [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
                                                          [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
                                                          [mvn] [ERROR] 
                                                          [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
                                                          [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

                                                        @openapi-sdkautomation
                                                        Copy link

                                                        openapi-sdkautomation bot commented Mar 5, 2020

                                                        azure-sdk-for-js

                                                        ️✔️ succeeded [Logs] [Expand Details]
                                                        • ️✔️ Generate from 6e7eb8d with merge commit cd124398bbc71fee882b75a8a72837112efc1ee3. SDK Automation 13.0.17.20191226.1
                                                        • ️✔️@azure/arm-network [Logs]  [Preview SDK Changes]
                                                          [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
                                                          [npmPack] loaded rollup.config.js with warnings
                                                          [npmPack] (!) Unused external imports
                                                          [npmPack] default imported from external module 'rollup' but never used
                                                          [npmPack] 
                                                          [npmPack] ./esm/networkManagementClient.js → ./dist/arm-network.js...
                                                          [npmPack] created ./dist/arm-network.js in 2.3s

                                                        @openapi-sdkautomation
                                                        Copy link

                                                        openapi-sdkautomation bot commented Mar 5, 2020

                                                        azure-sdk-for-net

                                                        🔄 inProgress [Logs] [Expand Details]
                                                        • 🔄 Generate from 6e7eb8d with merge commit cd124398bbc71fee882b75a8a72837112efc1ee3. SDK Automation 13.0.17.20191226.1

                                                        @openapi-sdkautomation
                                                        Copy link

                                                        openapi-sdkautomation bot commented Mar 5, 2020

                                                        azure-sdk-for-python

                                                        ️✔️ succeeded [Logs] [Expand Details]
                                                        • ️✔️ Generate from 6e7eb8d with merge commit cd124398bbc71fee882b75a8a72837112efc1ee3. SDK Automation 13.0.17.20191226.1
                                                        • ️✔️azure-mgmt-network [Logs]  [Preview SDK Changes]
                                                          [after_scripts|python] WARNING:__main__:Found too much API version: {'2016-09-01', '2016-12-01'} in label v2016_12_01
                                                          [after_scripts|python] WARNING:__main__:Guessing you want 2016-12-01 based on label v2016_12_01
                                                          [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-01', '2017-03-30'} in label v2017_03_01
                                                          [after_scripts|python] WARNING:__main__:Guessing you want 2017-03-01 based on label v2017_03_01
                                                          [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2017-06-01'} in label v2017_06_01
                                                          [after_scripts|python] WARNING:__main__:Guessing you want 2017-06-01 based on label v2017_06_01
                                                          [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2017-08-01'} in label v2017_08_01
                                                          [after_scripts|python] WARNING:__main__:Guessing you want 2017-08-01 based on label v2017_08_01
                                                          [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-09-01', '2017-03-30'} in label v2017_09_01
                                                          [after_scripts|python] WARNING:__main__:Guessing you want 2017-09-01 based on label v2017_09_01
                                                          [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2017-10-01'} in label v2017_10_01
                                                          [after_scripts|python] WARNING:__main__:Guessing you want 2017-10-01 based on label v2017_10_01
                                                          [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2017-11-01'} in label v2017_11_01
                                                          [after_scripts|python] WARNING:__main__:Guessing you want 2017-11-01 based on label v2017_11_01
                                                          [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2018-01-01'} in label v2018_01_01
                                                          [after_scripts|python] WARNING:__main__:Guessing you want 2018-01-01 based on label v2018_01_01
                                                          [after_scripts|python] WARNING:__main__:Found too much API version: {'2018-02-01', '2017-03-30'} in label v2018_02_01
                                                          [after_scripts|python] WARNING:__main__:Guessing you want 2018-02-01 based on label v2018_02_01
                                                          [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2018-04-01'} in label v2018_04_01
                                                          [after_scripts|python] WARNING:__main__:Guessing you want 2018-04-01 based on label v2018_04_01
                                                          [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2018-06-01'} in label v2018_06_01
                                                          [after_scripts|python] WARNING:__main__:Guessing you want 2018-06-01 based on label v2018_06_01
                                                          [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2018-07-01'} in label v2018_07_01
                                                          [after_scripts|python] WARNING:__main__:Guessing you want 2018-07-01 based on label v2018_07_01
                                                          [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2018-08-01'} in label v2018_08_01
                                                          [after_scripts|python] WARNING:__main__:Guessing you want 2018-08-01 based on label v2018_08_01
                                                          [after_scripts|python] WARNING:__main__:Found too much API version: {'2018-10-01', '2017-03-30'} in label v2018_10_01
                                                          [after_scripts|python] WARNING:__main__:Guessing you want 2018-10-01 based on label v2018_10_01
                                                          [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2018-11-01'} in label v2018_11_01
                                                          [after_scripts|python] WARNING:__main__:Guessing you want 2018-11-01 based on label v2018_11_01
                                                          [after_scripts|python] WARNING:__main__:Found too much API version: {'2018-12-01', '2017-03-30'} in label v2018_12_01
                                                          [after_scripts|python] WARNING:__main__:Guessing you want 2018-12-01 based on label v2018_12_01
                                                          [after_scripts|python] WARNING:__main__:Found too much API version: {'2019-02-01', '2017-03-30'} in label v2019_02_01
                                                          [after_scripts|python] WARNING:__main__:Guessing you want 2019-02-01 based on label v2019_02_01
                                                          [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2019-04-01'} in label v2019_04_01
                                                          [after_scripts|python] WARNING:__main__:Guessing you want 2019-04-01 based on label v2019_04_01
                                                          [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2019-06-01'} in label v2019_06_01
                                                          [after_scripts|python] WARNING:__main__:Guessing you want 2019-06-01 based on label v2019_06_01
                                                          [after_scripts|python] WARNING:__main__:Found too much API version: {'2018-10-01', '2019-07-01', '2019-06-01'} in label v2019_07_01
                                                          [after_scripts|python] WARNING:__main__:Guessing you want 2019-07-01 based on label v2019_07_01
                                                          [after_scripts|python] WARNING:__main__:Found too much API version: {'2018-10-01', '2019-08-01', '2019-06-01'} in label v2019_08_01
                                                          [after_scripts|python] WARNING:__main__:Guessing you want 2019-08-01 based on label v2019_08_01
                                                          [after_scripts|python] WARNING:__main__:Found too much API version: {'2019-09-01', '2018-10-01', '2019-06-01'} in label v2019_09_01
                                                          [after_scripts|python] WARNING:__main__:Guessing you want 2019-09-01 based on label v2019_09_01
                                                          [after_scripts|python] WARNING:__main__:Found too much API version: {'2018-10-01', '2019-11-01'} in label v2019_11_01
                                                          [after_scripts|python] WARNING:__main__:Guessing you want 2019-11-01 based on label v2019_11_01
                                                          [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
                                                          [build_package]   warnings.warn(msg)
                                                          [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
                                                          [build_package]   warnings.warn(msg)

                                                        @leniatgh
                                                        Copy link
                                                        Contributor

                                                        leniatgh commented Mar 9, 2020

                                                        @lirenhe @zikalino Per discussion in mail, this PR is duplicated with #8603. So close this one.

                                                        @leniatgh leniatgh closed this Mar 9, 2020
                                                        Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

                                                        Labels

                                                        None yet

                                                        Projects

                                                        None yet

                                                        Development

                                                        Successfully merging this pull request may close these issues.

                                                        6 participants