[Storage CMK Key Vault Key Auto Rotation] Add read-only properties for current versioned key in use and last rotation timestamp. by tonykjose · Pull Request #8585 · Azure/azure-rest-api-specs

tonykjose · 2020-03-03T23:02:09Z

…r current versioned key in use and last rotation timestamp.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

…r current versioned key in use and last rotation timestamp.

azure-pipelines · 2020-03-03T23:02:25Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-03T23:02:33Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-03T23:02:35Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-03T23:02:36Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-03T23:02:40Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-03T23:02:42Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-03-03T23:03:44Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 6647d5d with merge commit 70c460b. SDK Automation 13.0.17.20200311.2

️✔️@azure/arm-storage [Logs] [Release SDK Changes]

azure-arm-storage-13.1.0.tgz

[npmPack] npm WARN lifecycle @azure/arm-storage@13.1.0~prepack: cannot run in wd @azure/arm-storage@13.1.0 npm install && npm run build (wd=/z/work/azure-sdk-for-js/sdk/storage/arm-storage)

openapi-sdkautomation · 2020-03-03T23:03:47Z

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 6647d5d with merge commit 70c460b. SDK Automation 13.0.17.20200311.2
⚠️preview/storage/mgmt/2015-05-01-preview [Logs]
```
No file is changed.
```
⚠️preview/storage/mgmt/2018-03-01-preview [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2015-06-15 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2016-01-01 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2016-05-01 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2016-12-01 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2017-06-01 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2017-10-01 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2018-02-01 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2018-07-01 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2018-11-01 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2019-04-01 [Logs]
```
No file is changed.
```
️✔️storage/mgmt/2019-06-01 [Logs] [Release SDK Changes]
- storage.mgmt.2019-06-01.zip

openapi-sdkautomation · 2020-03-03T23:03:47Z

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 6647d5d with merge commit 70c460b. SDK Automation 13.0.17.20200311.2
️✔️sdk/storage/mgmt-v2016_01_01 [Logs] [Release SDK Changes]
️✔️sdk/storage/mgmt-v2017_10_01 [Logs] [Release SDK Changes]
️✔️sdk/storage/mgmt-v2018_02_01 [Logs] [Release SDK Changes]
️✔️sdk/storage/mgmt-v2018_03_01_preview [Logs] [Release SDK Changes]
️✔️sdk/storage/mgmt-v2018_07_01 [Logs] [Release SDK Changes]
️✔️sdk/storage/mgmt-v2019_04_01 [Logs] [Release SDK Changes]

⚠️sdk/storage/mgmt-v2019_06_01 [Logs] [Release SDK Changes]

[mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storage/mgmt-v2019_06_01/src/main/java/com/microsoft/azure/management/storage/v2019_06_01/BlobServiceProperties.java:[78,5] cannot find symbol
[mvn]   symbol:   class SkuInner
[mvn]   location: interface com.microsoft.azure.management.storage.v2019_06_01.BlobServiceProperties
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storage/mgmt-v2019_06_01/src/main/java/com/microsoft/azure/management/storage/v2019_06_01/FileServiceProperties.java:[49,5] cannot find symbol
[mvn]   symbol:   class SkuInner
[mvn]   location: interface com.microsoft.azure.management.storage.v2019_06_01.FileServiceProperties
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-storage: Compilation failure: Compilation failure: 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storage/mgmt-v2019_06_01/src/main/java/com/microsoft/azure/management/storage/v2019_06_01/BlobServiceProperties.java:[78,5] cannot find symbol
[mvn] [ERROR]   symbol:   class SkuInner
[mvn] [ERROR]   location: interface com.microsoft.azure.management.storage.v2019_06_01.BlobServiceProperties
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storage/mgmt-v2019_06_01/src/main/java/com/microsoft/azure/management/storage/v2019_06_01/FileServiceProperties.java:[49,5] cannot find symbol
[mvn] [ERROR]   symbol:   class SkuInner
[mvn] [ERROR]   location: interface com.microsoft.azure.management.storage.v2019_06_01.FileServiceProperties
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

openapi-sdkautomation · 2020-03-03T23:03:50Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 6647d5d with merge commit 70c460b. SDK Automation 13.0.17.20200311.2

️✔️azure-mgmt-storage [Logs] [Release SDK Changes]

[after_scripts|python] WARNING:__main__:Found too much API version: {'2018-07-01', '2018-03-01-preview'} in label v2018_07_01
[after_scripts|python] WARNING:__main__:Guessing you want 2018-07-01 based on label v2018_07_01
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[breaking_change_setup] Cannot uninstall requirement azure-nspkg, not installed
[breaking_change_setup] Command '['/usr/local/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
[ChangeLog] Size of delta 0.549% size of original (original: 70613 chars, delta: 388 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog] - Model KeyVaultProperties has a new parameter last_key_rotation_timestamp
[ChangeLog] - Model KeyVaultProperties has a new parameter current_versioned_key_identifier

openapi-sdkautomation · 2020-03-03T23:03:53Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 6647d5d with merge commit 70c460b. SDK Automation 13.0.17.20200311.2
️✔️Microsoft.Azure.Management.Storage [Logs] [Release SDK Changes]

azuresdkci · 2020-03-03T23:05:35Z

Can one of the admins verify this patch?

blueww · 2020-03-05T02:43:09Z

specification/storage/resource-manager/Microsoft.Storage/stable/2019-06-01/storage.json

          "type": "string",
          "description": "The Uri of KeyVault.",
          "x-ms-client-name": "KeyVaultUri"
+        },


Please add example for it, include create/update/get/list account.

yes. example is required.

In reply to: 388050640 [](ancestors = 388050640)

Once examples are added, I will merge this PR.

Added example

@tonykjose Please fix the CI errors. PrettierCheck can be fixed by adding the word into https://github.com/Azure/azure-rest-api-specs/blob/master/custom-words.txt

Fixed and updated.

azure-pipelines · 2020-03-13T23:04:11Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-18T00:40:11Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-03-18T00:41:33Z

azure-cli-extensions - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azure-pipelines · 2020-03-18T00:53:29Z

Azure Pipelines successfully started running 1 pipeline(s).

…r current versioned key in use and last rotation timestamp. (Azure#8585) * [Storage CMK Key Vault Key Auto Rotation] Add read-only properties for current versioned key in use and last rotation timestamp. * Include example for storage account Customer Managed Keys enable. * Add more examples and fix avocado checks. * Fix model validation failures.

[Storage CMK Key Vault Key Auto Rotation] Add read-only properties fo…

0ca637c

…r current versioned key in use and last rotation timestamp.

openapi-assignment-bot bot assigned mmyyrroonn Mar 3, 2020

openapi-sdkautomation bot mentioned this pull request Mar 3, 2020

[AutoPR @azure/arm-storage] [Storage CMK Key Vault Key Auto Rotation] Add read-only properties for current versioned key in use and last rotation timestamp. AzureSDKAutomation/azure-sdk-for-js#720

Closed

mmyyrroonn added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 4, 2020

mmyyrroonn approved these changes Mar 4, 2020

View reviewed changes

blueww reviewed Mar 5, 2020

View reviewed changes

sanjaiganesh added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 7, 2020

Include example for storage account Customer Managed Keys enable.

0370907

tonykjose requested a review from JasonYang-MSFT as a code owner March 13, 2020 23:03

Add more examples and fix avocado checks.

7427416

Fix model validation failures.

6647d5d

mmyyrroonn merged commit 70c460b into Azure:master Mar 19, 2020

Conversation

tonykjose commented Mar 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

azure-pipelines bot commented Mar 3, 2020

Uh oh!

azure-pipelines bot commented Mar 3, 2020

Uh oh!

azure-pipelines bot commented Mar 3, 2020

Uh oh!

azure-pipelines bot commented Mar 3, 2020

Uh oh!

azure-pipelines bot commented Mar 3, 2020

Uh oh!

azure-pipelines bot commented Mar 3, 2020

Uh oh!

openapi-sdkautomation bot commented Mar 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js - Release

Uh oh!

openapi-sdkautomation bot commented Mar 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go - Release

Uh oh!

openapi-sdkautomation bot commented Mar 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java - Release

Uh oh!

openapi-sdkautomation bot commented Mar 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python - Release

Uh oh!

openapi-sdkautomation bot commented Mar 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net - Release

Uh oh!

azuresdkci commented Mar 3, 2020

Uh oh!

blueww Mar 5, 2020

Choose a reason for hiding this comment

Uh oh!

sanjaiganesh Mar 7, 2020

Choose a reason for hiding this comment

Uh oh!

mmyyrroonn Mar 9, 2020

Choose a reason for hiding this comment

Uh oh!

tonykjose Mar 13, 2020

Choose a reason for hiding this comment

Uh oh!

mmyyrroonn Mar 16, 2020

Choose a reason for hiding this comment

Uh oh!

tonykjose Mar 18, 2020

Choose a reason for hiding this comment

Uh oh!

azure-pipelines bot commented Mar 13, 2020

Uh oh!

azure-pipelines bot commented Mar 18, 2020

Uh oh!

openapi-sdkautomation bot commented Mar 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-cli-extensions - Release

Uh oh!

azure-pipelines bot commented Mar 18, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments

tonykjose commented Mar 3, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 3, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 3, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 3, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 3, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 3, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 18, 2020 •

edited

Loading