Skip to content

[READY FOR REVIEW] AzureML - Added private link related properties in GetWorkspace#8575

Closed
guanyu-240 wants to merge 13 commits intoAzure:masterfrom
guanyu-240:mlws_0302
Closed

[READY FOR REVIEW] AzureML - Added private link related properties in GetWorkspace#8575
guanyu-240 wants to merge 13 commits intoAzure:masterfrom
guanyu-240:mlws_0302

Conversation

@guanyu-240
Copy link
Copy Markdown
Contributor

@guanyu-240 guanyu-240 commented Mar 3, 2020

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Mar 3, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@guanyu-240 guanyu-240 changed the title Mlws 0302 AzureML - Added private link related properties in GetWorkspace Mar 3, 2020
@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Mar 3, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation bot commented Mar 3, 2020 •
edited
Loading

azure-sdk-for-java

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation bot commented Mar 3, 2020 •
edited
Loading

azure-sdk-for-js

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 0ab261a with merge commit d6fd145666bbd307fac36747125e8b67c927a9db. SDK Automation 13.0.17.20191226.1
  • ️✔️@azure/arm-machinelearningservices [Logs]  [Preview SDK Changes] 
    [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/azureMachineLearningWorkspaces.js → ./dist/arm-machinelearningservices.js...
[npmPack] created ./dist/arm-machinelearningservices.js in 506ms

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation bot commented Mar 3, 2020 •
edited
Loading

azure-sdk-for-go

⚠️ warning [Logs] [Expand Details]

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation bot commented Mar 3, 2020 •
edited
Loading

azure-sdk-for-net

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 0ab261a with merge commit d6fd145666bbd307fac36747125e8b67c927a9db. SDK Automation 13.0.17.20191226.1 
    [AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
  • ️✔️Microsoft.Azure.Management.MachineLearningServices [Logs]  [Preview SDK Changes]
      No Artifact Generated.

    @openapi-sdkautomation
    Copy link
    Copy Markdown

    openapi-sdkautomation bot commented Mar 3, 2020 •
    edited
    Loading

    azure-sdk-for-python

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from 0ab261a with merge commit d6fd145666bbd307fac36747125e8b67c927a9db. SDK Automation 13.0.17.20191226.1
    • ️✔️azure-mgmt-machinelearningservices [Logs]  [Preview SDK Changes] 
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'

    @azuresdkci
    Copy link
    Copy Markdown
    Contributor

    azuresdkci commented Mar 3, 2020

    Can one of the admins verify this patch?

    This was referenced Mar 3, 2020
    Open
    Open
    Open
    @azure-pipelines
    Copy link
    Copy Markdown

    azure-pipelines bot commented Mar 3, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link
    Copy Markdown

    azure-pipelines bot commented Mar 3, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link
    Copy Markdown

    azure-pipelines bot commented Mar 4, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link
    Copy Markdown

    azure-pipelines bot commented Mar 4, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link
    Copy Markdown

    azure-pipelines bot commented Mar 4, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link
    Copy Markdown

    azure-pipelines bot commented Mar 4, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link
    Copy Markdown

    azure-pipelines bot commented Mar 4, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    @guanyu-240 guanyu-240 changed the title AzureML - Added private link related properties in GetWorkspace [READY TO REVIEW] AzureML - Added private link related properties in GetWorkspace Mar 4, 2020
    @azure-pipelines
    Copy link
    Copy Markdown

    azure-pipelines bot commented Mar 4, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    @guanyu-240 guanyu-240 changed the title [READY TO REVIEW] AzureML - Added private link related properties in GetWorkspace AzureML - Added private link related properties in GetWorkspace Mar 4, 2020
    @azure-pipelines
    Copy link
    Copy Markdown

    azure-pipelines bot commented Mar 4, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    @leniatgh leniatgh added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 4, 2020
    @guanyu-240 guanyu-240 changed the title AzureML - Added private link related properties in GetWorkspace [READY FOR REVIEW] AzureML - Added private link related properties in GetWorkspace Mar 5, 2020
    @azure-pipelines
    Copy link
    Copy Markdown

    azure-pipelines bot commented Mar 5, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link
    Copy Markdown

    azure-pipelines bot commented Mar 5, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    @guanyu-240 guanyu-240 closed this Mar 5, 2020
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    No reviews

    Assignees

    @leniatgh leniatgh

    Labels

    WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    3 participants

    @guanyu-240 @azuresdkci @leniatgh