[CDN] Add stable API version 2019-06-15 based on 2019-06-15-preview #8573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fore5fire
added
the
WaitForARMFeedback
|
Azure Pipelines successfully started running 1 pipeline(s). |
fore5fire
changed the title
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-go - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-java - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-python - Release
|
This was referenced Mar 2, 2020
Contributor
|
Can one of the admins verify this patch? |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@lsmith130 Hi. See you again. 😄 Just wonder, is the stable version same with the existing 2019-06-15-preview in this PR? You will modify the stable version later. Am I right? |
mmyyrroonn
reviewed
Mar 5, 2020
Contributor
There was a problem hiding this comment.
Is this the change for preview version?
Contributor
Author
There was a problem hiding this comment.
This change is for both the preview and stable versions. Removing Country is not a breaking change because Country was originally added by mistake and was never supported by our service. SocketAddr is needed for our public preview, so we're including it in the preview version as well as stable.
…tatusCode examples.
fore5fire
force-pushed
the
cdn-2019-06-15
branch
from
62ab76c to
ae84ad2
Compare
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
Hello again! That's correct, we're creating a stable version that's identical to the preview version for now, and if needed we'll make any backwards compatible changes needed for the stable version in future PRs. |
mmyyrroonn
approved these changes
Mar 16, 2020
Contributor
mmyyrroonn
left a comment
mmyyrroonn
left a comment
There was a problem hiding this comment.
approved since it's the copy of the preview version
Contributor
|
/azp run automation - sdk |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
Thanks for approving @myronfanqiu. Looks like the small changes I made to the preview API version is flagging as a breaking change, but they only remove options that were already not working because of mistakes in the original preview API version PR. How can I get this merged with the breaking changes check failing? |
Contributor
|
@raych1 Hi. Could you help on the CI issue? @lsmith130 wants to force merge this PR. well. we still need to wait for ARM's review. |
Member
|
@myronfanqiu , you could ignore the |
mmyyrroonn
added
Breaking Change Review
ARM-overdue
pilor
added
ARMSignedOff
pilor
approved these changes
Mar 23, 2020
mmyyrroonn
added
Approved-BreakingChange
Contributor
|
@akning-ms Hi~ Could you help us force merge this PR since there is a breaking change. |
Contributor
|
Contributor
|
/azp run public.rest-api-specs |
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-cli-extensions - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
…zure#8573) * Add missing "SocketAddr" match variable to CDN WAF preview API version * Use enum for CDN WAF defaultCustomBlockResponseStatus to allow only valid options. * Add CDN api version 2019-06-15 * Fix CDN 2019-06-15 and 2019-06-15-preview defaultCustomBlockResponseStatusCode examples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CDN API Version 2019-06-15 is an as-is copy of 2019-06-15-preview which has already been reviewed, approved, and merged into master. This PR includes two small changes to fix issues with 2019-06-15-preview (and the new 2019-06-15 by extension), and is backwards compatible because all removed options do not work in our service anyway.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.