-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Adding APIs for private link #8540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
2300b2a
Adding APIs for private link
juniwang 7f0ef84
fix valiation errors
juniwang 554c5a4
update privateLinkResources to comply ARM standard
juniwang b24105d
commit prettier changes
juniwang 5622aa8
adding Kind
juniwang 50228cb
run prettier check
juniwang aa256b1
Move from top-level Resource to SignalRResource since it's SignalR-s…
juniwang a0d26ab
fix typo
juniwang a16b59c
using camel case
juniwang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62 changes: 62 additions & 0 deletions
62
...t.SignalRService/stable/2018-10-01/examples/SignalRPrivateEndpointConnections_Create.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| { | ||
| "parameters": { | ||
| "parameters": { | ||
| "properties": { | ||
| "privateEndpoint": { | ||
| "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/myResourceGroup/providers/Microsoft.Network/privateEndpoints/myPrivateEndpoint" | ||
| }, | ||
| "privateLinkServiceConnectionState": { | ||
| "status": "Approved", | ||
| "description": null, | ||
| "actionsRequired": "None" | ||
| } | ||
| } | ||
| }, | ||
| "api-version": "2018-10-01", | ||
| "subscriptionId": "00000000-0000-0000-0000-000000000000", | ||
| "resourceGroupName": "myResourceGroup", | ||
| "resourceName": "mySignalRService", | ||
| "privateEndpointConnectionName": "mySignalRService.1fa229cd-bf3f-47f0-8c49-afb36723997e" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "properties": { | ||
| "provisioningState": "Succeeded", | ||
| "privateEndpoint": { | ||
| "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/myResourceGroup/providers/Microsoft.Network/privateEndpoints/myPrivateEndpoint" | ||
| }, | ||
| "privateLinkServiceConnectionState": { | ||
| "status": "Approved", | ||
| "description": null, | ||
| "actionsRequired": "None" | ||
| } | ||
| }, | ||
| "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/myResourceGroup/providers/Microsoft.SignalRService/SignalR/mySignalRService/privateEndpointConnections/mySignalRService.1fa229cd-bf3f-47f0-8c49-afb36723997e", | ||
| "name": "mySignalRService.1fa229cd-bf3f-47f0-8c49-afb36723997e", | ||
| "type": "Microsoft.SignalRService/SignalR/privateEndpointConnections" | ||
| } | ||
| }, | ||
| "201": { | ||
| "body": { | ||
| "properties": { | ||
| "provisioningState": "Succeeded", | ||
| "privateEndpoint": { | ||
| "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/myResourceGroup/providers/Microsoft.Network/privateEndpoints/myPrivateEndpoint" | ||
| }, | ||
| "privateLinkServiceConnectionState": { | ||
| "status": "Approved", | ||
| "description": null, | ||
| "actionsRequired": "None" | ||
| } | ||
| }, | ||
| "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/myResourceGroup/providers/Microsoft.SignalRService/SignalR/mySignalRService/privateEndpointConnections/mySignalRService.1fa229cd-bf3f-47f0-8c49-afb36723997e", | ||
| "name": "mySignalRService.1fa229cd-bf3f-47f0-8c49-afb36723997e", | ||
| "type": "Microsoft.SignalRService/SignalR/privateEndpointConnections" | ||
| }, | ||
| "headers": { | ||
| "Location": "https://management.azure.com/subscriptions/subid/providers/Microsoft.SignalRService/...pathToOperationResult..." | ||
| } | ||
| } | ||
| } | ||
| } | ||
17 changes: 17 additions & 0 deletions
17
...t.SignalRService/stable/2018-10-01/examples/SignalRPrivateEndpointConnections_Delete.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "parameters": { | ||
| "api-version": "2018-10-01", | ||
| "subscriptionId": "00000000-0000-0000-0000-000000000000", | ||
| "resourceGroupName": "myResourceGroup", | ||
| "resourceName": "mySignalRService", | ||
| "privateEndpointConnectionName": "mySignalRService.1fa229cd-bf3f-47f0-8c49-afb36723997e" | ||
| }, | ||
| "responses": { | ||
| "202": { | ||
| "headers": { | ||
| "Location": "https://management.azure.com/subscriptions/subid/providers/Microsoft.SignalRService/...pathToOperationResult..." | ||
| } | ||
| }, | ||
| "204": {} | ||
| } | ||
| } |
29 changes: 29 additions & 0 deletions
29
...soft.SignalRService/stable/2018-10-01/examples/SignalRPrivateEndpointConnections_Get.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| { | ||
| "parameters": { | ||
| "api-version": "2018-10-01", | ||
| "subscriptionId": "00000000-0000-0000-0000-000000000000", | ||
| "resourceGroupName": "myResourceGroup", | ||
| "resourceName": "mySignalRService", | ||
| "privateEndpointConnectionName": "mySignalRService.1fa229cd-bf3f-47f0-8c49-afb36723997e" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "properties": { | ||
| "provisioningState": "Succeeded", | ||
| "privateEndpoint": { | ||
| "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/myResourceGroup/providers/Microsoft.Network/privateEndpoints/myPrivateEndpoint" | ||
| }, | ||
| "privateLinkServiceConnectionState": { | ||
| "status": "Approved", | ||
| "description": null, | ||
| "actionsRequired": "None" | ||
| } | ||
| }, | ||
| "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/myResourceGroup/providers/Microsoft.SignalRService/SignalR/mySignalRService/privateEndpointConnections/mySignalRService.1fa229cd-bf3f-47f0-8c49-afb36723997e", | ||
| "name": "mySignalRService.1fa229cd-bf3f-47f0-8c49-afb36723997e", | ||
| "type": "Microsoft.SignalRService/SignalR/privateEndpointConnections" | ||
| } | ||
| } | ||
| } | ||
| } |
31 changes: 31 additions & 0 deletions
31
...Microsoft.SignalRService/stable/2018-10-01/examples/SignalRPrivateLinkResources_List.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| { | ||
| "parameters": { | ||
| "api-version": "2018-10-01", | ||
| "subscriptionId": "00000000-0000-0000-0000-000000000000", | ||
| "resourceGroupName": "myResourceGroup", | ||
| "resourceName": "mySignalRService" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "value": [ | ||
| { | ||
| "properties": { | ||
| "groupId": "signalr", | ||
| "requiredMembers": [ | ||
| "signalr" | ||
| ], | ||
| "requiredZoneNames": [ | ||
| "privatelink.service.signalr.net" | ||
| ] | ||
| }, | ||
| "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.SignalRService/SignalR/privateLinkResources", | ||
| "name": "signalr", | ||
| "type": "privateLinkResources" | ||
| } | ||
| ], | ||
| "nextLink": "https://management.azure.com/subscriptions/subid/providers/Microsoft.SignalRService/...pathToMoreResults..." | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Async PUT should use the azure-asyncoperation header if it needs additional operation info, not location. https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/Addendum.md#creatingupdating-using-put