[DONOT MERGE] EventHub: Added New API to 2018-01-01-preview #8535

v-Ajnava · 2020-02-27T02:09:25Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

azure-pipelines · 2020-02-27T02:09:42Z

Azure Pipelines successfully started running 1 pipeline(s).

azuresdkci · 2020-02-27T02:10:33Z

Can one of the admins verify this patch?

openapi-sdkautomation · 2020-02-27T02:11:03Z

azure-sdk-for-go

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 36bc47d with merge commit 9070df912fe01a857db2a7a550776d5ba2a303ab. SDK Automation 13.0.17.20191226.1
⚠️eventhub/mgmt/2015-08-01 [Logs]
```
No file is changed.
```
⚠️eventhub/mgmt/2017-04-01 [Logs]
```
No file is changed.
```
️✔️preview/eventhub/mgmt/2018-01-01-preview [Logs] [Preview SDK Changes]
- preview.eventhub.mgmt.2018-01-01-preview.zip

openapi-sdkautomation · 2020-02-27T02:11:06Z

azure-sdk-for-net

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 36bc47d with merge commit 9070df912fe01a857db2a7a550776d5ba2a303ab. SDK Automation 13.0.17.20191226.1

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.EventHub [Logs] [Preview SDK Changes]
- Microsoft.Azure.Management.EventHub.2.5.0.nupkg
- Microsoft.Azure.Management.EventHub.2.5.0.snupkg

openapi-sdkautomation · 2020-02-27T02:11:06Z

azure-sdk-for-js

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 36bc47d with merge commit 9070df912fe01a857db2a7a550776d5ba2a303ab. SDK Automation 13.0.17.20191226.1

️✔️@azure/arm-eventhub [Logs] [Preview SDK Changes]

azure-arm-eventhub-3.2.0.tgz

[npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/eventHubManagementClient.js → ./dist/arm-eventhub.js...
[npmPack] created ./dist/arm-eventhub.js in 395ms

openapi-sdkautomation · 2020-02-27T02:11:10Z

azure-sdk-for-java

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 36bc47d with merge commit 9070df912fe01a857db2a7a550776d5ba2a303ab. SDK Automation 13.0.17.20191226.1
️✔️sdk/eventhubs/mgmt-v2015_08_01 [Logs] [Preview SDK Changes]
️✔️sdk/eventhubs/mgmt-v2017_04_01 [Logs] [Preview SDK Changes]

⚠️sdk/eventhubs/mgmt-v2018_01_01_preview [Logs] [Preview SDK Changes]

[mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/eventhubs/mgmt-v2018_01_01_preview/src/main/java/com/microsoft/azure/management/eventhubs/v2018_01_01_preview/implementation/EventHub2018PreviewManagementClientImpl.java:[222,72] incompatible types: com.microsoft.azure.management.eventhubs.v2018_01_01_preview.implementation.EventHub2018PreviewManagementClientImpl cannot be converted to com.microsoft.azure.management.eventhubs.v2018_01_01_preview.implementation.EventHubManagementClientImpl
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/eventhubs/mgmt-v2018_01_01_preview/src/main/java/com/microsoft/azure/management/eventhubs/v2018_01_01_preview/implementation/EventHub2018PreviewManagementClientImpl.java:[223,68] incompatible types: com.microsoft.azure.management.eventhubs.v2018_01_01_preview.implementation.EventHub2018PreviewManagementClientImpl cannot be converted to com.microsoft.azure.management.eventhubs.v2018_01_01_preview.implementation.EventHubManagementClientImpl
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/eventhubs/mgmt-v2018_01_01_preview/src/main/java/com/microsoft/azure/management/eventhubs/v2018_01_01_preview/implementation/EventHub2018PreviewManagementClientImpl.java:[224,80] incompatible types: com.microsoft.azure.management.eventhubs.v2018_01_01_preview.implementation.EventHub2018PreviewManagementClientImpl cannot be converted to com.microsoft.azure.management.eventhubs.v2018_01_01_preview.implementation.EventHubManagementClientImpl
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/eventhubs/mgmt-v2018_01_01_preview/src/main/java/com/microsoft/azure/management/eventhubs/v2018_01_01_preview/implementation/EventHub2018PreviewManagementClientImpl.java:[225,72] incompatible types: com.microsoft.azure.management.eventhubs.v2018_01_01_preview.implementation.EventHub2018PreviewManagementClientImpl cannot be converted to com.microsoft.azure.management.eventhubs.v2018_01_01_preview.implementation.EventHubManagementClientImpl
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-eventhubs: Compilation failure: Compilation failure: 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/eventhubs/mgmt-v2018_01_01_preview/src/main/java/com/microsoft/azure/management/eventhubs/v2018_01_01_preview/implementation/EventHub2018PreviewManagementClientImpl.java:[222,72] incompatible types: com.microsoft.azure.management.eventhubs.v2018_01_01_preview.implementation.EventHub2018PreviewManagementClientImpl cannot be converted to com.microsoft.azure.management.eventhubs.v2018_01_01_preview.implementation.EventHubManagementClientImpl
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/eventhubs/mgmt-v2018_01_01_preview/src/main/java/com/microsoft/azure/management/eventhubs/v2018_01_01_preview/implementation/EventHub2018PreviewManagementClientImpl.java:[223,68] incompatible types: com.microsoft.azure.management.eventhubs.v2018_01_01_preview.implementation.EventHub2018PreviewManagementClientImpl cannot be converted to com.microsoft.azure.management.eventhubs.v2018_01_01_preview.implementation.EventHubManagementClientImpl
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/eventhubs/mgmt-v2018_01_01_preview/src/main/java/com/microsoft/azure/management/eventhubs/v2018_01_01_preview/implementation/EventHub2018PreviewManagementClientImpl.java:[224,80] incompatible types: com.microsoft.azure.management.eventhubs.v2018_01_01_preview.implementation.EventHub2018PreviewManagementClientImpl cannot be converted to com.microsoft.azure.management.eventhubs.v2018_01_01_preview.implementation.EventHubManagementClientImpl
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/eventhubs/mgmt-v2018_01_01_preview/src/main/java/com/microsoft/azure/management/eventhubs/v2018_01_01_preview/implementation/EventHub2018PreviewManagementClientImpl.java:[225,72] incompatible types: com.microsoft.azure.management.eventhubs.v2018_01_01_preview.implementation.EventHub2018PreviewManagementClientImpl cannot be converted to com.microsoft.azure.management.eventhubs.v2018_01_01_preview.implementation.EventHubManagementClientImpl
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

openapi-sdkautomation · 2020-02-27T02:11:13Z

azure-sdk-for-python

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 36bc47d with merge commit 9070df912fe01a857db2a7a550776d5ba2a303ab. SDK Automation 13.0.17.20191226.1

️✔️azure-mgmt-eventhub [Logs] [Preview SDK Changes]

[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)

azure-pipelines · 2020-02-27T02:13:25Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-27T02:51:16Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-27T03:02:40Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-28T03:53:32Z

Azure Pipelines successfully started running 1 pipeline(s).

ryansbenson · 2020-02-28T22:13:18Z

...venthub/resource-manager/Microsoft.EventHub/preview/2018-01-01-preview/EventHub-preview.json

+            "$ref": "#/parameters/subscriptionIdParameter"
+          }
+        ],
+        "responses": {


Please include next link. If your service returns null for this field, that is perfectly fine. This will allow you to add paging later without a breaking change.

"x-ms-pageable": { "nextLinkName": "nextLink" }

we are deprecating this API, its supported in older versions. removed from swagger.

...venthub/resource-manager/Microsoft.EventHub/preview/2018-01-01-preview/EventHub-preview.json

azure-pipelines · 2020-03-03T01:53:47Z

Azure Pipelines successfully started running 1 pipeline(s).

v-Ajnava · 2020-03-03T18:43:42Z

@ryansbenson updated with changes and comments. One quick questions, is it okay to remove the changesrequested label to show up as review requested.

ravbhatnagar · 2020-03-06T23:33:46Z

Signing off from ARM side as Ryan's comments have been addressed.

azure-pipelines · 2020-03-09T17:41:43Z

Azure Pipelines successfully started running 1 pipeline(s).

akning-ms · 2020-11-25T09:09:59Z

Hi @v-Ajnava, is this PR still valid, as it is idle for a long time, looks this version(2018-01-01-preview) is already merged. if it is not in use. can you help close it?

v-Ajnava · 2020-12-14T07:10:24Z

closing the PR as its not need know.

Added New API to 2018-0101-preview

152c007

openapi-assignment-bot bot assigned zikalino Feb 27, 2020

v-Ajnava changed the title ~~EventHub: Added New API to 2018-0101-preview~~ EventHub: Added New API to 2018-01-01-preview Feb 27, 2020

fixed Avocado errors

f89d3ae

fixed errors

5ed624a

fixed formating

b6e174d

v-Ajnava added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 28, 2020

ryansbenson reviewed Feb 28, 2020

View reviewed changes

ryansbenson added the ARMChangesRequested label Feb 28, 2020

updated with review comments

36bc47d

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 6, 2020

ravbhatnagar approved these changes Mar 6, 2020

View reviewed changes

v-Ajnava changed the title ~~EventHub: Added New API to 2018-01-01-preview~~ [DONOT MERGE] EventHub: Added New API to 2018-01-01-preview Mar 9, 2020

v-Ajnava added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Mar 9, 2020

akning-ms assigned ruowan and unassigned zikalino Nov 25, 2020

akning-ms added the Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review label Nov 25, 2020

v-Ajnava closed this Dec 14, 2020

[DONOT MERGE] EventHub: Added New API to 2018-01-01-preview #8535

[DONOT MERGE] EventHub: Added New API to 2018-01-01-preview #8535

Uh oh!

Conversation

v-Ajnava commented Feb 27, 2020

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

azure-pipelines bot commented Feb 27, 2020

Uh oh!

azuresdkci commented Feb 27, 2020

Uh oh!

openapi-sdkautomation bot commented Feb 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go

Uh oh!

openapi-sdkautomation bot commented Feb 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net

Uh oh!

openapi-sdkautomation bot commented Feb 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js

Uh oh!

openapi-sdkautomation bot commented Feb 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java

Uh oh!

openapi-sdkautomation bot commented Feb 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python

Uh oh!

azure-pipelines bot commented Feb 27, 2020

Uh oh!

azure-pipelines bot commented Feb 27, 2020

Uh oh!

azure-pipelines bot commented Feb 27, 2020

Uh oh!

azure-pipelines bot commented Feb 28, 2020

Uh oh!

ryansbenson Feb 28, 2020

Choose a reason for hiding this comment

Uh oh!

v-Ajnava Mar 3, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

azure-pipelines bot commented Mar 3, 2020

Uh oh!

v-Ajnava commented Mar 3, 2020

Uh oh!

ravbhatnagar commented Mar 6, 2020

Uh oh!

azure-pipelines bot commented Mar 9, 2020

Uh oh!

akning-ms commented Nov 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

v-Ajnava commented Dec 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

openapi-sdkautomation bot commented Feb 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 27, 2020 •

edited

Loading

akning-ms commented Nov 25, 2020 •

edited

Loading