Skip to content

added sku to managed cluster api #8426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PhoenixHe-NV merged 2 commits into from
Feb 21, 2020
Merged

added sku to managed cluster api #8426

PhoenixHe-NV merged 2 commits into from
Feb 21, 2020

Conversation

@mslonli
Copy link
Contributor

@mslonli mslonli commented Feb 18, 2020

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented Feb 18, 2020

You don't have permission to trigger SDK Automation.
Please add yourself to Azure group from opensource portal if you are MSFT employee,
or please ask reviewer to add comment *** /openapibot sdkautomation ***.
Please ask [email protected] (or NullMDR in github) for additional help.

@msftclas
Copy link

msftclas commented Feb 18, 2020

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ mslonli sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@PhoenixHe-NV PhoenixHe-NV added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 19, 2020
ravbhatnagar
ravbhatnagar reviewed Feb 20, 2020
View reviewed changes
Copy link
Contributor

@ravbhatnagar ravbhatnagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signing off

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 20, 2020
@PhoenixHe-NV PhoenixHe-NV merged commit e3c37f5 into Azure:dev-containerservice-Microsoft.ContainerService-2020-03-01 Feb 21, 2020
@xizha162 xizha162 mentioned this pull request Mar 18, 2020
Merged
5 tasks
PhoenixHe-NV pushed a commit that referenced this pull request Mar 19, 2020
@mslonli @zqingqing1
@JunSun17 @norshtein @karataliu @marwanad
Publish Microsoft.ContainerService api-version 2020-03-01 (#8756)
08c4662 
* Adds base for updating Microsoft.ContainerService from version stable/2020-02-01 to version 2020-03-01

* Updates readme

* Updates API version in new specs and examples

* added sku to managed cluster api (#8426)

* added sku to managed cluster api

* move managedcluster sku data model location

* Generate sdk (#8512)

* Adds base for updating Microsoft.ContainerService from version stable/2019-02-01 to version 2019-04-01

* Updates readme

* Updates API version in new specs and examples

* Adding windowsProfile and maxAgentPools property in the new 2019-04-01 api version (#5465)

* add maxAgentPools and windowsprofile properties

* fixing the sdk generation error

* adding load balancer sku property (#5556)

* Add support VMSS agent nodes with public IP. (#5748)

* Add identity property in managedCluster definition and add an example (#5709)

* Add identity property in managedCluster definition and add an example

* Fix typo

* readmefor generating sdks

* remove weird file

Co-authored-by: Xiaofang Zhang <[email protected]>
Co-authored-by: Jun Sun <[email protected]>
Co-authored-by: Tongyao Si <[email protected]>

* Add managed AAD section (#8429)

* add agentpool mode property (#8534)

* add balance nodegroups flag (#8571)

Co-authored-by: mslonli <[email protected]>
Co-authored-by: Qingqing <[email protected]>
Co-authored-by: Jun Sun <[email protected]>
Co-authored-by: Tongyao Si <[email protected]>
Co-authored-by: Dong Liu <[email protected]>
Co-authored-by: Marwan Ahmed <[email protected]>
00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
@mslonli @zqingqing1
@JunSun17 @norshtein @karataliu @marwanad @00Kai0
Publish Microsoft.ContainerService api-version 2020-03-01 (Azure#8756)
d478ece 
* Adds base for updating Microsoft.ContainerService from version stable/2020-02-01 to version 2020-03-01

* Updates readme

* Updates API version in new specs and examples

* added sku to managed cluster api (Azure#8426)

* added sku to managed cluster api

* move managedcluster sku data model location

* Generate sdk (Azure#8512)

* Adds base for updating Microsoft.ContainerService from version stable/2019-02-01 to version 2019-04-01

* Updates readme

* Updates API version in new specs and examples

* Adding windowsProfile and maxAgentPools property in the new 2019-04-01 api version (Azure#5465)

* add maxAgentPools and windowsprofile properties

* fixing the sdk generation error

* adding load balancer sku property (Azure#5556)

* Add support VMSS agent nodes with public IP. (Azure#5748)

* Add identity property in managedCluster definition and add an example (Azure#5709)

* Add identity property in managedCluster definition and add an example

* Fix typo

* readmefor generating sdks

* remove weird file

Co-authored-by: Xiaofang Zhang <[email protected]>
Co-authored-by: Jun Sun <[email protected]>
Co-authored-by: Tongyao Si <[email protected]>

* Add managed AAD section (Azure#8429)

* add agentpool mode property (Azure#8534)

* add balance nodegroups flag (Azure#8571)

Co-authored-by: mslonli <[email protected]>
Co-authored-by: Qingqing <[email protected]>
Co-authored-by: Jun Sun <[email protected]>
Co-authored-by: Tongyao Si <[email protected]>
Co-authored-by: Dong Liu <[email protected]>
Co-authored-by: Marwan Ahmed <[email protected]>
weidongxu-microsoft pushed a commit that referenced this pull request Sep 27, 2021
@zqingqing1 @JunSun17
@norshtein @mslonli
Improve desire count desc (#16155)
8b68929 
* Adds base for updating Microsoft.ContainerService from version stable/2019-02-01 to version 2019-04-01

* Updates readme

* Updates API version in new specs and examples

* Adding windowsProfile and maxAgentPools property in the new 2019-04-01 api version (#5465)

* add maxAgentPools and windowsprofile properties

* fixing the sdk generation error

* adding load balancer sku property (#5556)

* Add support VMSS agent nodes with public IP. (#5748)

* Add identity property in managedCluster definition and add an example (#5709)

* Add identity property in managedCluster definition and add an example

* Fix typo

* Adds base for updating Microsoft.ContainerService from version stable/2020-02-01 to version 2020-03-01

* Updates readme

* Updates API version in new specs and examples

* added sku to managed cluster api (#8426)

* added sku to managed cluster api

* move managedcluster sku data model location

* improve count description

* remove useless file

Co-authored-by: Xiaofang Zhang <[email protected]>
Co-authored-by: Jun Sun <[email protected]>
Co-authored-by: Tongyao Si <[email protected]>
Co-authored-by: mslonli <[email protected]>
Hardell pushed a commit to Hardell/azure-rest-api-specs that referenced this pull request Sep 27, 2021
@zqingqing1 @JunSun17
@norshtein @mslonli
Improve desire count desc (Azure#16155)
0a8fb81 
* Adds base for updating Microsoft.ContainerService from version stable/2019-02-01 to version 2019-04-01

* Updates readme

* Updates API version in new specs and examples

* Adding windowsProfile and maxAgentPools property in the new 2019-04-01 api version (Azure#5465)

* add maxAgentPools and windowsprofile properties

* fixing the sdk generation error

* adding load balancer sku property (Azure#5556)

* Add support VMSS agent nodes with public IP. (Azure#5748)

* Add identity property in managedCluster definition and add an example (Azure#5709)

* Add identity property in managedCluster definition and add an example

* Fix typo

* Adds base for updating Microsoft.ContainerService from version stable/2020-02-01 to version 2020-03-01

* Updates readme

* Updates API version in new specs and examples

* added sku to managed cluster api (Azure#8426)

* added sku to managed cluster api

* move managedcluster sku data model location

* improve count description

* remove useless file

Co-authored-by: Xiaofang Zhang <[email protected]>
Co-authored-by: Jun Sun <[email protected]>
Co-authored-by: Tongyao Si <[email protected]>
Co-authored-by: mslonli <[email protected]>
LeiWang3 pushed a commit to LeiWang3/azure-rest-api-specs that referenced this pull request Mar 31, 2022
@zqingqing1 @JunSun17
@norshtein @mslonli @Leiwang3SQL
Improve desire count desc (Azure#16155)
feeb9e5 
* Adds base for updating Microsoft.ContainerService from version stable/2019-02-01 to version 2019-04-01

* Updates readme

* Updates API version in new specs and examples

* Adding windowsProfile and maxAgentPools property in the new 2019-04-01 api version (Azure#5465)

* add maxAgentPools and windowsprofile properties

* fixing the sdk generation error

* adding load balancer sku property (Azure#5556)

* Add support VMSS agent nodes with public IP. (Azure#5748)

* Add identity property in managedCluster definition and add an example (Azure#5709)

* Add identity property in managedCluster definition and add an example

* Fix typo

* Adds base for updating Microsoft.ContainerService from version stable/2020-02-01 to version 2020-03-01

* Updates readme

* Updates API version in new specs and examples

* added sku to managed cluster api (Azure#8426)

* added sku to managed cluster api

* move managedcluster sku data model location

* improve count description

* remove useless file

Co-authored-by: Xiaofang Zhang <[email protected]>
Co-authored-by: Jun Sun <[email protected]>
Co-authored-by: Tongyao Si <[email protected]>
Co-authored-by: mslonli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ravbhatnagar ravbhatnagar ravbhatnagar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@PhoenixHe-NV PhoenixHe-NV

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mslonli @AutorestCI @msftclas @ravbhatnagar @PhoenixHe-NV